* [PATCH v2 1/4] ARM: dts: microchip: Rename the eeprom nodename
2024-10-01 15:25 [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
@ 2024-10-01 15:25 ` Andrei Simion
2024-10-01 15:25 ` [PATCH v2 2/4] ARM: dts: microchip: Rename the pmic node Andrei Simion
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Andrei Simion @ 2024-10-01 15:25 UTC (permalink / raw)
To: nicolas.ferre, claudiu.beznea, alexandre.belloni, robh, krzk+dt,
conor+dt
Cc: linux-arm-kernel, linux-kernel, devicetree, Andrei Simion
Align the eeprom nodename according to devicetree specification and
at24.yaml
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
v1 -> v2:
- adjust commit message length
---
arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts | 2 +-
arch/arm/boot/dts/microchip/at91sam9260ek.dts | 2 +-
arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi | 2 +-
arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
index 95ecb7d040a8..8ac85dac5a96 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
+++ b/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
@@ -106,7 +106,7 @@ i2c0: i2c@f8028000 {
scl-gpios = <&pioA PIN_PD22 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
status = "okay";
- at24@50 {
+ eeprom@50 {
compatible = "atmel,24c02";
reg = <0x50>;
pagesize = <8>;
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts
index 200b20515ab1..e4ae60ef5f8a 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts
@@ -231,7 +231,7 @@ i2c1: i2c@fc028000 {
scl-gpios = <&pioA PIN_PC7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
status = "okay";
- at24@50 {
+ eeprom@50 {
compatible = "atmel,24c02";
reg = <0x50>;
pagesize = <8>;
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts
index 6680031387e8..4bab3f25b855 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts
@@ -411,7 +411,7 @@ i2c1: i2c@fc028000 {
scl-gpios = <&pioA PIN_PD5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
status = "okay";
- at24@54 {
+ eeprom@54 {
compatible = "atmel,24c02";
reg = <0x54>;
pagesize = <16>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9260ek.dts b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
index 720c15472c4a..6bd60dce8378 100644
--- a/arch/arm/boot/dts/microchip/at91sam9260ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
@@ -165,7 +165,7 @@ button-4 {
i2c-gpio-0 {
status = "okay";
- 24c512@50 {
+ eeprom@50 {
compatible = "atmel,24c512";
reg = <0x50>;
};
diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
index ce8baff6a9f4..bad7dbecba3c 100644
--- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
@@ -253,7 +253,7 @@ button-right-click {
i2c-gpio-0 {
status = "okay";
- 24c512@50 {
+ eeprom@50 {
compatible = "atmel,24c512";
reg = <0x50>;
pagesize = <128>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi b/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi
index 565b99e79c52..4e7cfbbd4241 100644
--- a/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi
+++ b/arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi
@@ -220,7 +220,7 @@ usb0: ohci@500000 {
i2c-gpio-0 {
status = "okay";
- 24c512@50 {
+ eeprom@50 {
compatible = "atmel,24c512";
reg = <0x50>;
vcc-supply = <®_3v3>;
diff --git a/arch/arm/boot/dts/microchip/sama5d34ek.dts b/arch/arm/boot/dts/microchip/sama5d34ek.dts
index bffd61397cb5..18943b873fff 100644
--- a/arch/arm/boot/dts/microchip/sama5d34ek.dts
+++ b/arch/arm/boot/dts/microchip/sama5d34ek.dts
@@ -36,7 +36,7 @@ i2c0: i2c@f0014000 {
i2c1: i2c@f0018000 {
status = "okay";
- 24c256@50 {
+ eeprom@50 {
compatible = "atmel,24c256";
reg = <0x50>;
pagesize = <64>;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 2/4] ARM: dts: microchip: Rename the pmic node
2024-10-01 15:25 [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
2024-10-01 15:25 ` [PATCH v2 1/4] ARM: dts: microchip: Rename the eeprom nodename Andrei Simion
@ 2024-10-01 15:25 ` Andrei Simion
2024-10-01 15:25 ` [PATCH v2 3/4] ARM: dts: microchip: Rename LED sub nodes name Andrei Simion
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Andrei Simion @ 2024-10-01 15:25 UTC (permalink / raw)
To: nicolas.ferre, claudiu.beznea, alexandre.belloni, robh, krzk+dt,
conor+dt
Cc: linux-arm-kernel, linux-kernel, devicetree, Andrei Simion
Rename the pmic node according to the devicetree specification.
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
v1 -> v2:
- act8865 to pmic nodename
- label pmic to act8865 for pmic
- rewrap commit message
---
arch/arm/boot/dts/microchip/at91-kizbox2-common.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts | 2 +-
arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 2 +-
arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/microchip/at91-kizbox2-common.dtsi b/arch/arm/boot/dts/microchip/at91-kizbox2-common.dtsi
index e5e21dff882f..a44d92305dbb 100644
--- a/arch/arm/boot/dts/microchip/at91-kizbox2-common.dtsi
+++ b/arch/arm/boot/dts/microchip/at91-kizbox2-common.dtsi
@@ -85,7 +85,7 @@ led-3 {
&i2c1 {
status = "okay";
- pmic: act8865@5b {
+ act8865: pmic@5b {
compatible = "active-semi,act8865";
reg = <0x5b>;
status = "okay";
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
index c173f49cb910..ef11606a82b3 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
+++ b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
@@ -75,7 +75,7 @@ &i2c1 {
scl-gpios = <&pioA PIN_PD20 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
status = "okay";
- mcp16502@5b {
+ pmic@5b {
compatible = "microchip,mcp16502";
reg = <0x5b>;
lvin-supply = <®_5v>;
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts
index 951a0c97d3c6..b6684bf67d3e 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts
@@ -149,7 +149,7 @@ &i2c0 {
i2c-sda-hold-time-ns = <350>;
status = "okay";
- mcp16502@5b {
+ pmic@5b {
compatible = "microchip,mcp16502";
reg = <0x5b>;
lvin-supply = <®_5v>;
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
index 5e2bb517a480..9edf91c187c0 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
@@ -195,7 +195,7 @@ i2c6: i2c@600 {
i2c-digital-filter-width-ns = <35>;
status = "okay";
- mcp16502@5b {
+ pmic@5b {
compatible = "microchip,mcp16502";
reg = <0x5b>;
lvin-supply = <®_5v>;
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts
index 820033727088..5662992cf213 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts
@@ -87,7 +87,7 @@ i2c0: i2c@f0014000 {
i2c1: i2c@f0018000 {
status = "okay";
- pmic: act8865@5b {
+ act8865: pmic@5b {
compatible = "active-semi,act8865";
reg = <0x5b>;
status = "disabled";
diff --git a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
index ed75d491a246..f7bcc96bcd19 100644
--- a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
@@ -244,7 +244,7 @@ i2c1: i2c@600 {
i2c-digital-filter-width-ns = <35>;
status = "okay";
- mcp16502@5b {
+ pmic@5b {
compatible = "microchip,mcp16502";
reg = <0x5b>;
lvin-supply = <®_5v>;
diff --git a/arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi b/arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi
index 830a0954ba1b..362806afef44 100644
--- a/arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi
+++ b/arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi
@@ -79,7 +79,7 @@ ethernet-phy@7 {
};
i2c1: i2c@f0018000 {
- pmic: act8865@5b {
+ act8865: pmic@5b {
compatible = "active-semi,act8865";
reg = <0x5b>;
status = "disabled";
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 3/4] ARM: dts: microchip: Rename LED sub nodes name
2024-10-01 15:25 [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
2024-10-01 15:25 ` [PATCH v2 1/4] ARM: dts: microchip: Rename the eeprom nodename Andrei Simion
2024-10-01 15:25 ` [PATCH v2 2/4] ARM: dts: microchip: Rename the pmic node Andrei Simion
@ 2024-10-01 15:25 ` Andrei Simion
2024-10-01 15:25 ` [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes Andrei Simion
2024-10-02 3:52 ` [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Rob Herring (Arm)
4 siblings, 0 replies; 9+ messages in thread
From: Andrei Simion @ 2024-10-01 15:25 UTC (permalink / raw)
To: nicolas.ferre, claudiu.beznea, alexandre.belloni, robh, krzk+dt,
conor+dt
Cc: linux-arm-kernel, linux-kernel, devicetree, Andrei Simion,
Krzysztof Kozlowski
dtbs_check warnings:
leds: 'd[0-9]', 'ds[0-9]' do not match any of the regexes :
'(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
leds: 'red', 'green', 'blue' do not match any of regexes :
'(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
Rename the led sub nodes according to devicetree specification and
leds-gpio.yaml
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
v1 -> v2:
- add acked-by
- use pattern led-<old-label> when rename sub nodes
- rewrap commit message
---
arch/arm/boot/dts/microchip/aks-cdu.dts | 8 ++++----
arch/arm/boot/dts/microchip/animeo_ip.dts | 8 ++++----
arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 6 +++---
arch/arm/boot/dts/microchip/at91rm9200ek.dts | 6 +++---
arch/arm/boot/dts/microchip/at91sam9260ek.dts | 4 ++--
arch/arm/boot/dts/microchip/at91sam9261ek.dts | 6 +++---
arch/arm/boot/dts/microchip/at91sam9263ek.dts | 4 ++--
arch/arm/boot/dts/microchip/at91sam9g20ek.dts | 4 ++--
8 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
index 742fcf525e1b..0c3373ad1723 100644
--- a/arch/arm/boot/dts/microchip/aks-cdu.dts
+++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
@@ -98,23 +98,23 @@ rootfs@500000 {
leds {
compatible = "gpio-leds";
- red {
+ led-red {
gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "none";
};
- green {
+ led-green {
gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
default-state = "on";
};
- yellow {
+ led-yellow {
gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
};
- blue {
+ led-blue {
gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
};
diff --git a/arch/arm/boot/dts/microchip/animeo_ip.dts b/arch/arm/boot/dts/microchip/animeo_ip.dts
index 29936bfbeeb7..7f527622d3f2 100644
--- a/arch/arm/boot/dts/microchip/animeo_ip.dts
+++ b/arch/arm/boot/dts/microchip/animeo_ip.dts
@@ -146,23 +146,23 @@ usb0: ohci@500000 {
leds {
compatible = "gpio-leds";
- power_green {
+ led-power-green {
label = "power_green";
gpios = <&pioC 17 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
- power_red {
+ led-power-red {
label = "power_red";
gpios = <&pioA 2 GPIO_ACTIVE_HIGH>;
};
- tx_green {
+ led-tx-green {
label = "tx_green";
gpios = <&pioC 19 GPIO_ACTIVE_HIGH>;
};
- tx_red {
+ led-tx-red {
label = "tx_red";
gpios = <&pioC 18 GPIO_ACTIVE_HIGH>;
};
diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
index 3b38707d736e..c416cbe99580 100644
--- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
@@ -53,17 +53,17 @@ leds {
pinctrl-0 = <&pinctrl_gpio_leds>;
status = "okay"; /* Conflict with pwm0. */
- red {
+ led-red {
label = "red";
gpios = <&pioB 11 GPIO_ACTIVE_HIGH>;
};
- green {
+ led-green {
label = "green";
gpios = <&pioB 12 GPIO_ACTIVE_HIGH>;
};
- blue {
+ led-blue {
label = "blue";
gpios = <&pioB 13 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
diff --git a/arch/arm/boot/dts/microchip/at91rm9200ek.dts b/arch/arm/boot/dts/microchip/at91rm9200ek.dts
index 4624a6f076f8..0bf472b157a5 100644
--- a/arch/arm/boot/dts/microchip/at91rm9200ek.dts
+++ b/arch/arm/boot/dts/microchip/at91rm9200ek.dts
@@ -127,19 +127,19 @@ root@350000 {
leds {
compatible = "gpio-leds";
- ds2 {
+ led-ds2 {
label = "green";
gpios = <&pioB 0 GPIO_ACTIVE_LOW>;
linux,default-trigger = "mmc0";
};
- ds4 {
+ led-ds4 {
label = "yellow";
gpios = <&pioB 1 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
- ds6 {
+ led-ds6 {
label = "red";
gpios = <&pioB 2 GPIO_ACTIVE_LOW>;
};
diff --git a/arch/arm/boot/dts/microchip/at91sam9260ek.dts b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
index 6bd60dce8378..e8e65e60564d 100644
--- a/arch/arm/boot/dts/microchip/at91sam9260ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
@@ -174,13 +174,13 @@ eeprom@50 {
leds {
compatible = "gpio-leds";
- ds1 {
+ led-ds1 {
label = "ds1";
gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
- ds5 {
+ led-ds5 {
label = "ds5";
gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
};
diff --git a/arch/arm/boot/dts/microchip/at91sam9261ek.dts b/arch/arm/boot/dts/microchip/at91sam9261ek.dts
index 045cb253f23a..a8f523131cd6 100644
--- a/arch/arm/boot/dts/microchip/at91sam9261ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9261ek.dts
@@ -192,19 +192,19 @@ watchdog@fffffd40 {
leds {
compatible = "gpio-leds";
- ds8 {
+ led-ds8 {
label = "ds8";
gpios = <&pioA 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
};
- ds7 {
+ led-ds7 {
label = "ds7";
gpios = <&pioA 14 GPIO_ACTIVE_LOW>;
linux,default-trigger = "nand-disk";
};
- ds1 {
+ led-ds1 {
label = "ds1";
gpios = <&pioA 23 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
index bad7dbecba3c..f25692543d71 100644
--- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
@@ -219,13 +219,13 @@ &pioA 21 GPIO_ACTIVE_HIGH
leds {
compatible = "gpio-leds";
- d3 {
+ led-d3 {
label = "d3";
gpios = <&pioB 7 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
- d2 {
+ led-d2 {
label = "d2";
gpios = <&pioC 29 GPIO_ACTIVE_LOW>;
linux,default-trigger = "nand-disk";
diff --git a/arch/arm/boot/dts/microchip/at91sam9g20ek.dts b/arch/arm/boot/dts/microchip/at91sam9g20ek.dts
index 6de7a7cd3c07..1e62fd371ddb 100644
--- a/arch/arm/boot/dts/microchip/at91sam9g20ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9g20ek.dts
@@ -14,13 +14,13 @@ / {
leds {
compatible = "gpio-leds";
- ds1 {
+ led-ds1 {
label = "ds1";
gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
- ds5 {
+ led-ds5 {
label = "ds5";
gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes
2024-10-01 15:25 [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
` (2 preceding siblings ...)
2024-10-01 15:25 ` [PATCH v2 3/4] ARM: dts: microchip: Rename LED sub nodes name Andrei Simion
@ 2024-10-01 15:25 ` Andrei Simion
2024-10-01 15:31 ` Conor Dooley
2024-10-02 3:52 ` [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Rob Herring (Arm)
4 siblings, 1 reply; 9+ messages in thread
From: Andrei Simion @ 2024-10-01 15:25 UTC (permalink / raw)
To: nicolas.ferre, claudiu.beznea, alexandre.belloni, robh, krzk+dt,
conor+dt
Cc: linux-arm-kernel, linux-kernel, devicetree, Andrei Simion,
Alexander Dhal
Add the label property here and use the old node name as value to stay
stable and avoid breaking the userspace applications that depend on those
paths.
Suggested-by: Alexander Dhal <ada@thorsis.com>
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
v1 -> v2:
- added in v2 by suggestion of Alexander Dhal
---
arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
index 0c3373ad1723..b65f80e1ef05 100644
--- a/arch/arm/boot/dts/microchip/aks-cdu.dts
+++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
@@ -99,22 +99,26 @@ leds {
compatible = "gpio-leds";
led-red {
+ label = "red";
gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "none";
};
led-green {
+ label = "green";
gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
default-state = "on";
};
led-yellow {
+ label = "yellow";
gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
};
led-blue {
+ label = "blue";
gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
linux,default-trigger = "none";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes
2024-10-01 15:25 ` [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes Andrei Simion
@ 2024-10-01 15:31 ` Conor Dooley
2024-10-02 10:30 ` Andrei Simion
0 siblings, 1 reply; 9+ messages in thread
From: Conor Dooley @ 2024-10-01 15:31 UTC (permalink / raw)
To: Andrei Simion
Cc: nicolas.ferre, claudiu.beznea, alexandre.belloni, robh, krzk+dt,
conor+dt, linux-arm-kernel, linux-kernel, devicetree,
Alexander Dhal
[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]
On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote:
> Add the label property here and use the old node name as value to stay
> stable and avoid breaking the userspace applications that depend on those
> paths.
>
> Suggested-by: Alexander Dhal <ada@thorsis.com>
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
Shouldn't this be squashed with 3/4 so as not to break it in one commit,
only to fix it in another?
> ---
> v1 -> v2:
> - added in v2 by suggestion of Alexander Dhal
> ---
> arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
> index 0c3373ad1723..b65f80e1ef05 100644
> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
> @@ -99,22 +99,26 @@ leds {
> compatible = "gpio-leds";
>
> led-red {
> + label = "red";
> gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "none";
> };
>
> led-green {
> + label = "green";
> gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> default-state = "on";
> };
>
> led-yellow {
> + label = "yellow";
> gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> };
>
> led-blue {
> + label = "blue";
> gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> };
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes
2024-10-01 15:31 ` Conor Dooley
@ 2024-10-02 10:30 ` Andrei Simion
2024-10-02 10:42 ` Alexander Dahl
0 siblings, 1 reply; 9+ messages in thread
From: Andrei Simion @ 2024-10-02 10:30 UTC (permalink / raw)
To: conor
Cc: ada, alexandre.belloni, andrei.simion, claudiu.beznea, conor+dt,
devicetree, krzk+dt, linux-arm-kernel, linux-kernel,
nicolas.ferre, robh
> On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote:
>> Add the label property here and use the old node name as value to stay
>> stable and avoid breaking the userspace applications that depend on those
>> paths.
>>
>> Suggested-by: Alexander Dhal <ada@thorsis.com>
>> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> Shouldn't this be squashed with 3/4 so as not to break it in one commit,
> only to fix it in another?
>
Hi,
My intent here was to give credits.
If this approach is unnecessary, I will do squash in V3.
Best Regards,
Andrei Simion
>> ---
>> v1 -> v2:
>> - added in v2 by suggestion of Alexander Dhal
>> ---
>> arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
>> index 0c3373ad1723..b65f80e1ef05 100644
>> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
>> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
>> @@ -99,22 +99,26 @@ leds {
>> compatible = "gpio-leds";
>>
>> led-red {
>> + label = "red";
>> gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
>> linux,default-trigger = "none";
>> };
>>
>> led-green {
>> + label = "green";
>> gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "none";
>> default-state = "on";
>> };
>>
>> led-yellow {
>> + label = "yellow";
>> gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "none";
>> };
>>
>> led-blue {
>> + label = "blue";
>> gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "none";
>> };
>> --
>> 2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes
2024-10-02 10:30 ` Andrei Simion
@ 2024-10-02 10:42 ` Alexander Dahl
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Dahl @ 2024-10-02 10:42 UTC (permalink / raw)
To: Andrei Simion
Cc: conor, ada, alexandre.belloni, claudiu.beznea, conor+dt,
devicetree, krzk+dt, linux-arm-kernel, linux-kernel,
nicolas.ferre, robh
Hello Andrei,
Am Wed, Oct 02, 2024 at 01:30:45PM +0300 schrieb Andrei Simion:
> > On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote:
> >> Add the label property here and use the old node name as value to stay
> >> stable and avoid breaking the userspace applications that depend on those
> >> paths.
> >>
> >> Suggested-by: Alexander Dhal <ada@thorsis.com>
> >> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> > Shouldn't this be squashed with 3/4 so as not to break it in one commit,
> > only to fix it in another?
> >
>
> Hi,
>
> My intent here was to give credits.
Appreciate this. And just noticed you got my last name wrong. ;-)
Credit is recorded in this thread now, this is sufficient.
> If this approach is unnecessary, I will do squash in V3.
Conor is right here. Please squash.
Greets
Alex
>
> Best Regards,
> Andrei Simion
>
> >> ---
> >> v1 -> v2:
> >> - added in v2 by suggestion of Alexander Dhal
> >> ---
> >> arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
> >> index 0c3373ad1723..b65f80e1ef05 100644
> >> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
> >> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
> >> @@ -99,22 +99,26 @@ leds {
> >> compatible = "gpio-leds";
> >>
> >> led-red {
> >> + label = "red";
> >> gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
> >> linux,default-trigger = "none";
> >> };
> >>
> >> led-green {
> >> + label = "green";
> >> gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
> >> linux,default-trigger = "none";
> >> default-state = "on";
> >> };
> >>
> >> led-yellow {
> >> + label = "yellow";
> >> gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
> >> linux,default-trigger = "none";
> >> };
> >>
> >> led-blue {
> >> + label = "blue";
> >> gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
> >> linux,default-trigger = "none";
> >> };
> >> --
> >> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91)
2024-10-01 15:25 [PATCH v2 0/4] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
` (3 preceding siblings ...)
2024-10-01 15:25 ` [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes Andrei Simion
@ 2024-10-02 3:52 ` Rob Herring (Arm)
4 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2024-10-02 3:52 UTC (permalink / raw)
To: Andrei Simion
Cc: claudiu.beznea, devicetree, alexandre.belloni, nicolas.ferre,
conor+dt, linux-arm-kernel, linux-kernel, krzk+dt
On Tue, 01 Oct 2024 18:25:37 +0300, Andrei Simion wrote:
> This patch series updates node names and labels in the Microchip ARM DTS
> files to align with Device Tree specificatios
>
> changelog:
> v1 -> v2:
> - drop patch : Rename the usb node
> - add patch : ARM: dts: microchip: aks-cdu: Add label for LED sub nodes
>
> Andrei Simion (4):
> ARM: dts: microchip: Rename the eeprom nodename
> ARM: dts: microchip: Rename the pmic node
> ARM: dts: microchip: Rename LED sub nodes name
> ARM: dts: microchip: aks-cdu: Add label for LED sub nodes
>
> arch/arm/boot/dts/microchip/aks-cdu.dts | 12 ++++++++----
> arch/arm/boot/dts/microchip/animeo_ip.dts | 8 ++++----
> arch/arm/boot/dts/microchip/at91-kizbox2-common.dtsi | 2 +-
> arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi | 2 +-
> .../arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi | 2 +-
> .../boot/dts/microchip/at91-sama5d29_curiosity.dts | 2 +-
> arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 2 +-
> arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts | 2 +-
> .../arm/boot/dts/microchip/at91-sama5d2_xplained.dts | 2 +-
> .../arm/boot/dts/microchip/at91-sama5d3_xplained.dts | 2 +-
> arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 2 +-
> arch/arm/boot/dts/microchip/at91rm9200ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91sam9260ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91sam9261ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91sam9g20ek.dts | 4 ++--
> .../arm/boot/dts/microchip/at91sam9g20ek_common.dtsi | 2 +-
> arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
> arch/arm/boot/dts/microchip/sama5d3xcm_cmp.dtsi | 2 +-
> 20 files changed, 41 insertions(+), 37 deletions(-)
>
>
> base-commit: 77df9e4bb2224d8ffbddec04c333a9d7965dad6c
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y microchip/aks-cdu.dtb microchip/animeo_ip.dtb microchip/at91-sam9x60ek.dtb microchip/at91-sama5d29_curiosity.dtb microchip/at91-sama5d2_icp.dtb microchip/at91-sama5d2_ptc_ek.dtb microchip/at91-sama5d2_xplained.dtb microchip/at91-sama5d3_xplained.dtb microchip/at91-sama7g5ek.dtb microchip/at91rm9200ek.dtb microchip/at91sam9260ek.dtb microchip/at91sam9261ek.dtb microchip/at91sam9263ek.dtb microchip/at91sam9g20ek.dtb microchip/sama5d34ek.dtb' for 20241001152541.91945-1-andrei.simion@microchip.com:
arch/arm/boot/dts/microchip/at91-sam9x60ek.dtb: /ahb/ebi@10000000/nand-controller: failed to match any schema with compatible: ['microchip,sam9x60-nand-controller']
^ permalink raw reply [flat|nested] 9+ messages in thread