From: Bjorn Helgaas <helgaas@kernel.org>
To: Fei Shao <fshao@chromium.org>
Cc: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Ryder Lee" <ryder.lee@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only
Date: Wed, 2 Oct 2024 15:31:08 -0500 [thread overview]
Message-ID: <20241002203108.GA269428@bhelgaas> (raw)
In-Reply-To: <20240925110044.3678055-3-fshao@chromium.org>
On Wed, Sep 25, 2024 at 06:57:46PM +0800, Fei Shao wrote:
> In MediaTek PCIe gen3 bindings, "clocks" accepts a range of 1-6 clocks
> across all SoCs. But in practice, each SoC requires a particular number
> of clocks as defined in "clock-names", and the length of "clocks" and
> "clock-names" can be inconsistent with current bindings.
>
> For example:
> - MT8188, MT8192 and MT8195 all require 6 clocks, while the bindings
> accept 4-6 clocks.
> - MT7986 requires 4 clocks, while the bindings accept 4-6 clocks.
>
> Update minItems and maxItems properties for individual SoCs as needed to
> only accept the correct number of clocks.
>
> Fixes: c6abd0eadec6 ("dt-bindings: PCI: mediatek-gen3: Add support for Airoha EN7581")
> Signed-off-by: Fei Shao <fshao@chromium.org>
This patch only applied to pci/dt-bindings with Krzysztof K's
reviewed-by for v6.13, thank you!
> ---
>
> .../devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 898c1be2d6a4..f05aab2b1add 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -149,7 +149,7 @@ allOf:
> then:
> properties:
> clocks:
> - minItems: 4
> + minItems: 6
>
> clock-names:
> items:
> @@ -178,7 +178,7 @@ allOf:
> then:
> properties:
> clocks:
> - minItems: 4
> + minItems: 6
>
> clock-names:
> items:
> @@ -207,6 +207,7 @@ allOf:
> properties:
> clocks:
> minItems: 4
> + maxItems: 4
>
> clock-names:
> items:
> --
> 2.46.0.792.g87dc391469-goog
>
next prev parent reply other threads:[~2024-10-02 20:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 10:57 [PATCH 0/6] MT8188 DT and binding fixes Fei Shao
2024-09-25 10:57 ` [PATCH 1/6] dt-bindings: power: mediatek: Add another nested power-domain layer Fei Shao
2024-09-25 10:57 ` [PATCH 2/6] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
2024-09-25 13:59 ` Krzysztof Kozlowski
2024-10-01 19:53 ` Bjorn Helgaas
2024-10-02 3:35 ` Fei Shao
2024-10-02 20:31 ` Bjorn Helgaas [this message]
2024-09-25 10:57 ` [PATCH 3/6] arm64: dts: mediatek: mt8188: Define CPU big core cluster Fei Shao
2024-09-26 8:33 ` AngeloGioacchino Del Regno
2024-09-26 10:41 ` Fei Shao
2024-09-25 10:57 ` [PATCH 4/6] arm64: dts: mediatek: mt8188: Add missing dma-ranges to soc node Fei Shao
2024-09-26 8:33 ` AngeloGioacchino Del Regno
2024-09-25 10:57 ` [PATCH 5/6] arm64: dts: mediatek: mt8188: Move vdec1 power domain under vdec0 Fei Shao
2024-09-26 8:33 ` AngeloGioacchino Del Regno
2024-09-26 10:42 ` Fei Shao
2024-09-30 9:35 ` Fei Shao
2024-09-25 10:57 ` [PATCH 6/6] arm64: dts: mediatek: mt8188: Update vppsys node names to syscon Fei Shao
2024-09-26 8:33 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002203108.GA269428@bhelgaas \
--to=helgaas@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fshao@chromium.org \
--cc=jianjun.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).