* [PATCH v7 1/6] misc: Add support for LAN966x PCI device
2024-10-03 8:16 [PATCH v7 0/6] Add support for the LAN966x PCI device using a DT overlay Herve Codina
@ 2024-10-03 8:16 ` Herve Codina
2024-10-03 9:13 ` Geert Uytterhoeven
2024-10-03 8:16 ` [PATCH v7 2/6] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
` (4 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Herve Codina @ 2024-10-03 8:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Herve Codina, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Steen Hegelund,
Luca Ceresoli, Thomas Petazzoni
Add a PCI driver that handles the LAN966x PCI device using a device-tree
overlay. This overlay is applied to the PCI device DT node and allows to
describe components that are present in the device.
The memory from the device-tree is remapped to the BAR memory thanks to
"ranges" properties computed at runtime by the PCI core during the PCI
enumeration.
The PCI device itself acts as an interrupt controller and is used as the
parent of the internal LAN966x interrupt controller to route the
interrupts to the assigned PCI INTx interrupt.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/misc/Kconfig | 24 ++++
drivers/misc/Makefile | 3 +
drivers/misc/lan966x_pci.c | 215 ++++++++++++++++++++++++++++++++++
drivers/misc/lan966x_pci.dtso | 167 ++++++++++++++++++++++++++
drivers/pci/quirks.c | 1 +
5 files changed, 410 insertions(+)
create mode 100644 drivers/misc/lan966x_pci.c
create mode 100644 drivers/misc/lan966x_pci.dtso
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 3fe7e2a9bd29..8e5b06ac9b6f 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -610,6 +610,30 @@ config MARVELL_CN10K_DPI
To compile this driver as a module, choose M here: the module
will be called mrvl_cn10k_dpi.
+config MCHP_LAN966X_PCI
+ tristate "Microchip LAN966x PCIe Support"
+ depends on PCI
+ select OF
+ select OF_OVERLAY
+ select IRQ_DOMAIN
+ help
+ This enables the support for the LAN966x PCIe device.
+ This is used to drive the LAN966x PCIe device from the host system
+ to which it is connected.
+
+ This driver uses an overlay to load other drivers to support for
+ LAN966x internal components.
+ Even if this driver does not depend on these other drivers, in order
+ to have a fully functional board, the following drivers are needed:
+ - fixed-clock (COMMON_CLK)
+ - lan966x-oic (LAN966X_OIC)
+ - lan966x-cpu-syscon (MFD_SYSCON)
+ - lan966x-switch-reset (RESET_MCHP_SPARX5)
+ - lan966x-pinctrl (PINCTRL_OCELOT)
+ - lan966x-serdes (PHY_LAN966X_SERDES)
+ - lan966x-miim (MDIO_MSCC_MIIM)
+ - lan966x-switch (LAN966X_SWITCH)
+
source "drivers/misc/c2port/Kconfig"
source "drivers/misc/eeprom/Kconfig"
source "drivers/misc/cb710/Kconfig"
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index a9f94525e181..885b22989580 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -71,4 +71,7 @@ obj-$(CONFIG_TPS6594_ESM) += tps6594-esm.o
obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
obj-$(CONFIG_NSM) += nsm.o
obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
+lan966x-pci-objs := lan966x_pci.o
+lan966x-pci-objs += lan966x_pci.dtbo.o
+obj-$(CONFIG_MCHP_LAN966X_PCI) += lan966x-pci.o
obj-y += keba/
diff --git a/drivers/misc/lan966x_pci.c b/drivers/misc/lan966x_pci.c
new file mode 100644
index 000000000000..9c79b58137e5
--- /dev/null
+++ b/drivers/misc/lan966x_pci.c
@@ -0,0 +1,215 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Microchip LAN966x PCI driver
+ *
+ * Copyright (c) 2024 Microchip Technology Inc. and its subsidiaries.
+ *
+ * Authors:
+ * Clément Léger <clement.leger@bootlin.com>
+ * Hervé Codina <herve.codina@bootlin.com>
+ */
+
+#include <linux/device.h>
+#include <linux/irq.h>
+#include <linux/irqdomain.h>
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/pci.h>
+#include <linux/pci_ids.h>
+#include <linux/slab.h>
+
+/* Embedded dtbo symbols created by cmd_wrap_S_dtb in scripts/Makefile.lib */
+extern char __dtbo_lan966x_pci_begin[];
+extern char __dtbo_lan966x_pci_end[];
+
+struct pci_dev_intr_ctrl {
+ struct pci_dev *pci_dev;
+ struct irq_domain *irq_domain;
+ int irq;
+};
+
+static int pci_dev_irq_domain_map(struct irq_domain *d, unsigned int virq, irq_hw_number_t hw)
+{
+ irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq);
+ return 0;
+}
+
+static const struct irq_domain_ops pci_dev_irq_domain_ops = {
+ .map = pci_dev_irq_domain_map,
+ .xlate = irq_domain_xlate_onecell,
+};
+
+static irqreturn_t pci_dev_irq_handler(int irq, void *data)
+{
+ struct pci_dev_intr_ctrl *intr_ctrl = data;
+ int ret;
+
+ ret = generic_handle_domain_irq(intr_ctrl->irq_domain, 0);
+ return ret ? IRQ_NONE : IRQ_HANDLED;
+}
+
+static struct pci_dev_intr_ctrl *pci_dev_create_intr_ctrl(struct pci_dev *pdev)
+{
+ struct pci_dev_intr_ctrl *intr_ctrl __free(kfree) = NULL;
+ struct fwnode_handle *fwnode;
+ int ret;
+
+ fwnode = dev_fwnode(&pdev->dev);
+ if (!fwnode)
+ return ERR_PTR(-ENODEV);
+
+ intr_ctrl = kmalloc(sizeof(*intr_ctrl), GFP_KERNEL);
+ if (!intr_ctrl)
+ return ERR_PTR(-ENOMEM);
+
+ intr_ctrl->pci_dev = pdev;
+
+ intr_ctrl->irq_domain = irq_domain_create_linear(fwnode, 1, &pci_dev_irq_domain_ops,
+ intr_ctrl);
+ if (!intr_ctrl->irq_domain) {
+ pci_err(pdev, "Failed to create irqdomain\n");
+ return ERR_PTR(-ENOMEM);
+ }
+
+ ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_INTX);
+ if (ret < 0) {
+ pci_err(pdev, "Unable alloc irq vector (%d)\n", ret);
+ goto err_remove_domain;
+ }
+ intr_ctrl->irq = pci_irq_vector(pdev, 0);
+ ret = request_irq(intr_ctrl->irq, pci_dev_irq_handler, IRQF_SHARED,
+ pci_name(pdev), intr_ctrl);
+ if (ret) {
+ pci_err(pdev, "Unable to request irq %d (%d)\n", intr_ctrl->irq, ret);
+ goto err_free_irq_vector;
+ }
+
+ return_ptr(intr_ctrl);
+
+err_free_irq_vector:
+ pci_free_irq_vectors(pdev);
+err_remove_domain:
+ irq_domain_remove(intr_ctrl->irq_domain);
+ return ERR_PTR(ret);
+}
+
+static void pci_dev_remove_intr_ctrl(struct pci_dev_intr_ctrl *intr_ctrl)
+{
+ free_irq(intr_ctrl->irq, intr_ctrl);
+ pci_free_irq_vectors(intr_ctrl->pci_dev);
+ irq_dispose_mapping(irq_find_mapping(intr_ctrl->irq_domain, 0));
+ irq_domain_remove(intr_ctrl->irq_domain);
+ kfree(intr_ctrl);
+}
+
+static void devm_pci_dev_remove_intr_ctrl(void *intr_ctrl)
+{
+ pci_dev_remove_intr_ctrl(intr_ctrl);
+}
+
+static int devm_pci_dev_create_intr_ctrl(struct pci_dev *pdev)
+{
+ struct pci_dev_intr_ctrl *intr_ctrl;
+
+ intr_ctrl = pci_dev_create_intr_ctrl(pdev);
+ if (IS_ERR(intr_ctrl))
+ return PTR_ERR(intr_ctrl);
+
+ return devm_add_action_or_reset(&pdev->dev, devm_pci_dev_remove_intr_ctrl, intr_ctrl);
+}
+
+struct lan966x_pci {
+ struct device *dev;
+ int ovcs_id;
+};
+
+static int lan966x_pci_load_overlay(struct lan966x_pci *data)
+{
+ u32 dtbo_size = __dtbo_lan966x_pci_end - __dtbo_lan966x_pci_begin;
+ void *dtbo_start = __dtbo_lan966x_pci_begin;
+
+ return of_overlay_fdt_apply(dtbo_start, dtbo_size, &data->ovcs_id, dev_of_node(data->dev));
+}
+
+static void lan966x_pci_unload_overlay(struct lan966x_pci *data)
+{
+ of_overlay_remove(&data->ovcs_id);
+}
+
+static int lan966x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
+{
+ struct device *dev = &pdev->dev;
+ struct lan966x_pci *data;
+ int ret;
+
+ /*
+ * On ACPI system, fwnode can point to the ACPI node.
+ * This driver needs an of_node to be used as the device-tree overlay
+ * target. This of_node should be set by the PCI core if it succeeds in
+ * creating it (CONFIG_PCI_DYNAMIC_OF_NODES feature).
+ * Check here for the validity of this of_node.
+ */
+ if (!dev_of_node(dev))
+ return dev_err_probe(dev, -EINVAL, "Missing of_node for device\n");
+
+ /* Need to be done before devm_pci_dev_create_intr_ctrl.
+ * It allocates an IRQ and so pdev->irq is updated.
+ */
+ ret = pcim_enable_device(pdev);
+ if (ret)
+ return ret;
+
+ ret = devm_pci_dev_create_intr_ctrl(pdev);
+ if (ret)
+ return ret;
+
+ data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ pci_set_drvdata(pdev, data);
+ data->dev = dev;
+
+ ret = lan966x_pci_load_overlay(data);
+ if (ret)
+ return ret;
+
+ pci_set_master(pdev);
+
+ ret = of_platform_default_populate(dev_of_node(dev), NULL, dev);
+ if (ret)
+ goto err_unload_overlay;
+
+ return 0;
+
+err_unload_overlay:
+ lan966x_pci_unload_overlay(data);
+ return ret;
+}
+
+static void lan966x_pci_remove(struct pci_dev *pdev)
+{
+ struct lan966x_pci *data = pci_get_drvdata(pdev);
+
+ of_platform_depopulate(data->dev);
+
+ lan966x_pci_unload_overlay(data);
+}
+
+static struct pci_device_id lan966x_pci_ids[] = {
+ { PCI_DEVICE(PCI_VENDOR_ID_EFAR, 0x9660) },
+ { }
+};
+MODULE_DEVICE_TABLE(pci, lan966x_pci_ids);
+
+static struct pci_driver lan966x_pci_driver = {
+ .name = "mchp_lan966x_pci",
+ .id_table = lan966x_pci_ids,
+ .probe = lan966x_pci_probe,
+ .remove = lan966x_pci_remove,
+};
+module_pci_driver(lan966x_pci_driver);
+
+MODULE_AUTHOR("Herve Codina <herve.codina@bootlin.com>");
+MODULE_DESCRIPTION("Microchip LAN966x PCI driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/misc/lan966x_pci.dtso b/drivers/misc/lan966x_pci.dtso
new file mode 100644
index 000000000000..94c271645ad5
--- /dev/null
+++ b/drivers/misc/lan966x_pci.dtso
@@ -0,0 +1,167 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2022 Microchip UNG
+ */
+
+#include <dt-bindings/clock/microchip,lan966x.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/mfd/atmel-flexcom.h>
+#include <dt-bindings/phy/phy-lan966x-serdes.h>
+
+/dts-v1/;
+/plugin/;
+
+/ {
+ fragment@0 {
+ target-path="";
+ __overlay__ {
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ pci-ep-bus@0 {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ /*
+ * map @0xe2000000 (32MB) to BAR0 (CPU)
+ * map @0xe0000000 (16MB) to BAR1 (AMBA)
+ */
+ ranges = <0xe2000000 0x00 0x00 0x00 0x2000000
+ 0xe0000000 0x01 0x00 0x00 0x1000000>;
+
+ oic: oic@e00c0120 {
+ compatible = "microchip,lan966x-oic";
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ interrupts = <0>; /* PCI INTx assigned interrupt */
+ reg = <0xe00c0120 0x190>;
+ };
+
+ cpu_clk: cpu_clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <600000000>; // CPU clock = 600MHz
+ };
+
+ ddr_clk: ddr_clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <30000000>; // Fabric clock = 30MHz
+ };
+
+ sys_clk: sys_clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <15625000>; // System clock = 15.625MHz
+ };
+
+ cpu_ctrl: syscon@e00c0000 {
+ compatible = "microchip,lan966x-cpu-syscon", "syscon";
+ reg = <0xe00c0000 0xa8>;
+ };
+
+ reset: reset@e200400c {
+ compatible = "microchip,lan966x-switch-reset";
+ reg = <0xe200400c 0x4>, <0xe00c0000 0xa8>;
+ reg-names = "gcb","cpu";
+ #reset-cells = <1>;
+ cpu-syscon = <&cpu_ctrl>;
+ };
+
+ gpio: pinctrl@e2004064 {
+ compatible = "microchip,lan966x-pinctrl";
+ reg = <0xe2004064 0xb4>,
+ <0xe2010024 0x138>;
+ resets = <&reset 0>;
+ reset-names = "switch";
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&gpio 0 0 78>;
+ interrupt-parent = <&oic>;
+ interrupt-controller;
+ interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
+ #interrupt-cells = <2>;
+
+ tod_pins: tod_pins {
+ pins = "GPIO_36";
+ function = "ptpsync_1";
+ };
+
+ fc0_a_pins: fcb4-i2c-pins {
+ /* RXD, TXD */
+ pins = "GPIO_9", "GPIO_10";
+ function = "fc0_a";
+ };
+
+ };
+
+ serdes: serdes@e202c000 {
+ compatible = "microchip,lan966x-serdes";
+ reg = <0xe202c000 0x9c>,
+ <0xe2004010 0x4>;
+ #phy-cells = <2>;
+ };
+
+ mdio1: mdio@e200413c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "microchip,lan966x-miim";
+ reg = <0xe200413c 0x24>,
+ <0xe2010020 0x4>;
+
+ resets = <&reset 0>;
+ reset-names = "switch";
+
+ lan966x_phy0: ethernet-lan966x_phy@1 {
+ reg = <1>;
+ };
+
+ lan966x_phy1: ethernet-lan966x_phy@2 {
+ reg = <2>;
+ };
+ };
+
+ switch: switch@e0000000 {
+ compatible = "microchip,lan966x-switch";
+ reg = <0xe0000000 0x0100000>,
+ <0xe2000000 0x0800000>;
+ reg-names = "cpu", "gcb";
+
+ interrupt-parent = <&oic>;
+ interrupts = <12 IRQ_TYPE_LEVEL_HIGH>,
+ <9 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "xtr", "ana";
+
+ resets = <&reset 0>;
+ reset-names = "switch";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&tod_pins>;
+
+ ethernet-ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port0: port@0 {
+ phy-handle = <&lan966x_phy0>;
+
+ reg = <0>;
+ phy-mode = "gmii";
+ phys = <&serdes 0 CU(0)>;
+ };
+
+ port1: port@1 {
+ phy-handle = <&lan966x_phy1>;
+
+ reg = <1>;
+ phy-mode = "gmii";
+ phys = <&serdes 1 CU(1)>;
+ };
+ };
+ };
+ };
+ };
+ };
+};
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index dccb60c1d9cc..41dec625ed7b 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -6266,6 +6266,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5020, of_pci_make_dev_node);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_XILINX, 0x5021, of_pci_make_dev_node);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REDHAT, 0x0005, of_pci_make_dev_node);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_EFAR, 0x9660, of_pci_make_dev_node);
/*
* Devices known to require a longer delay before first config space access
--
2.46.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v7 1/6] misc: Add support for LAN966x PCI device
2024-10-03 8:16 ` [PATCH v7 1/6] misc: Add support for LAN966x PCI device Herve Codina
@ 2024-10-03 9:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2024-10-03 9:13 UTC (permalink / raw)
To: Herve Codina
Cc: Andy Shevchenko, Simon Horman, Lee Jones, Arnd Bergmann,
Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman, Bjorn Helgaas,
Philipp Zabel, Lars Povlsen, Steen Hegelund, Daniel Machon,
UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Saravana Kannan, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Horatiu Vultur, Andrew Lunn, devicetree,
linux-kernel, netdev, linux-pci, linux-arm-kernel, Allan Nielsen,
Luca Ceresoli, Thomas Petazzoni
Hi Hervé,
On Thu, Oct 3, 2024 at 10:17 AM Herve Codina <herve.codina@bootlin.com> wrote:
> Add a PCI driver that handles the LAN966x PCI device using a device-tree
> overlay. This overlay is applied to the PCI device DT node and allows to
> describe components that are present in the device.
>
> The memory from the device-tree is remapped to the BAR memory thanks to
> "ranges" properties computed at runtime by the PCI core during the PCI
> enumeration.
>
> The PCI device itself acts as an interrupt controller and is used as the
> parent of the internal LAN966x interrupt controller to route the
> interrupts to the assigned PCI INTx interrupt.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for your patch!
> --- /dev/null
> +++ b/drivers/misc/lan966x_pci.dtso
> @@ -0,0 +1,167 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2022 Microchip UNG
> + */
> +
> +#include <dt-bindings/clock/microchip,lan966x.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/mfd/atmel-flexcom.h>
> +#include <dt-bindings/phy/phy-lan966x-serdes.h>
> +
> +/dts-v1/;
> +/plugin/;
> +
> +/ {
> + fragment@0 {
> + target-path="";
Nit: missing spaces around "=".
> + __overlay__ {
Unfortunately we cannot use sugar syntax, as sugar syntax does not
support empty target paths yet.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v7 2/6] MAINTAINERS: Add the Microchip LAN966x PCI driver entry
2024-10-03 8:16 [PATCH v7 0/6] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-10-03 8:16 ` [PATCH v7 1/6] misc: Add support for LAN966x PCI device Herve Codina
@ 2024-10-03 8:16 ` Herve Codina
2024-10-03 8:16 ` [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x Herve Codina
` (3 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Herve Codina @ 2024-10-03 8:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Herve Codina, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Steen Hegelund,
Luca Ceresoli, Thomas Petazzoni
After contributing the driver, add myself as the maintainer for the
Microchip LAN966x PCI driver.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c27f3190737f..79125b6f7814 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15184,6 +15184,12 @@ S: Maintained
F: Documentation/devicetree/bindings/interrupt-controller/microchip,lan966x-oic.yaml
F: drivers/irqchip/irq-lan966x-oic.c
+MICROCHIP LAN966X PCI DRIVER
+M: Herve Codina <herve.codina@bootlin.com>
+S: Maintained
+F: drivers/misc/lan966x_pci.c
+F: drivers/misc/lan966x_pci.dtso
+
MICROCHIP LCDFB DRIVER
M: Nicolas Ferre <nicolas.ferre@microchip.com>
L: linux-fbdev@vger.kernel.org
--
2.46.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x
2024-10-03 8:16 [PATCH v7 0/6] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-10-03 8:16 ` [PATCH v7 1/6] misc: Add support for LAN966x PCI device Herve Codina
2024-10-03 8:16 ` [PATCH v7 2/6] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
@ 2024-10-03 8:16 ` Herve Codina
2024-10-09 7:29 ` Steen Hegelund
2024-10-09 10:15 ` Philipp Zabel
2024-10-03 8:16 ` [PATCH v7 4/6] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency Herve Codina
` (2 subsequent siblings)
5 siblings, 2 replies; 15+ messages in thread
From: Herve Codina @ 2024-10-03 8:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Herve Codina, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Steen Hegelund,
Luca Ceresoli, Thomas Petazzoni
In the LAN966x PCI device use case, the syscon API cannot be used as
it does not support device removal [1]. A syscon device is a core
"system" device and not a device available in some addon boards and so,
it is not supposed to be removed. The syscon API follows this assumption
but this assumption is no longer valid in the LAN966x use case.
In order to avoid the use of the syscon API and so, support for removal,
use a local mapping of the syscon device.
Link: https://lore.kernel.org/all/20240923100741.11277439@bootlin.com/ [1]
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
drivers/reset/reset-microchip-sparx5.c | 35 +++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
index 636e85c388b0..48a62d5da78d 100644
--- a/drivers/reset/reset-microchip-sparx5.c
+++ b/drivers/reset/reset-microchip-sparx5.c
@@ -62,6 +62,28 @@ static const struct reset_control_ops sparx5_reset_ops = {
.reset = sparx5_reset_noop,
};
+static const struct regmap_config mchp_lan966x_syscon_regmap_config = {
+ .reg_bits = 32,
+ .val_bits = 32,
+ .reg_stride = 4,
+};
+
+static struct regmap *mchp_lan966x_syscon_to_regmap(struct device *dev,
+ struct device_node *syscon_np)
+{
+ struct regmap_config regmap_config = mchp_lan966x_syscon_regmap_config;
+ resource_size_t size;
+ void __iomem *base;
+
+ base = devm_of_iomap(dev, syscon_np, 0, &size);
+ if (IS_ERR(base))
+ return ERR_CAST(base);
+
+ regmap_config.max_register = size - 4;
+
+ return devm_regmap_init_mmio(dev, base, ®map_config);
+}
+
static int mchp_sparx5_map_syscon(struct platform_device *pdev, char *name,
struct regmap **target)
{
@@ -72,7 +94,18 @@ static int mchp_sparx5_map_syscon(struct platform_device *pdev, char *name,
syscon_np = of_parse_phandle(pdev->dev.of_node, name, 0);
if (!syscon_np)
return -ENODEV;
- regmap = syscon_node_to_regmap(syscon_np);
+
+ /*
+ * The syscon API doesn't support syscon device removal.
+ * When used in LAN966x PCI device, the cpu-syscon device needs to be
+ * removed when the PCI device is removed.
+ * In case of LAN966x, map the syscon device locally to support the
+ * device removal.
+ */
+ if (of_device_is_compatible(pdev->dev.of_node, "microchip,lan966x-switch-reset"))
+ regmap = mchp_lan966x_syscon_to_regmap(&pdev->dev, syscon_np);
+ else
+ regmap = syscon_node_to_regmap(syscon_np);
of_node_put(syscon_np);
if (IS_ERR(regmap)) {
err = PTR_ERR(regmap);
--
2.46.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x
2024-10-03 8:16 ` [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x Herve Codina
@ 2024-10-09 7:29 ` Steen Hegelund
2024-10-09 10:20 ` Geert Uytterhoeven
2024-10-09 10:15 ` Philipp Zabel
1 sibling, 1 reply; 15+ messages in thread
From: Steen Hegelund @ 2024-10-09 7:29 UTC (permalink / raw)
To: Herve Codina, Geert Uytterhoeven, Andy Shevchenko, Simon Horman,
Lee Jones, Arnd Bergmann, Derek Kiernan, Dragan Cvetic,
Greg Kroah-Hartman, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Daniel Machon, UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Luca Ceresoli,
Thomas Petazzoni
Hi Herve,
On Thu, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> In the LAN966x PCI device use case, the syscon API cannot be used as
> it does not support device removal [1]. A syscon device is a core
> "system" device and not a device available in some addon boards and
> so,
> it is not supposed to be removed. The syscon API follows this
> assumption
> but this assumption is no longer valid in the LAN966x use case.
>
> In order to avoid the use of the syscon API and so, support for
> removal,
> use a local mapping of the syscon device.
>
> Link:
> https://lore.kernel.org/all/20240923100741.11277439@bootlin.com/ [1]
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> drivers/reset/reset-microchip-sparx5.c | 35
> +++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-microchip-sparx5.c
> b/drivers/reset/reset-microchip-sparx5.c
> index 636e85c388b0..48a62d5da78d 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -62,6 +62,28 @@ static const struct reset_control_ops
> sparx5_reset_ops = {
> .reset = sparx5_reset_noop,
> };
>
> +static const struct regmap_config mchp_lan966x_syscon_regmap_config
> = {
> + .reg_bits = 32,
> + .val_bits = 32,
> + .reg_stride = 4,
> +};
> +
> +static struct regmap *mchp_lan966x_syscon_to_regmap(struct device
> *dev,
> + struct
> device_node *syscon_np)
> +{
> + struct regmap_config regmap_config =
> mchp_lan966x_syscon_regmap_config;
> + resource_size_t size;
> + void __iomem *base;
> +
> + base = devm_of_iomap(dev, syscon_np, 0, &size);
> + if (IS_ERR(base))
> + return ERR_CAST(base);
> +
> + regmap_config.max_register = size - 4;
> +
> + return devm_regmap_init_mmio(dev, base, ®map_config);
> +}
> +
> static int mchp_sparx5_map_syscon(struct platform_device *pdev, char
> *name,
> struct regmap **target)
> {
> @@ -72,7 +94,18 @@ static int mchp_sparx5_map_syscon(struct
> platform_device *pdev, char *name,
> syscon_np = of_parse_phandle(pdev->dev.of_node, name, 0);
> if (!syscon_np)
> return -ENODEV;
> - regmap = syscon_node_to_regmap(syscon_np);
> +
> + /*
> + * The syscon API doesn't support syscon device removal.
> + * When used in LAN966x PCI device, the cpu-syscon device
> needs to be
> + * removed when the PCI device is removed.
> + * In case of LAN966x, map the syscon device locally to
> support the
> + * device removal.
> + */
> + if (of_device_is_compatible(pdev->dev.of_node,
> "microchip,lan966x-switch-reset"))
> + regmap = mchp_lan966x_syscon_to_regmap(&pdev->dev,
> syscon_np);
> + else
> + regmap = syscon_node_to_regmap(syscon_np);
> of_node_put(syscon_np);
> if (IS_ERR(regmap)) {
> err = PTR_ERR(regmap);
> --
> 2.46.1
>
This looks good to me.
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
BR
Steen
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x
2024-10-09 7:29 ` Steen Hegelund
@ 2024-10-09 10:20 ` Geert Uytterhoeven
2024-10-09 10:58 ` Conor Dooley
0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2024-10-09 10:20 UTC (permalink / raw)
To: Steen Hegelund
Cc: Herve Codina, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Bjorn Helgaas, Philipp Zabel, Lars Povlsen, Daniel Machon,
UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Saravana Kannan, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Horatiu Vultur, Andrew Lunn, devicetree,
linux-kernel, netdev, linux-pci, linux-arm-kernel, Allan Nielsen,
Luca Ceresoli, Thomas Petazzoni
Hi Steve,
On Wed, Oct 9, 2024 at 9:30 AM Steen Hegelund
<steen.hegelund@microchip.com> wrote:
> On Thu, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
Hmm, the email I received directly from Hervé did not have the part
you are quoting, so it looks like you are subject to a MiTM-attack ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x
2024-10-09 10:20 ` Geert Uytterhoeven
@ 2024-10-09 10:58 ` Conor Dooley
0 siblings, 0 replies; 15+ messages in thread
From: Conor Dooley @ 2024-10-09 10:58 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Steen Hegelund, Herve Codina, Andy Shevchenko, Simon Horman,
Lee Jones, Arnd Bergmann, Derek Kiernan, Dragan Cvetic,
Greg Kroah-Hartman, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Daniel Machon, UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Saravana Kannan, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Horatiu Vultur, Andrew Lunn,
devicetree, linux-kernel, netdev, linux-pci, linux-arm-kernel,
Allan Nielsen, Luca Ceresoli, Thomas Petazzoni
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Wed, Oct 09, 2024 at 12:20:32PM +0200, Geert Uytterhoeven wrote:
> Hi Steve,
>
> On Wed, Oct 9, 2024 at 9:30 AM Steen Hegelund
> <steen.hegelund@microchip.com> wrote:
> > On Thu, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > know the content is safe
>
> Hmm, the email I received directly from Hervé did not have the part
> you are quoting, so it looks like you are subject to a MiTM-attack ;-)
Yeah, unfortunately we are subjected to that. This one at least just
adds some text, there's another "MiTM attacker" we have that sometimes
crops up and has a side effect of tab-to-space conversion. The joys of
corporate IT.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x
2024-10-03 8:16 ` [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x Herve Codina
2024-10-09 7:29 ` Steen Hegelund
@ 2024-10-09 10:15 ` Philipp Zabel
1 sibling, 0 replies; 15+ messages in thread
From: Philipp Zabel @ 2024-10-09 10:15 UTC (permalink / raw)
To: Herve Codina, Geert Uytterhoeven, Andy Shevchenko, Simon Horman,
Lee Jones, Arnd Bergmann, Derek Kiernan, Dragan Cvetic,
Greg Kroah-Hartman, Bjorn Helgaas, Lars Povlsen, Steen Hegelund,
Daniel Machon, UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Luca Ceresoli,
Thomas Petazzoni
On Do, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> In the LAN966x PCI device use case, the syscon API cannot be used as
> it does not support device removal [1]. A syscon device is a core
> "system" device and not a device available in some addon boards and so,
> it is not supposed to be removed. The syscon API follows this assumption
> but this assumption is no longer valid in the LAN966x use case.
>
> In order to avoid the use of the syscon API and so, support for removal,
> use a local mapping of the syscon device.
>
> Link: https://lore.kernel.org/all/20240923100741.11277439@bootlin.com/ [1]
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v7 4/6] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency
2024-10-03 8:16 [PATCH v7 0/6] Add support for the LAN966x PCI device using a DT overlay Herve Codina
` (2 preceding siblings ...)
2024-10-03 8:16 ` [PATCH v7 3/6] reset: mchp: sparx5: Map cpu-syscon locally in case of LAN966x Herve Codina
@ 2024-10-03 8:16 ` Herve Codina
2024-10-09 10:15 ` Philipp Zabel
2024-10-03 8:16 ` [PATCH v7 5/6] reset: mchp: sparx5: Allow building as a module Herve Codina
2024-10-03 8:16 ` [PATCH v7 6/6] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
5 siblings, 1 reply; 15+ messages in thread
From: Herve Codina @ 2024-10-03 8:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Herve Codina, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Steen Hegelund,
Luca Ceresoli, Thomas Petazzoni
The sparx5 reset controller depends on the SPARX5 architecture or the
LAN966x SoC.
This reset controller can be used by the LAN966x PCI device and so it
needs to be available when the LAN966x PCI device is enabled.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
---
drivers/reset/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 5484a65f66b9..86a5504950cb 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -147,7 +147,7 @@ config RESET_LPC18XX
config RESET_MCHP_SPARX5
bool "Microchip Sparx5 reset driver"
- depends on ARCH_SPARX5 || SOC_LAN966 || COMPILE_TEST
+ depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
default y if SPARX5_SWITCH
select MFD_SYSCON
help
--
2.46.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v7 4/6] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency
2024-10-03 8:16 ` [PATCH v7 4/6] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency Herve Codina
@ 2024-10-09 10:15 ` Philipp Zabel
0 siblings, 0 replies; 15+ messages in thread
From: Philipp Zabel @ 2024-10-09 10:15 UTC (permalink / raw)
To: Herve Codina, Geert Uytterhoeven, Andy Shevchenko, Simon Horman,
Lee Jones, Arnd Bergmann, Derek Kiernan, Dragan Cvetic,
Greg Kroah-Hartman, Bjorn Helgaas, Lars Povlsen, Steen Hegelund,
Daniel Machon, UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Luca Ceresoli,
Thomas Petazzoni
On Do, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> The sparx5 reset controller depends on the SPARX5 architecture or the
> LAN966x SoC.
>
> This reset controller can be used by the LAN966x PCI device and so it
> needs to be available when the LAN966x PCI device is enabled.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v7 5/6] reset: mchp: sparx5: Allow building as a module
2024-10-03 8:16 [PATCH v7 0/6] Add support for the LAN966x PCI device using a DT overlay Herve Codina
` (3 preceding siblings ...)
2024-10-03 8:16 ` [PATCH v7 4/6] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency Herve Codina
@ 2024-10-03 8:16 ` Herve Codina
2024-10-09 10:15 ` Philipp Zabel
2024-10-03 8:16 ` [PATCH v7 6/6] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
5 siblings, 1 reply; 15+ messages in thread
From: Herve Codina @ 2024-10-03 8:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Herve Codina, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Steen Hegelund,
Luca Ceresoli, Thomas Petazzoni, Clément Léger
From: Clément Léger <clement.leger@bootlin.com>
This reset controller can be used by the LAN966x PCI device.
The LAN966x PCI device driver can be built as a module and this reset
controller driver has no reason to be a builtin driver in that case.
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
---
drivers/reset/Kconfig | 2 +-
drivers/reset/reset-microchip-sparx5.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 86a5504950cb..93cddbe8609b 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -146,7 +146,7 @@ config RESET_LPC18XX
This enables the reset controller driver for NXP LPC18xx/43xx SoCs.
config RESET_MCHP_SPARX5
- bool "Microchip Sparx5 reset driver"
+ tristate "Microchip Sparx5 reset driver"
depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
default y if SPARX5_SWITCH
select MFD_SYSCON
diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
index 48a62d5da78d..c4cc0edbb250 100644
--- a/drivers/reset/reset-microchip-sparx5.c
+++ b/drivers/reset/reset-microchip-sparx5.c
@@ -191,6 +191,7 @@ static const struct of_device_id mchp_sparx5_reset_of_match[] = {
},
{ }
};
+MODULE_DEVICE_TABLE(of, mchp_sparx5_reset_of_match);
static struct platform_driver mchp_sparx5_reset_driver = {
.probe = mchp_sparx5_reset_probe,
@@ -213,3 +214,4 @@ postcore_initcall(mchp_sparx5_reset_init);
MODULE_DESCRIPTION("Microchip Sparx5 switch reset driver");
MODULE_AUTHOR("Steen Hegelund <steen.hegelund@microchip.com>");
+MODULE_LICENSE("GPL");
--
2.46.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v7 5/6] reset: mchp: sparx5: Allow building as a module
2024-10-03 8:16 ` [PATCH v7 5/6] reset: mchp: sparx5: Allow building as a module Herve Codina
@ 2024-10-09 10:15 ` Philipp Zabel
0 siblings, 0 replies; 15+ messages in thread
From: Philipp Zabel @ 2024-10-09 10:15 UTC (permalink / raw)
To: Herve Codina, Geert Uytterhoeven, Andy Shevchenko, Simon Horman,
Lee Jones, Arnd Bergmann, Derek Kiernan, Dragan Cvetic,
Greg Kroah-Hartman, Bjorn Helgaas, Lars Povlsen, Steen Hegelund,
Daniel Machon, UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Luca Ceresoli,
Thomas Petazzoni, Clément Léger
On Do, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> From: Clément Léger <clement.leger@bootlin.com>
>
> This reset controller can be used by the LAN966x PCI device.
>
> The LAN966x PCI device driver can be built as a module and this reset
> controller driver has no reason to be a builtin driver in that case.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v7 6/6] reset: mchp: sparx5: set the dev member of the reset controller
2024-10-03 8:16 [PATCH v7 0/6] Add support for the LAN966x PCI device using a DT overlay Herve Codina
` (4 preceding siblings ...)
2024-10-03 8:16 ` [PATCH v7 5/6] reset: mchp: sparx5: Allow building as a module Herve Codina
@ 2024-10-03 8:16 ` Herve Codina
2024-10-09 10:16 ` Philipp Zabel
5 siblings, 1 reply; 15+ messages in thread
From: Herve Codina @ 2024-10-03 8:16 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Shevchenko, Simon Horman, Lee Jones,
Arnd Bergmann, Derek Kiernan, Dragan Cvetic, Greg Kroah-Hartman,
Herve Codina, Bjorn Helgaas, Philipp Zabel, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Steen Hegelund,
Luca Ceresoli, Thomas Petazzoni, Clément Léger
From: Clément Léger <clement.leger@bootlin.com>
In order to guarantee the device will not be deleted by the reset
controller consumer, set the dev member of the reset controller.
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
---
drivers/reset/reset-microchip-sparx5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
index c4cc0edbb250..aa5464be7053 100644
--- a/drivers/reset/reset-microchip-sparx5.c
+++ b/drivers/reset/reset-microchip-sparx5.c
@@ -154,6 +154,7 @@ static int mchp_sparx5_reset_probe(struct platform_device *pdev)
return err;
ctx->rcdev.owner = THIS_MODULE;
+ ctx->rcdev.dev = &pdev->dev;
ctx->rcdev.nr_resets = 1;
ctx->rcdev.ops = &sparx5_reset_ops;
ctx->rcdev.of_node = dn;
--
2.46.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH v7 6/6] reset: mchp: sparx5: set the dev member of the reset controller
2024-10-03 8:16 ` [PATCH v7 6/6] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
@ 2024-10-09 10:16 ` Philipp Zabel
0 siblings, 0 replies; 15+ messages in thread
From: Philipp Zabel @ 2024-10-09 10:16 UTC (permalink / raw)
To: Herve Codina, Geert Uytterhoeven, Andy Shevchenko, Simon Horman,
Lee Jones, Arnd Bergmann, Derek Kiernan, Dragan Cvetic,
Greg Kroah-Hartman, Bjorn Helgaas, Lars Povlsen, Steen Hegelund,
Daniel Machon, UNGLinuxDriver, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Saravana Kannan
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Horatiu Vultur, Andrew Lunn, devicetree, linux-kernel, netdev,
linux-pci, linux-arm-kernel, Allan Nielsen, Luca Ceresoli,
Thomas Petazzoni, Clément Léger
On Do, 2024-10-03 at 10:16 +0200, Herve Codina wrote:
> From: Clément Léger <clement.leger@bootlin.com>
>
> In order to guarantee the device will not be deleted by the reset
> controller consumer, set the dev member of the reset controller.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 15+ messages in thread