[PATCH 0/2] Add support for Zyxel EX3510-B

[PATCH 0/2] Add support for Zyxel EX3510-B

[Sam Edwards]

Hello BCMBCA maintainers,

This pair of patches adds an initial DT for the Zyxel EX3510-B "series" based
on BCM4906, encompassing the EX3510-B0 and EX3510-B1. As I am not aware of any
software-affecting difference between these two, I am calling the "series" one
model.

I found the BCM4906/8 support in Linux to be in need of a lot of TLC, and have
just sent a few patches necessary to get Linux to boot without crashing on this
platform. At a minimum, you will want to apply [1] to resolve a panic related
to xHCI not initializing. If you are booting through CFE and want to use the
secondary CPU, you will have to apply [2] as well.

There are more patches to come. An issue with the switch driver is preventing
the WAN port from operating, for example. I have worked around this locally so
I can confirm that the DT I am submitting here is correct, but I will need to
clean up my remaining local fixes before they can be sent.

As always, thank you very much for your continued efforts and for your time
reviewing these patches.

Best regards,
Sam

[1]: https://lore.kernel.org/lkml/20241003211720.1339468-1-CFSworks@gmail.com/T/
[2]: https://lore.kernel.org/lkml/20241003213007.1339811-1-CFSworks@gmail.com/T/

Sam Edwards (2):
  dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
  arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B

 .../bindings/arm/bcm/brcm,bcmbca.yaml         |   1 +
 arch/arm64/boot/dts/broadcom/bcmbca/Makefile  |   1 +
 .../broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts | 197 ++++++++++++++++++
 3 files changed, 199 insertions(+)
 create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts

-- 
2.44.2

[PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

[Sam Edwards]

This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
marketing materials call this a "series," the EX3510-B1 appears to be a
very minor revision of the EX3510-B0, with only changes that are
transparent to software. As far as Linux is concerned, this "series"
effectively represents a single model.

Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
index 07892cbdd23c..4999568225f1 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
@@ -34,6 +34,7 @@ properties:
           - enum:
               - netgear,r8000p
               - tplink,archer-c2300-v1
+              - zyxel,ex3510b
           - const: brcm,bcm4906
           - const: brcm,bcm4908
           - const: brcm,bcmbca
-- 
2.44.2

[PATCH 2/2] arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B

[Sam Edwards]

Zyxel EX3510-B is a WiFi 6 capable home gateway (family) based on the
BCM4906 SoC, with 512MiB of RAM and 512MiB of NAND flash. WiFi support
consists of a BCM6710 and a BCM6715 attached to separate PCIe buses.

Add an initial devicetree for this system, with support for:
- Onboard UART (per base dtsi)
- USB (2.0 only; superspeed devices are treated as high-speed due to an
    unknown cause)
- Both buttons (rear reset, front WPS)
- Almost all LEDs:
  - Power (red/green)
  - Internet (red/green)
  - WAN (green)
  - LAN (green; anode is connected to GPIO 13 so currently
      nonfunctioning)
  - USB (green)
  - WPS button (red/green)
  - Absent in DT: There are 2.4GHz/5.0GHz WiFi status LEDs connected to
      the WiFi chips instead of the SoC.
- NAND flash
- Embedded Ethernet switch
- Factory-programmed Ethernet MAC address

WiFi cannot be enabled at this time due to Linux lacking drivers for
both the PCIe controllers and the PCIe WiFi peripherals.

Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
 arch/arm64/boot/dts/broadcom/bcmbca/Makefile  |   1 +
 .../broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts | 197 ++++++++++++++++++
 2 files changed, 198 insertions(+)
 create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts

diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
index 27741b71ba9e..9a8461d91c8c 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_BCMBCA) += \
 				bcm4906-netgear-r8000p.dtb \
 				bcm4906-tplink-archer-c2300-v1.dtb \
+				bcm4906-zyxel-ex3510b.dtb \
 				bcm4908-asus-gt-ac5300.dtb \
 				bcm4908-netgear-raxe500.dtb \
 				bcm94908.dtb \
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
new file mode 100644
index 000000000000..b70d8ffe4922
--- /dev/null
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
@@ -0,0 +1,197 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+#include "bcm4906.dtsi"
+
+/ {
+	compatible = "zyxel,ex3510b", "brcm,bcm4906", "brcm,bcm4908", "brcm,bcmbca";
+	model = "Zyxel EX3510-B";
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0 0 0 0x20000000>;
+	};
+
+	gpio-keys-polled {
+		compatible = "gpio-keys-polled";
+		poll-interval = <100>;
+
+		key-wps {
+			label = "WPS";
+			linux,code = <KEY_WPS_BUTTON>;
+			gpios = <&gpio0 22 GPIO_ACTIVE_LOW>;
+		};
+
+		key-reset {
+			label = "Reset";
+			linux,code = <KEY_RESTART>;
+			gpios = <&gpio0 23 GPIO_ACTIVE_LOW>;
+		};
+	};
+};
+
+&leds {
+	pinctrl-0 = <&pins_led_0_a>, <&pins_led_2_a>, <&pins_led_3_a>,
+		    <&pins_led_4_a>, <&pins_led_10_a>, <&pins_led_12_a>,
+		    <&pins_led_14_a>, <&pins_led_15_a>, <&pins_led_21_a>;
+	pinctrl-names = "default";
+
+	led@0 {
+		reg = <0x0>;
+		function = LED_FUNCTION_POWER;
+		color = <LED_COLOR_ID_RED>;
+	};
+
+	led@2 {
+		reg = <0x2>;
+		function = LED_FUNCTION_WAN_ONLINE;
+		color = <LED_COLOR_ID_GREEN>;
+	};
+
+	led@3 {
+		reg = <0x3>;
+		function = LED_FUNCTION_WAN_ONLINE;
+		color = <LED_COLOR_ID_RED>;
+	};
+
+	led@4 {
+		reg = <0x4>;
+		function = LED_FUNCTION_USB;
+		color = <LED_COLOR_ID_GREEN>;
+		trigger-sources = <&ohci_port1>, <&ohci_port2>,
+				  <&ehci_port1>, <&ehci_port2>,
+				  <&xhci_port1>, <&xhci_port2>;
+		linux,default-trigger = "usbport";
+	};
+
+	led@a {
+		reg = <0xa>;
+		function = LED_FUNCTION_POWER;
+		color = <LED_COLOR_ID_GREEN>;
+		linux,default-trigger = "default-on";
+	};
+
+	led@c {
+		reg = <0xc>;
+		function = LED_FUNCTION_LAN;
+		color = <LED_COLOR_ID_GREEN>;
+		active-low;
+	};
+
+	led@e {
+		reg = <0xe>;
+		function = LED_FUNCTION_WPS;
+		color = <LED_COLOR_ID_GREEN>;
+		active-low;
+	};
+
+	led@f {
+		reg = <0xf>;
+		function = LED_FUNCTION_WPS;
+		color = <LED_COLOR_ID_RED>;
+		active-low;
+	};
+
+	led@15 {
+		reg = <0x15>;
+		function = LED_FUNCTION_WAN;
+		color = <LED_COLOR_ID_GREEN>;
+		active-low;
+	};
+};
+
+&enet {
+	nvmem-cells = <&base_mac_addr>;
+	nvmem-cell-names = "mac-address";
+};
+
+&usb_phy {
+	brcm,ioc = <1>;
+	brcm,ipp = <1>;
+	status = "okay";
+};
+
+&ehci {
+	status = "okay";
+};
+
+&ohci {
+	status = "okay";
+};
+
+&xhci {
+	status = "okay";
+};
+
+&ports {
+	port@0 {
+		label = "lan1";
+	};
+
+	port@1 {
+		label = "lan2";
+	};
+
+	port@2 {
+		label = "lan3";
+	};
+
+	port@3 {
+		label = "lan4";
+	};
+
+	port@7 {
+		reg = <7>;
+		phy-mode = "internal";
+		phy-handle = <&phy12>;
+		label = "wan";
+	};
+};
+
+&nand_controller {
+	status = "okay";
+};
+
+&nandcs {
+	brcm,nand-oob-sector-size = <27>;
+	nand-ecc-strength = <8>;
+	nand-ecc-step-size = <512>;
+	nand-on-flash-bbt;
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	partitions {
+		compatible = "brcm,bcm4908-partitions";
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		partition@0 {
+			compatible = "nvmem-cells";
+			label = "cferom";
+			reg = <0x0 0x100000>;
+			read-only;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 0x0 0x100000>;
+
+			base_mac_addr: mac@106a0 {
+				reg = <0x106a0 0x6>;
+			};
+		};
+
+		partition@100000 {
+			compatible = "brcm,bcm4908-firmware";
+			reg = <0x100000 0x5f80000>;
+		};
+
+		partition@6080000 {
+			compatible = "brcm,bcm4908-firmware";
+			reg = <0x6080000 0x5f80000>;
+		};
+	};
+};
-- 
2.44.2

Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

[Krzysztof Kozlowski]

On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
> marketing materials call this a "series," the EX3510-B1 appears to be a
> very minor revision of the EX3510-B0, with only changes that are
> transparent to software. As far as Linux is concerned, this "series"
> effectively represents a single model.
> 
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>

Can you use the same email as for SoB?

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

[Krzysztof Kozlowski]

On 04/10/2024 08:49, Krzysztof Kozlowski wrote:
> On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
>> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
>> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
>> marketing materials call this a "series," the EX3510-B1 appears to be a
>> very minor revision of the EX3510-B0, with only changes that are
>> transparent to software. As far as Linux is concerned, this "series"
>> effectively represents a single model.
>>
>> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> 
> Can you use the same email as for SoB?

I meant, same for patch author and SoB. How is even possible to generate
different data? You had to change it manually, which should make you
wondering if this is correct.

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B

[Florian Fainelli]

On 10/3/24 15:08, Sam Edwards wrote:
> Zyxel EX3510-B is a WiFi 6 capable home gateway (family) based on the
> BCM4906 SoC, with 512MiB of RAM and 512MiB of NAND flash. WiFi support
> consists of a BCM6710 and a BCM6715 attached to separate PCIe buses.
> 
> Add an initial devicetree for this system, with support for:
> - Onboard UART (per base dtsi)
> - USB (2.0 only; superspeed devices are treated as high-speed due to an
>      unknown cause)
> - Both buttons (rear reset, front WPS)
> - Almost all LEDs:
>    - Power (red/green)
>    - Internet (red/green)
>    - WAN (green)
>    - LAN (green; anode is connected to GPIO 13 so currently
>        nonfunctioning)
>    - USB (green)
>    - WPS button (red/green)
>    - Absent in DT: There are 2.4GHz/5.0GHz WiFi status LEDs connected to
>        the WiFi chips instead of the SoC.
> - NAND flash
> - Embedded Ethernet switch
> - Factory-programmed Ethernet MAC address
> 
> WiFi cannot be enabled at this time due to Linux lacking drivers for
> both the PCIe controllers and the PCIe WiFi peripherals.

On the topic of PCIe, AFAICT Rafal had made an attempt at modifying 
pcie-brcmstb.c, which is really the same IP, or rather a fork of it. Let 
me know if you need help in figuring out the programming and we can help 
with that.
-- 
Florian

Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

[Sam Edwards]

On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 04/10/2024 08:49, Krzysztof Kozlowski wrote:
> > On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
> >> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
> >> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
> >> marketing materials call this a "series," the EX3510-B1 appears to be a
> >> very minor revision of the EX3510-B0, with only changes that are
> >> transparent to software. As far as Linux is concerned, this "series"
> >> effectively represents a single model.
> >>
> >> Signed-off-by: Sam Edwards <CFSworks@gmail.com>

Good day Krzysztof,

> >
> > Can you use the same email as for SoB?

I have sent patches to the LKML from a work email before, but I just
double-checked that I am using my personal email for everything here:

$ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed'
Author: Sam Edwards <CFSworks@gmail.com>
    dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
    Signed-off-by: Sam Edwards <CFSworks@gmail.com>
$ grep -E '^From|^Signed'
outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch
From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001
From: Sam Edwards <CFSworks@gmail.com>
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
$

> I meant, same for patch author and SoB. How is even possible to generate
> different data? You had to change it manually, which should make you
> wondering if this is correct.

Hey, on a meta level: I’d appreciate it if we could try to rule out
other possibilities before jumping to conclusions. Reading this made
me feel accused, and I think framing things collaboratively rather
than assigning blame will make it easier for all of us. How about we
start with what you’re seeing and work backwards?

Wishing you well,
Sam

>
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Best regards,
> > Krzysztof
> >
>
> Best regards,
> Krzysztof
>

Re: [PATCH 0/2] Add support for Zyxel EX3510-B

[Rob Herring (Arm)]

On Thu, 03 Oct 2024 15:08:18 -0700, Sam Edwards wrote:
> Hello BCMBCA maintainers,
> 
> This pair of patches adds an initial DT for the Zyxel EX3510-B "series" based
> on BCM4906, encompassing the EX3510-B0 and EX3510-B1. As I am not aware of any
> software-affecting difference between these two, I am calling the "series" one
> model.
> 
> I found the BCM4906/8 support in Linux to be in need of a lot of TLC, and have
> just sent a few patches necessary to get Linux to boot without crashing on this
> platform. At a minimum, you will want to apply [1] to resolve a panic related
> to xHCI not initializing. If you are booting through CFE and want to use the
> secondary CPU, you will have to apply [2] as well.
> 
> There are more patches to come. An issue with the switch driver is preventing
> the WAN port from operating, for example. I have worked around this locally so
> I can confirm that the DT I am submitting here is correct, but I will need to
> clean up my remaining local fixes before they can be sent.
> 
> As always, thank you very much for your continued efforts and for your time
> reviewing these patches.
> 
> Best regards,
> Sam
> 
> [1]: https://lore.kernel.org/lkml/20241003211720.1339468-1-CFSworks@gmail.com/T/
> [2]: https://lore.kernel.org/lkml/20241003213007.1339811-1-CFSworks@gmail.com/T/
> 
> Sam Edwards (2):
>   dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
>   arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B
> 
>  .../bindings/arm/bcm/brcm,bcmbca.yaml         |   1 +
>  arch/arm64/boot/dts/broadcom/bcmbca/Makefile  |   1 +
>  .../broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts | 197 ++++++++++++++++++
>  3 files changed, 199 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
> 
> --
> 2.44.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb' for 20241003220820.1345048-1-CFSworks@gmail.com:

arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0', 'ranges' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'nand-ecc-strength', 'partitions' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0', 'ranges' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0', 'ranges' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand@0: partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0', 'ranges' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: partition@0: Unevaluated properties are not allowed ('ranges' was unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#

Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

[Krzysztof Kozlowski]

On 04/10/2024 19:21, Sam Edwards wrote:
> On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 04/10/2024 08:49, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
>>>> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
>>>> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
>>>> marketing materials call this a "series," the EX3510-B1 appears to be a
>>>> very minor revision of the EX3510-B0, with only changes that are
>>>> transparent to software. As far as Linux is concerned, this "series"
>>>> effectively represents a single model.
>>>>
>>>> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> 
> Good day Krzysztof,
> 
>>>
>>> Can you use the same email as for SoB?
> 
> I have sent patches to the LKML from a work email before, but I just

That's not what I asked. You can send them from whatever, I asked that
commit identity should match SoB in exact way.


> double-checked that I am using my personal email for everything here:
> 
> $ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed'
> Author: Sam Edwards <CFSworks@gmail.com>
>     dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
>     Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> $ grep -E '^From|^Signed'
> outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch
> From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001
> From: Sam Edwards <CFSworks@gmail.com>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>

So apply the patch from the mailing list and you will see:

Author: Sam Edwards <cfsworks@gmail.com>
Signed-off-by: Sam Edwards <CFSworks@gmail.com>

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906

[Sam Edwards]

On Sat, Oct 5, 2024 at 1:54 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 04/10/2024 19:21, Sam Edwards wrote:
> > On Thu, Oct 3, 2024 at 11:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 04/10/2024 08:49, Krzysztof Kozlowski wrote:
> >>> On Thu, Oct 03, 2024 at 03:08:19PM -0700, Sam Edwards wrote:
> >>>> This is a series (EX3510-B0 and EX3510-B1) of residential gateways based
> >>>> on BCM4906, a stripped-down version of the BCM4908 SoC. Although Zyxel's
> >>>> marketing materials call this a "series," the EX3510-B1 appears to be a
> >>>> very minor revision of the EX3510-B0, with only changes that are
> >>>> transparent to software. As far as Linux is concerned, this "series"
> >>>> effectively represents a single model.
> >>>>
> >>>> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> >
> > Good day Krzysztof,
> >
> >>>
> >>> Can you use the same email as for SoB?
> >
> > I have sent patches to the LKML from a work email before, but I just
>
> That's not what I asked. You can send them from whatever, I asked that
> commit identity should match SoB in exact way.
>
>
> > double-checked that I am using my personal email for everything here:
> >
> > $ git show ec8e6d96a05f04 | grep -E 'dt-bindings|Author|Signed'
> > Author: Sam Edwards <CFSworks@gmail.com>
> >     dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
> >     Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> > $ grep -E '^From|^Signed'
> > outgoing-ex3510b/0001-dt-bindings-arm64-bcmbca-Add-Zyxel-EX3510-B-based-on.patch
> > From ec8e6d96a05f04df00d05dec00df80172d233d8c Mon Sep 17 00:00:00 2001
> > From: Sam Edwards <CFSworks@gmail.com>
> > Signed-off-by: Sam Edwards <CFSworks@gmail.com>

Greetings Krzysztof,

> So apply the patch from the mailing list and you will see:
>
> Author: Sam Edwards <cfsworks@gmail.com>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>

Looks fine to me, those are both set to my personal (non-work)
account. The only difference I'm seeing is that the capitalization in
my email address is being discarded in the author field, but in light
of the case-insensitive nature of email addresses: these are an exact
match.

Still, I was interested to see what was affecting the capitalization
in one field but not the other, so I did some digging. To answer your
previous question: they can differ because they are transported in
different ways. Evidently git-am considers a few headers in the email
envelope significant (e.g. Subject/From/Date) by default. The
envelope's "From:" is what specifies the patch author, while the
Signed-off-by tag is just part of the message body. The envelope is
unfortunately fair game for modification by various MTAs, which would
explain why my patches aren't arriving with my 'From:' email address
capitalization intact. When I have time, I'd like to look into what
specific hop in the mail path is doing that. Hopefully it's something
I can reconfigure, but it might also be out of my hands.

Is there some other difference you're noticing that's too subtle for
me to spot? Or is it indeed the capitalization that's the key issue
here? If the latter, I want to understand why it's important so I can
see if there’s a way to work around it, or if we need to consider
other options for getting patches delivered in the preferred format in
the future.

COMMITTER: In light of the above, could you kindly add this flag to
git-am to fix the capitalization issue: --author="Sam Edwards
<CFSworks@gmail.com>"

>
> Best regards,
> Krzysztof

Have a relaxing weekend,
Sam