devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume Stols <gstols@baylibre.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Michael Hennerich <michael.hennerich@analog.com>,
	 linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	 aardelean@baylibre.com, dlechner@baylibre.com,
	 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Guillaume Stols <gstols@baylibre.com>
Subject: [PATCH v3 02/10] dt-bindings: iio: adc: ad7606: Remove spi-cpha from required
Date: Fri, 04 Oct 2024 21:48:36 +0000	[thread overview]
Message-ID: <20241004-ad7606_add_iio_backend_support-v3-2-38757012ce82@baylibre.com> (raw)
In-Reply-To: <20241004-ad7606_add_iio_backend_support-v3-0-38757012ce82@baylibre.com>

The documentation is erroneously stating that spi-cpha is required, and
the example is erroneously setting both spi-cpol and spi-cpha. According
to the datasheet, only cpol should be set.

On zedboard for instance, setting the devicetree as in the example will
simply not work.

Fixes: 416f882c3b40 ("dt-bindings: iio: adc: Migrate AD7606 documentation to yaml")
Fixes: 6e33a125df66 ("dt-bindings: iio: adc: Add docs for AD7606 ADC")
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index bec7cfba52a7..47081c79a1cf 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -39,6 +39,11 @@ properties:
   "#size-cells":
     const: 0
 
+  # According to the datasheet, "Data is clocked in from SDI on the falling
+  # edge of SCLK, while data is clocked out on DOUTA on the rising edge of
+  # SCLK".  Also, even if not stated textually in the datasheet, it is made
+  # clear on the diagrams that sclk idles at high.  Subsequently, in case SPI
+  # interface is used, the correct way is to only set spi-cpol.
   spi-cpha: true
 
   spi-cpol: true
@@ -168,7 +173,6 @@ patternProperties:
 required:
   - compatible
   - reg
-  - spi-cpha
   - avcc-supply
   - vdrive-supply
   - interrupts
@@ -255,7 +259,6 @@ examples:
             reg = <0>;
             spi-max-frequency = <1000000>;
             spi-cpol;
-            spi-cpha;
 
             avcc-supply = <&adc_vref>;
             vdrive-supply = <&vdd_supply>;
@@ -288,7 +291,6 @@ examples:
 
             spi-max-frequency = <1000000>;
             spi-cpol;
-            spi-cpha;
 
             avcc-supply = <&adc_vref>;
             vdrive-supply = <&vdd_supply>;

-- 
2.34.1


  parent reply	other threads:[~2024-10-04 21:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 21:48 [PATCH v3 00/10] Add iio backend compatibility for ad7606 Guillaume Stols
2024-10-04 21:48 ` [PATCH v3 01/10] iio: adc: ad7606: Fix typo in the driver name Guillaume Stols
2024-10-05 11:22   ` Jonathan Cameron
2024-10-04 21:48 ` Guillaume Stols [this message]
2024-10-05 18:47   ` [PATCH v3 02/10] dt-bindings: iio: adc: ad7606: Remove spi-cpha from required Rob Herring (Arm)
2024-10-04 21:48 ` [PATCH v3 03/10] dt-bindings: iio: adc: ad7606: Add iio backend bindings Guillaume Stols
2024-10-05 18:50   ` Rob Herring
2024-10-04 21:48 ` [PATCH v3 04/10] Documentation: iio: Document ad7606 driver Guillaume Stols
2024-10-04 21:48 ` [PATCH v3 05/10] iio: adc: ad7606: Sort includes in alphabetical order Guillaume Stols
2024-10-05 11:26   ` Jonathan Cameron
2024-10-04 21:48 ` [PATCH v3 06/10] iio: adc: ad7606: Add PWM support for conversion trigger Guillaume Stols
2024-10-05 11:40   ` Jonathan Cameron
2024-10-04 21:48 ` [PATCH v3 07/10] iio: adc: ad7606: Add compatibility to fw_nodes Guillaume Stols
2024-10-06  6:23   ` kernel test robot
2024-10-04 21:48 ` [PATCH v3 08/10] iio: adc: ad7606: Introduce num_adc_channels Guillaume Stols
2024-10-04 21:48 ` [PATCH v3 09/10] iio: adc: ad7606: Add iio-backend support Guillaume Stols
2024-10-05 11:53   ` Jonathan Cameron
2024-10-08 14:15     ` Guillaume Stols
2024-10-10 18:04       ` Jonathan Cameron
2024-10-06  5:31   ` kernel test robot
2024-10-04 21:48 ` [PATCH v3 10/10] iio: adc: ad7606: Disable PWM usage for non backend version Guillaume Stols

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004-ad7606_add_iio_backend_support-v3-2-38757012ce82@baylibre.com \
    --to=gstols@baylibre.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=aardelean@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).