[PATCH v2 1/2] dt-bindings: mfd: mediatek: mt6397: add adc, codec and regulators for mt6359

[PATCH v2 1/2] dt-bindings: mfd: mediatek: mt6397: add adc, codec and regulators for mt6359

[Macpaul Lin]

Since MT6359 PMIC has been added as one of the compatibles of
"mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC",
"MT6359 Audio Codec"  and "MT6359 PMIC Regulators" should also be
contained in this DT Schema as well.

This patch includes:
 - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
 - add 'mt6359-regulator' to the compatibles of regulators.
 - add 'mt6359-codec' to the compatibles of audio-codec.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 .../devicetree/bindings/mfd/mediatek,mt6397.yaml          | 8 ++++++++
 1 file changed, 8 insertions(+)

Changes for v2:
 - Rebase on top of the DT schema conversion patch V8 (should be final version)
   without adc, audio-codec, and regulator.
   [1] https://lore.kernel.org/all/20241001104145.24054-3-macpaul.lin@mediatek.com/
 - Add 'mt6359-codec' to the compatibles of 'audio-codec' property.
   Please help to review it again.

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 95e9566fc535..35c4bc199b4e 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -17,6 +17,7 @@ description: |
   MT6397/MT6323 is a multifunction device with the following sub modules:
   - Regulators
   - RTC
+  - ADC
   - Audio codec
   - GPIO
   - Clock
@@ -86,6 +87,7 @@ properties:
           - enum:
               - mediatek,mt6323-regulator
               - mediatek,mt6358-regulator
+              - mediatek,mt6359-regulator
               - mediatek,mt6397-regulator
           - items:
               - enum:
@@ -95,6 +97,11 @@ properties:
     required:
       - compatible
 
+  adc:
+    type: object
+    $ref: /schemas/iio/adc/mediatek,mt6359-auxadc.yaml#
+    unevaluatedProperties: false
+
   audio-codec:
     type: object
     description:
@@ -106,6 +113,7 @@ properties:
         oneOf:
           - enum:
               - mediatek,mt6358-sound
+              - mediatek,mt6359-codec
               - mediatek,mt6397-codec
           - items:
               - enum:
-- 
2.45.2

[PATCH v2 2/2] arm64: dts: mediatek: mt6359: fix dtbs_check error for RTC and regulators

[Macpaul Lin]

This patch fixes the following dtbs_check errors:
1. 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
 - Update 'mt6359rtc' in 'mt6359.dtsi' with a generic device name 'rtc'
2. 'pmic: regulators: 'compatible' is a required property'
 - Add 'mediatek,mt6359-regulator' to compatible property.

Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Changes for v2:
 - No change.

diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 8e1b8c85c6ed..dd732a820a7c 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -18,6 +18,8 @@ mt6359codec: mt6359codec {
 		};
 
 		regulators {
+			compatible = "mediatek,mt6359-regulator";
+
 			mt6359_vs1_buck_reg: buck_vs1 {
 				regulator-name = "vs1";
 				regulator-min-microvolt = <800000>;
@@ -296,7 +298,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
 			};
 		};
 
-		mt6359rtc: mt6359rtc {
+		mt6359_rtc: rtc {
 			compatible = "mediatek,mt6358-rtc";
 		};
 	};
-- 
2.45.2

Re: [PATCH v2 1/2] dt-bindings: mfd: mediatek: mt6397: add adc, codec and regulators for mt6359

[Krzysztof Kozlowski]

On Fri, Oct 04, 2024 at 11:01:47AM +0800, Macpaul Lin wrote:
> Since MT6359 PMIC has been added as one of the compatibles of
> "mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC",
> "MT6359 Audio Codec"  and "MT6359 PMIC Regulators" should also be
> contained in this DT Schema as well.
> 
> This patch includes:
>  - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
>  - add 'mt6359-regulator' to the compatibles of regulators.
>  - add 'mt6359-codec' to the compatibles of audio-codec.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../devicetree/bindings/mfd/mediatek,mt6397.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> Changes for v2:
>  - Rebase on top of the DT schema conversion patch V8 (should be final version)
>    without adc, audio-codec, and regulator.
>    [1] https://lore.kernel.org/all/20241001104145.24054-3-macpaul.lin@mediatek.com/
>  - Add 'mt6359-codec' to the compatibles of 'audio-codec' property.
>    Please help to review it again.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: mediatek: mt6397: add adc, codec and regulators for mt6359

[Lee Jones]

On Fri, 04 Oct 2024 11:01:47 +0800, Macpaul Lin wrote:
> Since MT6359 PMIC has been added as one of the compatibles of
> "mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC",
> "MT6359 Audio Codec"  and "MT6359 PMIC Regulators" should also be
> contained in this DT Schema as well.
> 
> This patch includes:
>  - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
>  - add 'mt6359-regulator' to the compatibles of regulators.
>  - add 'mt6359-codec' to the compatibles of audio-codec.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: mfd: mediatek: mt6397: add adc, codec and regulators for mt6359
      commit: 5bcecfcaa6d1d4ea1b29082ed1fd077ba4cccb55

--
Lee Jones [李琼斯]

Re: [PATCH v2 1/2] dt-bindings: mfd: mediatek: mt6397: add adc, codec and regulators for mt6359

[AngeloGioacchino Del Regno]

Il 04/10/24 05:01, Macpaul Lin ha scritto:
> Since MT6359 PMIC has been added as one of the compatibles of
> "mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC",
> "MT6359 Audio Codec"  and "MT6359 PMIC Regulators" should also be
> contained in this DT Schema as well.
> 
> This patch includes:
>   - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
>   - add 'mt6359-regulator' to the compatibles of regulators.
>   - add 'mt6359-codec' to the compatibles of audio-codec.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com

Re: [PATCH v2 2/2] arm64: dts: mediatek: mt6359: fix dtbs_check error for RTC and regulators

[AngeloGioacchino Del Regno]

Il 04/10/24 05:01, Macpaul Lin ha scritto:
> This patch fixes the following dtbs_check errors:
> 1. 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
>   - Update 'mt6359rtc' in 'mt6359.dtsi' with a generic device name 'rtc'
> 2. 'pmic: regulators: 'compatible' is a required property'
>   - Add 'mediatek,mt6359-regulator' to compatible property.
> 
> Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>