* [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description
@ 2024-10-05 12:58 Fabio Estevam
2024-10-08 6:15 ` Lothar Waßmann
2024-10-21 9:38 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-10-05 12:58 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, LW,
Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Per fixed-clock.yaml, it is not correct to pass unit address and
reg to represent 'fixed-clock'.
Remove it to fix the following dt-schema warning:
clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
index 5a194f4c0cb9..2fa37d1b16cc 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
@@ -70,9 +70,8 @@ clocks {
#address-cells = <1>;
#size-cells = <0>;
- mclk: clock@0 {
+ mclk: clock {
compatible = "fixed-clock";
- reg = <0>;
#clock-cells = <0>;
clock-frequency = <26000000>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description
2024-10-05 12:58 [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description Fabio Estevam
@ 2024-10-08 6:15 ` Lothar Waßmann
2024-10-21 9:38 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Lothar Waßmann @ 2024-10-08 6:15 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
Fabio Estevam
Hi,
> From: Fabio Estevam <festevam@denx.de>
>
> Per fixed-clock.yaml, it is not correct to pass unit address and
> reg to represent 'fixed-clock'.
>
> Remove it to fix the following dt-schema warning:
>
> clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> index 5a194f4c0cb9..2fa37d1b16cc 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> @@ -70,9 +70,8 @@ clocks {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - mclk: clock@0 {
> + mclk: clock {
> compatible = "fixed-clock";
> - reg = <0>;
> #clock-cells = <0>;
> clock-frequency = <26000000>;
> };
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description
2024-10-05 12:58 [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description Fabio Estevam
2024-10-08 6:15 ` Lothar Waßmann
@ 2024-10-21 9:38 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-10-21 9:38 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
LW, Fabio Estevam
On Sat, Oct 05, 2024 at 09:58:24AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per fixed-clock.yaml, it is not correct to pass unit address and
> reg to represent 'fixed-clock'.
>
> Remove it to fix the following dt-schema warning:
>
> clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-21 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-05 12:58 [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description Fabio Estevam
2024-10-08 6:15 ` Lothar Waßmann
2024-10-21 9:38 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).