* [PATCH v1] dt-bindings: spi: add compatibles for mt7988
@ 2024-10-06 10:27 Frank Wunderlich
2024-10-06 12:48 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2024-10-06 10:27 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno
Cc: Frank Wunderlich, Leilk Liu, linux-spi, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, daniel, john, eladwf,
ansuelsmth
From: Frank Wunderlich <frank-w@public-files.de>
MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
and mediatek,ipm-spi-quad compatibles.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
index e1f5bfa4433c..3c707e5de5fb 100644
--- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
@@ -33,6 +33,8 @@ properties:
- const: mediatek,mt6765-spi
- items:
- enum:
+ - mediatek,ipm-spi-quad
+ - mediatek,ipm-spi-single
- mediatek,mt7981-spi-ipm
- mediatek,mt7986-spi-ipm
- mediatek,mt8188-spi-ipm
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
2024-10-06 10:27 [PATCH v1] dt-bindings: spi: add compatibles for mt7988 Frank Wunderlich
@ 2024-10-06 12:48 ` Krzysztof Kozlowski
2024-10-06 15:11 ` Aw: " Frank Wunderlich
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-06 12:48 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Frank Wunderlich,
Leilk Liu, linux-spi, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, daniel, john, eladwf, ansuelsmth
On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
> and mediatek,ipm-spi-quad compatibles.
Why generic compatibles?
These are supposed to be SoC-specific.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Aw: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
2024-10-06 12:48 ` Krzysztof Kozlowski
@ 2024-10-06 15:11 ` Frank Wunderlich
2024-10-07 14:16 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2024-10-06 15:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Frank Wunderlich, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Leilk Liu, linux-spi, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, daniel, john, eladwf, ansuelsmth
Hi
> Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
> Von: "Krzysztof Kozlowski" <krzk@kernel.org>
> Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
>
> On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
> > and mediatek,ipm-spi-quad compatibles.
>
> Why generic compatibles?
>
> These are supposed to be SoC-specific.
currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Aw: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
2024-10-06 15:11 ` Aw: " Frank Wunderlich
@ 2024-10-07 14:16 ` Matthias Brugger
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2024-10-07 14:16 UTC (permalink / raw)
To: Frank Wunderlich, Krzysztof Kozlowski
Cc: Frank Wunderlich, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, AngeloGioacchino Del Regno, Leilk Liu, linux-spi,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
daniel, john, eladwf, ansuelsmth
On 06/10/2024 17:11, Frank Wunderlich wrote:
> Hi
>
>> Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
>> Von: "Krzysztof Kozlowski" <krzk@kernel.org>
>> Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
>>
>> On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
>>> and mediatek,ipm-spi-quad compatibles.
>>
>> Why generic compatibles?
>>
>> These are supposed to be SoC-specific.
>
> currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.
>
Ok, but please don't introduce generic compatibles. We prever SoC specific ones
with a fall-back (to a different SoC specific one).
Regards,
Matthias
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-07 14:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-06 10:27 [PATCH v1] dt-bindings: spi: add compatibles for mt7988 Frank Wunderlich
2024-10-06 12:48 ` Krzysztof Kozlowski
2024-10-06 15:11 ` Aw: " Frank Wunderlich
2024-10-07 14:16 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).