From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9401D14FA for ; Mon, 7 Oct 2024 10:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728298697; cv=none; b=k8wBk7CqxlxbG81dIKjLAneTaD+0Gft6iEEUem59Fg0uH+zcZUX4+u2kelHULeI9JUuA+iKNL4mMmDzRVSY/IB67wAz8B1OdValBmXt66iIL2mjlViPQO/9X7oOdBWh9dUifSgP6pFtj/8hAgbRlPPFfC7UqB/YSR2fJg0qviXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728298697; c=relaxed/simple; bh=kffpwyYW1A2MRW4V27wqpYISOP+zPXXsnNUffNU5Jcw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZSVE6jrdqQWH1VpRvyYzDj6GdugYukdgVJyffsFlFgUFSUL+DP3yOdntmVgaFT9Fb7dZ4UCH9g8GmnTIxQW6HW3oQ5nGTQknnO9GuUEDTkUHceu3jMNZbh6mmbKiK2uZ6XIHStd+nncPLtVi8YZM1Q57p/dMwuHOq7nvz3J4HCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=Zm6I7VlQ; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="Zm6I7VlQ" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728298692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVypFZndkb1hDBUGAh8t09mRCyK4drfE9GWmDKb6pno=; b=Zm6I7VlQmDUwlKb/YjknRT4RT1FEJSf4kD6G4DBU0o/l4mOu6cy8i8YOP5jp3PAlwsijoY EaS0x+Zgn9pIrvsDuAzZA3YPS+WNzksjS9H+bGO3FOZ3gigogjel+8/EYPtzOla+ke1VnH ikJ597MLpohaKorPEkdUCGooDcGHCUaIv1+ABVaYKOUttLsDauIAkxJh0BUDqo9f3oIwHA lM8pu+sMPWcHm4+enw/3K4eCBdc9IZjUed5gU6lcSVavpvMOr9m5xb8s61RRygQHXgoH5b 0b2kOz7urxloIK5XGrzRtH8hYKpHbOL8M2tF4IlL/W6Sm/mfij30z46h7D4x4A== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328 Date: Mon, 7 Oct 2024 12:28:17 +0200 Message-ID: <20241007105657.6203-4-didi.debian@cknow.org> In-Reply-To: <20241007105657.6203-2-didi.debian@cknow.org> References: <20241007105657.6203-2-didi.debian@cknow.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts property of the hdmi node has 'maxItems: 1', so the hdmi node in rk3328.dtsi having 2 is incorrect. Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1 page 16 and 17 define the following hdmi related interrupts: - 67 hdmi_intr - 103 hdmi_intr_wakeup The difference of 32 is due to a different base used in the TRM. The RK3399 (which uses the same binding) has '23: hdmi_irq' and '24: hdmi_wakeup_irq' according to its TRM (page 19). The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi' according to page 17 of its TRM. In both cases the non-wakeup IRQ was used, so use that too for rk3328. Helped-by: Heiko Stuebner Signed-off-by: Diederik de Haas --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index b5cbe7cab10b..0597de415fe0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -754,8 +754,7 @@ hdmi: hdmi@ff3c0000 { compatible = "rockchip,rk3328-dw-hdmi"; reg = <0x0 0xff3c0000 0x0 0x20000>; reg-io-width = <4>; - interrupts = , - ; + interrupts = ; clocks = <&cru PCLK_HDMI>, <&cru SCLK_HDMI_SFC>, <&cru SCLK_RTC32K>; -- 2.45.2