Re: [PATCH v4 3/4] power: supply: initial support for TWL6030/32

Sebastian Reichel
2024-10-15T22:11:52Z

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi,

On Mon, Oct 07, 2024 at 05:01:19PM +0200, Andreas Kemnade wrote:
> Add a driver for the charger in the TWL6030/32. For now it does not report
> much in sysfs but parameters are set up for USB, charging is enabled with
> the specified parameters. It stops charging when full and also restarts
> charging.
> This prevents ending up in a system setup where you run out of battery
> although a charger is plugged in after precharge completed.
>
> Battery voltage behavior was checked via the GPADC.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---

Looks mostly good, but the driver should set the fwnode for the
power_supply device to be ready for better battery support in
the future:

psy_cfg.fwnode = dev_fwnode(&pdev->dev);

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]