devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alain Volmat <alain.volmat@foss.st.com>
To: Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: <linux-media@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Alain Volmat <alain.volmat@foss.st.com>, <stable@vger.kernel.org>
Subject: [PATCH 01/15] media: stm32: dcmipp: correct dma_set_mask_and_coherent mask value
Date: Tue, 8 Oct 2024 13:18:03 +0200	[thread overview]
Message-ID: <20241008-csi_dcmipp_mp25-v1-1-e3fd0ed54b31@foss.st.com> (raw)
In-Reply-To: <20241008-csi_dcmipp_mp25-v1-0-e3fd0ed54b31@foss.st.com>

Correct the call to dma_set_mask_and_coherent which should be set
to DMA_BIT_MASK(32).

Fixes: 28e0f3772296 ("media: stm32-dcmipp: STM32 DCMIPP camera interface driver")
Cc: stable@vger.kernel.org
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
index 9f768f011fa2..0f6918f4db38 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
@@ -893,7 +893,7 @@ struct dcmipp_ent_device *dcmipp_bytecap_ent_init(struct device *dev,
 	q->dev = dev;
 
 	/* DCMIPP requires 16 bytes aligned buffers */
-	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32) & ~0x0f);
+	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
 	if (ret) {
 		dev_err(dev, "Failed to set DMA mask\n");
 		goto err_mutex_destroy;

-- 
2.25.1


  reply	other threads:[~2024-10-08 11:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 11:18 [PATCH 00/15] media: stm32: introduction of CSI / DCMIPP for STM32MP25 Alain Volmat
2024-10-08 11:18 ` Alain Volmat [this message]
2024-10-08 11:18 ` [PATCH 02/15] dt-bindings: media: addition of stm32 csi driver description Alain Volmat
2024-10-08 12:36   ` Rob Herring (Arm)
2024-10-08 13:23   ` Krzysztof Kozlowski
2024-11-05  7:42     ` Alain Volmat
2024-10-08 11:18 ` [PATCH 03/15] media: stm32: csi: addition of the STM32 CSI driver Alain Volmat
2024-10-08 11:18 ` [PATCH 04/15] media: stm32: dcmipp: use v4l2_subdev_is_streaming Alain Volmat
2024-10-08 11:18 ` [PATCH 05/15] media: stm32: dcmipp: replace s_stream with enable/disable_streams Alain Volmat
2024-10-08 11:18 ` [PATCH 06/15] media: stm32: dcmipp: rename dcmipp_parallel into dcmipp_input Alain Volmat
2024-10-08 11:18 ` [PATCH 07/15] media: stm32: dcmipp: add support for csi input into dcmipp-input Alain Volmat
2024-10-08 11:18 ` [PATCH 08/15] media: stm32: dcmipp: add bayer 10~14 bits formats Alain Volmat
2024-10-08 11:18 ` [PATCH 09/15] media: stm32: dcmipp: add 1X16 RGB / YUV formats support Alain Volmat
2024-10-08 11:18 ` [PATCH 10/15] media: stm32: dcmipp: avoid duplicated format on enum in bytecap Alain Volmat
2024-10-08 11:18 ` [PATCH 11/15] media: stm32: dcmipp: fill media ctl hw_revision field Alain Volmat
2024-10-08 11:18 ` [PATCH 12/15] dt-bindings: media: addition of stm32mp25 compatible of DCMIPP Alain Volmat
2024-10-08 13:41   ` Krzysztof Kozlowski
2024-11-05  7:43     ` Alain Volmat
2024-10-08 11:18 ` [PATCH 13/15] media: stm32: dcmipp: add core support for the stm32mp25 Alain Volmat
2024-10-08 11:18 ` [PATCH 14/15] arm64: dts: st: add csi & dcmipp node in stm32mp25 Alain Volmat
2024-10-08 11:18 ` [PATCH 15/15] arm64: dts: st: enable imx335/csi/dcmipp pipeline on stm32mp257f-ev1 Alain Volmat
2024-10-08 13:42   ` Krzysztof Kozlowski
2024-11-05  7:45     ` Alain Volmat
2024-10-08 14:56 ` [PATCH 00/15] media: stm32: introduction of CSI / DCMIPP for STM32MP25 Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241008-csi_dcmipp_mp25-v1-1-e3fd0ed54b31@foss.st.com \
    --to=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hugues.fruchet@foss.st.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mchehab@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).