From: Conor Dooley <conor@kernel.org>
To: wenliang yan <wenliang202407@163.com>
Cc: linux@roeck-us.net, jdelvare@suse.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205)
Date: Tue, 8 Oct 2024 17:17:21 +0100 [thread overview]
Message-ID: <20241008-unlatch-frying-d7576b77f99a@spud> (raw)
In-Reply-To: <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
Hey,
On Tue, Oct 08, 2024 at 07:58:51PM +0800, wenliang yan wrote:
> Modified the binding of ina2xx to make it compatible with SY24655.
>
>
>
>
> Signed-off-by: Wenliang <wenliang202407@163.com>
>
> ---
>
>
>
>
> SY24655 is a fixed gain power monitor from Silergy, with a power supply
>
> of 2.7-5.5V and communication mode of IIC capable of detecting bus voltage
>
> and voltage on shunt resistors. Its first 5 registers are identical to
>
> ina226, and also have alert and limit functions. So, the sy24655 is
>
> compatible with the ina2xx devices.
This should be above the signoff and --- line. Your patch is pretty
badly malformed, did you use b4 or git send-email to submit it?
Cheers,
Conor.
>
>
>
>
> Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>
> 1 file changed, 1 insertion(+)
>
>
>
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>
> index 6ae961732e6b..05a9cb36cd82 100644
>
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>
> @@ -20,6 +20,7 @@ description: |
>
> properties:
>
> compatible:
>
> enum:
>
> + - silergy,sy24655
>
> - ti,ina209
>
> - ti,ina219
>
> - ti,ina220
>
> --
>
> 2.17.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-10-08 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7c155638-8c33-4873-9534-17a9454c83e6@roeck-us.net>
[not found] ` <20240911122518.41393-1-wenliang202407@163.com>
2024-09-11 12:25 ` [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) Wenliang
2024-09-11 17:49 ` Conor Dooley
2024-10-08 12:35 ` Krzysztof Kozlowski
2024-10-08 16:26 ` Conor Dooley
[not found] ` <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com>
2024-10-08 16:17 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008-unlatch-frying-d7576b77f99a@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).