* [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) [not found] ` <20240911122518.41393-1-wenliang202407@163.com> @ 2024-09-11 12:25 ` Wenliang 2024-09-11 17:49 ` Conor Dooley 0 siblings, 1 reply; 5+ messages in thread From: Wenliang @ 2024-09-11 12:25 UTC (permalink / raw) To: linux Cc: Wenliang, jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel Modified the binding of ina2xx to make it compatible with SY24655. Signed-off-by: Wenliang <wenliang202407@163.com> --- Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml index 6ae961732e6b..400e7cefad17 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml @@ -29,6 +29,7 @@ properties: - ti,ina237 - ti,ina238 - ti,ina260 + - silergy,sy24655 reg: maxItems: 1 -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) 2024-09-11 12:25 ` [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) Wenliang @ 2024-09-11 17:49 ` Conor Dooley 2024-10-08 12:35 ` Krzysztof Kozlowski [not found] ` <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com> 0 siblings, 2 replies; 5+ messages in thread From: Conor Dooley @ 2024-09-11 17:49 UTC (permalink / raw) To: Wenliang Cc: linux, jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 931 bytes --] On Wed, Sep 11, 2024 at 08:25:18AM -0400, Wenliang wrote: > Modified the binding of ina2xx to make it compatible with SY24655. Rather, you should explain why the sy24655 is compatible with the ina2xx devices. > > Signed-off-by: Wenliang <wenliang202407@163.com> > --- > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > index 6ae961732e6b..400e7cefad17 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > @@ -29,6 +29,7 @@ properties: > - ti,ina237 > - ti,ina238 > - ti,ina260 > + - silergy,sy24655 Please add this in alphabetical order. Thanks, Conor. > > reg: > maxItems: 1 > -- > 2.17.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) 2024-09-11 17:49 ` Conor Dooley @ 2024-10-08 12:35 ` Krzysztof Kozlowski 2024-10-08 16:26 ` Conor Dooley [not found] ` <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com> 1 sibling, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2024-10-08 12:35 UTC (permalink / raw) To: Conor Dooley, Wenliang Cc: linux, jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel On 11/09/2024 19:49, Conor Dooley wrote: > On Wed, Sep 11, 2024 at 08:25:18AM -0400, Wenliang wrote: >> Modified the binding of ina2xx to make it compatible with SY24655. > > Rather, you should explain why the sy24655 is compatible with the ina2xx > devices. > >> This looks like patch for some forked tree, like the BMC folks are doing. At least linux dev suggests it. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) 2024-10-08 12:35 ` Krzysztof Kozlowski @ 2024-10-08 16:26 ` Conor Dooley 0 siblings, 0 replies; 5+ messages in thread From: Conor Dooley @ 2024-10-08 16:26 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Wenliang, linux, jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 515 bytes --] On Tue, Oct 08, 2024 at 02:35:38PM +0200, Krzysztof Kozlowski wrote: > On 11/09/2024 19:49, Conor Dooley wrote: > > On Wed, Sep 11, 2024 at 08:25:18AM -0400, Wenliang wrote: > >> Modified the binding of ina2xx to make it compatible with SY24655. > > > > Rather, you should explain why the sy24655 is compatible with the ina2xx > > devices. > > > >> > > This looks like patch for some forked tree, like the BMC folks are > doing. At least linux dev suggests it. CC list wouldn't imply that it is. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com>]
* Re: Re: [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) [not found] ` <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com> @ 2024-10-08 16:17 ` Conor Dooley 0 siblings, 0 replies; 5+ messages in thread From: Conor Dooley @ 2024-10-08 16:17 UTC (permalink / raw) To: wenliang yan Cc: linux, jdelvare, robh, krzk+dt, conor+dt, linux-hwmon, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1437 bytes --] Hey, On Tue, Oct 08, 2024 at 07:58:51PM +0800, wenliang yan wrote: > Modified the binding of ina2xx to make it compatible with SY24655. > > > > > Signed-off-by: Wenliang <wenliang202407@163.com> > > --- > > > > > SY24655 is a fixed gain power monitor from Silergy, with a power supply > > of 2.7-5.5V and communication mode of IIC capable of detecting bus voltage > > and voltage on shunt resistors. Its first 5 registers are identical to > > ina226, and also have alert and limit functions. So, the sy24655 is > > compatible with the ina2xx devices. This should be above the signoff and --- line. Your patch is pretty badly malformed, did you use b4 or git send-email to submit it? Cheers, Conor. > > > > > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > > index 6ae961732e6b..05a9cb36cd82 100644 > > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > > @@ -20,6 +20,7 @@ description: | > > properties: > > compatible: > > enum: > > + - silergy,sy24655 > > - ti,ina209 > > - ti,ina219 > > - ti,ina220 > > -- > > 2.17.1 > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-08 16:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <7c155638-8c33-4873-9534-17a9454c83e6@roeck-us.net>
[not found] ` <20240911122518.41393-1-wenliang202407@163.com>
2024-09-11 12:25 ` [PATCH linux dev-6.11 2/2] dt-bindings: modified ina2xx to match SY24655(SQ52205) Wenliang
2024-09-11 17:49 ` Conor Dooley
2024-10-08 12:35 ` Krzysztof Kozlowski
2024-10-08 16:26 ` Conor Dooley
[not found] ` <6dcf956c.c4f1.1926bff1453.Coremail.wenliang202407@163.com>
2024-10-08 16:17 ` Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).