* [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
@ 2024-10-08 5:35 Macpaul Lin
2024-10-08 6:45 ` Chen-Yu Tsai
2024-10-08 7:10 ` Fei Shao
0 siblings, 2 replies; 5+ messages in thread
From: Macpaul Lin @ 2024-10-08 5:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin, Sen Chu,
Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai
The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
The error message was:
t-phy@11e30000: 'power-domains' does not match any of the regexes:
'^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
Fix this issue by dropping 'power-domains' of u3phy1 node.
Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ade685ed2190..1c6f08dde31c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 {
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0 0x11e30000 0xe00>;
- power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
status = "disabled";
u2port1: usb-phy@0 {
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-08 5:35 [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Macpaul Lin
@ 2024-10-08 6:45 ` Chen-Yu Tsai
2024-10-08 7:10 ` Fei Shao
1 sibling, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2024-10-08 6:45 UTC (permalink / raw)
To: Macpaul Lin
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat, Bear Wang, Pablo Sun,
Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream
On Tue, Oct 8, 2024 at 1:35 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>
> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> The error message was:
> t-phy@11e30000: 'power-domains' does not match any of the regexes:
> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> Fix this issue by dropping 'power-domains' of u3phy1 node.
You should also mention why this fix is correct from a hardware viewpoint,
i.e. why removing the power domain won't break the device.
> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ade685ed2190..1c6f08dde31c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 {
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0 0x11e30000 0xe00>;
> - power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
> status = "disabled";
>
> u2port1: usb-phy@0 {
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-08 5:35 [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Macpaul Lin
2024-10-08 6:45 ` Chen-Yu Tsai
@ 2024-10-08 7:10 ` Fei Shao
2024-10-09 8:49 ` Macpaul Lin
1 sibling, 1 reply; 5+ messages in thread
From: Fei Shao @ 2024-10-08 7:10 UTC (permalink / raw)
To: Macpaul Lin
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat, Bear Wang, Pablo Sun,
Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream,
Chen-Yu Tsai
On Tue, Oct 8, 2024 at 1:36 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>
> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> The error message was:
> t-phy@11e30000: 'power-domains' does not match any of the regexes:
> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> Fix this issue by dropping 'power-domains' of u3phy1 node.
>
> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
Apart from this, can you or Chunfeng confirm if we should make a
similar change for MT8188[1]?
[1]: https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
Regards,
Fei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-08 7:10 ` Fei Shao
@ 2024-10-09 8:49 ` Macpaul Lin
2024-10-09 10:55 ` Fei Shao
0 siblings, 1 reply; 5+ messages in thread
From: Macpaul Lin @ 2024-10-09 8:49 UTC (permalink / raw)
To: Fei Shao, Chunfeng Yun, Jieyy Yang, Jian Yang, Jianguo Zhang
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat, Bear Wang, Pablo Sun,
Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream,
Chen-Yu Tsai
On 10/8/24 15:10, Fei Shao wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On Tue, Oct 8, 2024 at 1:36 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>>
>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
>> The error message was:
>> t-phy@11e30000: 'power-domains' does not match any of the regexes:
>> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>> Fix this issue by dropping 'power-domains' of u3phy1 node.
>>
>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>
> Apart from this, can you or Chunfeng confirm if we should make a
> similar change for MT8188[1]?
>
> [1]: https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
>
> Regards,
> Fei
>
According to the suggestion and discussion in
[1]:
https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6
I think adding 'power-domains' to PCIE node of MT8188 is okay.
Thanks
Macpaul Lin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-09 8:49 ` Macpaul Lin
@ 2024-10-09 10:55 ` Fei Shao
0 siblings, 0 replies; 5+ messages in thread
From: Fei Shao @ 2024-10-09 10:55 UTC (permalink / raw)
To: Macpaul Lin
Cc: Chunfeng Yun, Jieyy Yang, Jian Yang, Jianguo Zhang, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Alexandre Mergnat, Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu,
Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai
On Wed, Oct 9, 2024 at 4:50 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>
> On 10/8/24 15:10, Fei Shao wrote:
> >
> > External email : Please do not click links or open attachments until you
> > have verified the sender or the content.
> >
> > On Tue, Oct 8, 2024 at 1:36 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
> >>
> >> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> >> The error message was:
> >> t-phy@11e30000: 'power-domains' does not match any of the regexes:
> >> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >> Fix this issue by dropping 'power-domains' of u3phy1 node.
> >>
> >> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> >> ---
> >
> > Apart from this, can you or Chunfeng confirm if we should make a
> > similar change for MT8188[1]?
> >
> > [1]: https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
> >
> > Regards,
> > Fei
> >
>
> According to the suggestion and discussion in
>
> [1]:
> https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6
>
> I think adding 'power-domains' to PCIE node of MT8188 is okay.
>
Acked, thanks!
Fei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-09 10:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 5:35 [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Macpaul Lin
2024-10-08 6:45 ` Chen-Yu Tsai
2024-10-08 7:10 ` Fei Shao
2024-10-09 8:49 ` Macpaul Lin
2024-10-09 10:55 ` Fei Shao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).