From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 102011DE8A0; Tue, 8 Oct 2024 12:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728391045; cv=none; b=C5Nj2lIqJFloji42YYkWqpIisgtwP7/p0BNHtwSsbbZr9P1JiOtSX/YCfeDkfcxxvOI6bJpXwwRQt6II20WP3dL9g43jE4V0nNOHyr5+w7L61hMALpS43jYxX4LKLaFZjX9tFX/VX12wgEwkpMXbnr2jVcSlN3owZMC4de/yxek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728391045; c=relaxed/simple; bh=v+WEtr9dY35jpvsZbM+NVqKIkmPufzTrm8bl+Rlh480=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mcoW4JI1celDHkNP8DoL1DXwkH+5GnMWV4i2jRj2k3w1RyHZGVFvnkSV+KPxBlyjLww8KGJ7EeZ0Bur75Z/VS7VlcX0VV74u5OzMe+tFy4Cy8ziji4u1wcX3l/BfHMdM7fMRvtqpxAfOVijggwNfBTrgEFBZuicLi9Zjooqpip4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DFD66DA7; Tue, 8 Oct 2024 05:37:52 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 073183F73F; Tue, 8 Oct 2024 05:37:20 -0700 (PDT) Date: Tue, 8 Oct 2024 13:37:18 +0100 From: Andre Przywara To: Ryan Walklin Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 6/6] arm64: dts: allwinner: h616: Add audio codec node Message-ID: <20241008133718.3ed32cb8@donnerap.manchester.arm.com> In-Reply-To: <20240929100750.860329-7-ryan@testtoast.com> References: <20240929100750.860329-1-ryan@testtoast.com> <20240929100750.860329-7-ryan@testtoast.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 29 Sep 2024 23:06:07 +1300 Ryan Walklin wrote: Hi Ryan, > Now that the sun4i codec driver supports the H616, add a node in the > device tree for it. Can you please add another patch that actually enables the codec for at least one board? Is that really just status = "okay";? Or do we need simple-soundcard nodes still? I will try to give it a test on the H61* boards I have, and would then like those boards to be enabled as well, as part of this series. Otherwise it's somewhat of a dead feature, isn't it? Cheers, Andre > Signed-off-by: Ryan Walklin > --- > arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > index e88c1fbac6acc..006fdb7e7e0ae 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > @@ -645,6 +645,21 @@ spdif: spdif@5093000 { > status = "disabled"; > }; > > + codec: codec@05096000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun50i-h616-codec"; > + reg = <0x05096000 0x31c>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_AUDIO_CODEC>, > + <&ccu CLK_AUDIO_CODEC_1X>, > + <&ccu CLK_AUDIO_CODEC_4X>; > + clock-names = "apb", "codec", "audio-codec-4x"; > + resets = <&ccu RST_BUS_AUDIO_CODEC>; > + dmas = <&dma 6>; > + dma-names = "tx"; > + status = "disabled"; > + }; > + > gpadc: adc@5070000 { > compatible = "allwinner,sun50i-h616-gpadc", > "allwinner,sun20i-d1-gpadc";