* [PATCH v2 2/2] arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B
2024-10-09 21:54 [PATCH v2 0/2] Add support for Zyxel EX3510-B Sam Edwards
2024-10-09 21:54 ` [PATCH v2 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906 Sam Edwards
@ 2024-10-09 21:54 ` Sam Edwards
2024-11-24 17:57 ` Florian Fainelli
2024-10-10 14:30 ` [PATCH v2 0/2] Add support " Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Sam Edwards @ 2024-10-09 21:54 UTC (permalink / raw)
To: Florian Fainelli, Rafał Miłecki, William Zhang,
Anand Gore, Kursad Oney
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Broadcom internal kernel review list, devicetree,
linux-arm-kernel, linux-kernel, Sam Edwards
Zyxel EX3510-B is a WiFi 6 capable home gateway (family) based on the
BCM4906 SoC, with 512MiB of RAM and 512MiB of NAND flash. WiFi support
consists of a BCM6710 and a BCM6715 attached to separate PCIe buses.
Add an initial devicetree for this system, with support for:
- Onboard UART (per base dtsi)
- USB (2.0 only; superspeed devices are treated as high-speed due to an
unknown cause)
- Both buttons (rear reset, front WPS)
- Almost all LEDs:
- Power (red/green)
- Internet (red/green)
- WAN (green)
- LAN (green; anode is connected to GPIO 13 so currently
nonfunctioning)
- USB (green)
- WPS button (red/green)
- Absent in DT: There are 2.4GHz/5.0GHz WiFi status LEDs connected to
the WiFi chips instead of the SoC.
- NAND flash
- Embedded Ethernet switch
- Factory-programmed Ethernet MAC address
WiFi cannot be enabled at this time due to Linux lacking drivers for
both the PCIe controllers and the PCIe WiFi peripherals.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
arch/arm64/boot/dts/broadcom/bcmbca/Makefile | 1 +
.../broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts | 196 ++++++++++++++++++
2 files changed, 197 insertions(+)
create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
index 27741b71ba9e..9a8461d91c8c 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
@@ -2,6 +2,7 @@
dtb-$(CONFIG_ARCH_BCMBCA) += \
bcm4906-netgear-r8000p.dtb \
bcm4906-tplink-archer-c2300-v1.dtb \
+ bcm4906-zyxel-ex3510b.dtb \
bcm4908-asus-gt-ac5300.dtb \
bcm4908-netgear-raxe500.dtb \
bcm94908.dtb \
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
new file mode 100644
index 000000000000..54e453bd09f7
--- /dev/null
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
@@ -0,0 +1,196 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+#include "bcm4906.dtsi"
+
+/ {
+ compatible = "zyxel,ex3510b", "brcm,bcm4906", "brcm,bcm4908", "brcm,bcmbca";
+ model = "Zyxel EX3510-B";
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x20000000>;
+ };
+
+ gpio-keys-polled {
+ compatible = "gpio-keys-polled";
+ poll-interval = <100>;
+
+ key-wps {
+ label = "WPS";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&gpio0 22 GPIO_ACTIVE_LOW>;
+ };
+
+ key-reset {
+ label = "Reset";
+ linux,code = <KEY_RESTART>;
+ gpios = <&gpio0 23 GPIO_ACTIVE_LOW>;
+ };
+ };
+};
+
+&leds {
+ pinctrl-0 = <&pins_led_0_a>, <&pins_led_2_a>, <&pins_led_3_a>,
+ <&pins_led_4_a>, <&pins_led_10_a>, <&pins_led_12_a>,
+ <&pins_led_14_a>, <&pins_led_15_a>, <&pins_led_21_a>;
+ pinctrl-names = "default";
+
+ led@0 {
+ reg = <0x0>;
+ function = LED_FUNCTION_POWER;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@2 {
+ reg = <0x2>;
+ function = LED_FUNCTION_WAN_ONLINE;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@3 {
+ reg = <0x3>;
+ function = LED_FUNCTION_WAN_ONLINE;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@4 {
+ reg = <0x4>;
+ function = LED_FUNCTION_USB;
+ color = <LED_COLOR_ID_GREEN>;
+ trigger-sources = <&ohci_port1>, <&ohci_port2>,
+ <&ehci_port1>, <&ehci_port2>,
+ <&xhci_port1>, <&xhci_port2>;
+ linux,default-trigger = "usbport";
+ };
+
+ led@a {
+ reg = <0xa>;
+ function = LED_FUNCTION_POWER;
+ color = <LED_COLOR_ID_GREEN>;
+ linux,default-trigger = "default-on";
+ };
+
+ led@c {
+ reg = <0xc>;
+ function = LED_FUNCTION_LAN;
+ color = <LED_COLOR_ID_GREEN>;
+ active-low;
+ };
+
+ led@e {
+ reg = <0xe>;
+ function = LED_FUNCTION_WPS;
+ color = <LED_COLOR_ID_GREEN>;
+ active-low;
+ };
+
+ led@f {
+ reg = <0xf>;
+ function = LED_FUNCTION_WPS;
+ color = <LED_COLOR_ID_RED>;
+ active-low;
+ };
+
+ led@15 {
+ reg = <0x15>;
+ function = LED_FUNCTION_WAN;
+ color = <LED_COLOR_ID_GREEN>;
+ active-low;
+ };
+};
+
+&enet {
+ nvmem-cells = <&base_mac_addr>;
+ nvmem-cell-names = "mac-address";
+};
+
+&usb_phy {
+ brcm,ioc = <1>;
+ brcm,ipp = <1>;
+ status = "okay";
+};
+
+&ehci {
+ status = "okay";
+};
+
+&ohci {
+ status = "okay";
+};
+
+&xhci {
+ status = "okay";
+};
+
+&ports {
+ port@0 {
+ label = "lan1";
+ };
+
+ port@1 {
+ label = "lan2";
+ };
+
+ port@2 {
+ label = "lan3";
+ };
+
+ port@3 {
+ label = "lan4";
+ };
+
+ port@7 {
+ reg = <7>;
+ phy-mode = "internal";
+ phy-handle = <&phy12>;
+ label = "wan";
+ };
+};
+
+&nand_controller {
+ status = "okay";
+};
+
+&nandcs {
+ brcm,nand-oob-sector-size = <27>;
+ nand-ecc-strength = <8>;
+ nand-ecc-step-size = <512>;
+ nand-on-flash-bbt;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ partitions {
+ compatible = "brcm,bcm4908-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ compatible = "nvmem-cells";
+ label = "cferom";
+ reg = <0x0 0x100000>;
+ read-only;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ base_mac_addr: mac@106a0 {
+ reg = <0x106a0 0x6>;
+ };
+ };
+
+ partition@100000 {
+ compatible = "brcm,bcm4908-firmware";
+ reg = <0x100000 0x5f80000>;
+ };
+
+ partition@6080000 {
+ compatible = "brcm,bcm4908-firmware";
+ reg = <0x6080000 0x5f80000>;
+ };
+ };
+};
--
2.44.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 0/2] Add support for Zyxel EX3510-B
2024-10-09 21:54 [PATCH v2 0/2] Add support for Zyxel EX3510-B Sam Edwards
2024-10-09 21:54 ` [PATCH v2 1/2] dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906 Sam Edwards
2024-10-09 21:54 ` [PATCH v2 2/2] arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B Sam Edwards
@ 2024-10-10 14:30 ` Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2024-10-10 14:30 UTC (permalink / raw)
To: Sam Edwards
Cc: linux-kernel, Kursad Oney, Broadcom internal kernel review list,
Krzysztof Kozlowski, linux-arm-kernel, William Zhang,
Conor Dooley, Anand Gore, Rafał Miłecki,
Florian Fainelli, devicetree, Sam Edwards
On Wed, 09 Oct 2024 14:54:52 -0700, Sam Edwards wrote:
> Hello BCMBCA maintainers,
>
> This is a second, very minor revision of my previous series for introducing
> support for the Zyxel EX3510-B "series," largely motivated by my earlier
> patchset [1] that resolves validation errors in the BCMBCA DTs. If checking the
> DT, please apply that other patchset first. These changes do not depend on the
> other patchset to build correctly or apply cleanly; only to pass validation.
>
> Happy spooky month,
> Sam
>
> [1]: https://lore.kernel.org/linux-devicetree/20241009215046.1449389-1-CFSworks@gmail.com/T/
>
> Changes v1->v2:
> - Rolled-in commit tags from previous version
> - Stylistic change to memory: s/0/0x0
> - Delete `range` property from the `nvmem-cells` node, in order to pass DT
> checks.
>
> COMMITTER NOTE: Email being what it is, the capitalization of my email address
> is apparently getting discarded. If it is important that the author email
> address have identical capitalization to the Signed-off-by, please explain why
> so I can investigate why this is happening and/or get these patches to you in a
> desired format.
>
> Sam Edwards (2):
> dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
> arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B
>
> .../bindings/arm/bcm/brcm,bcmbca.yaml | 1 +
> arch/arm64/boot/dts/broadcom/bcmbca/Makefile | 1 +
> .../broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts | 196 ++++++++++++++++++
> 3 files changed, 198 insertions(+)
> create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
>
> --
> 2.44.2
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb' for 20241009215454.1449508-1-CFSworks@gmail.com:
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
'fis-index-block' is a required property
'partitions-table-offset' is a required property
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm4908-partitions'] is too short
'fixed-partitions' was expected
'sercomm,sc-partitions' was expected
'arm,arm-firmware-suite' was expected
'brcm,bcm947xx-cfe-partitions' was expected
'linksys,ns-partitions' was expected
'qcom,smem-part' was expected
'redboot-fis' was expected
'tplink,safeloader-partitions' was expected
Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
['nvmem-cells'] is too short
'brcm,bcm4908-firmware' was expected
'linksys,ns-firmware' was expected
Unevaluated properties are not allowed ('compatible' was unexpected)
['brcm,bcm4908-firmware'] is too short
from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'nand-ecc-strength', 'partitions' were unexpected)
from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
'fis-index-block' is a required property
'partitions-table-offset' is a required property
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm4908-partitions'] is too short
'fixed-partitions' was expected
'sercomm,sc-partitions' was expected
'arm,arm-firmware-suite' was expected
'brcm,bcm947xx-cfe-partitions' was expected
'linksys,ns-partitions' was expected
'qcom,smem-part' was expected
'redboot-fis' was expected
'tplink,safeloader-partitions' was expected
Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
['nvmem-cells'] is too short
'brcm,bcm4908-firmware' was expected
'linksys,ns-firmware' was expected
Unevaluated properties are not allowed ('compatible' was unexpected)
['brcm,bcm4908-firmware'] is too short
from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
'fis-index-block' is a required property
'partitions-table-offset' is a required property
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm4908-partitions'] is too short
'fixed-partitions' was expected
'sercomm,sc-partitions' was expected
'arm,arm-firmware-suite' was expected
'brcm,bcm947xx-cfe-partitions' was expected
'linksys,ns-partitions' was expected
'qcom,smem-part' was expected
'redboot-fis' was expected
'tplink,safeloader-partitions' was expected
Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
['nvmem-cells'] is too short
'brcm,bcm4908-firmware' was expected
'linksys,ns-firmware' was expected
Unevaluated properties are not allowed ('compatible' was unexpected)
['brcm,bcm4908-firmware'] is too short
from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand@0: partitions: 'oneOf' conditional failed, one must be fixed:
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
'fis-index-block' is a required property
'partitions-table-offset' is a required property
'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm4908-partitions'] is too short
'fixed-partitions' was expected
'sercomm,sc-partitions' was expected
'arm,arm-firmware-suite' was expected
'brcm,bcm947xx-cfe-partitions' was expected
'linksys,ns-partitions' was expected
'qcom,smem-part' was expected
'redboot-fis' was expected
'tplink,safeloader-partitions' was expected
Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
['nvmem-cells'] is too short
'brcm,bcm4908-firmware' was expected
'linksys,ns-firmware' was expected
Unevaluated properties are not allowed ('compatible' was unexpected)
['brcm,bcm4908-firmware'] is too short
from schema $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread