Re: [PATCH v3 05/12] PCI: rockchip-ep: Implement the .map_align() controller operation

kernel test robot
2024-10-10T03:44:47Z

Hi Damien,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus mani-mhi/mhi-next linus/master v6.12-rc2 next-20241009]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/PCI-rockchip-ep-Use-a-macro-to-define-EP-controller-align-feature/20241007-131224
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20241007041218.157516-6-dlemoal%40kernel.org
patch subject: [PATCH v3 05/12] PCI: rockchip-ep: Implement the .map_align() controller operation
config: i386-buildonly-randconfig-003-20241010 (https://download.01.org/0day-ci/archive/20241010/202410101109.J2ej9dSg-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241010/202410101109.J2ej9dSg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410101109.J2ej9dSg-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/pci/controller/pcie-rockchip-ep.c:239:18: warning: declaration of 'struct pci_epc_map' will not be visible outside of this function [-Wvisibility]
239 | struct pci_epc_map *map)
| ^
>> drivers/pci/controller/pcie-rockchip-ep.c:245:10: error: incomplete definition of type 'struct pci_epc_map'
245 | map->pci_addr, map->pci_size);
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:245:25: error: incomplete definition of type 'struct pci_epc_map'
245 | map->pci_addr, map->pci_size);
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:247:5: error: incomplete definition of type 'struct pci_epc_map'
247 | map->map_pci_addr = map->pci_addr & ~((1ULL << num_bits) - 1);
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:247:25: error: incomplete definition of type 'struct pci_epc_map'
247 | map->map_pci_addr = map->pci_addr & ~((1ULL << num_bits) - 1);
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:248:5: error: incomplete definition of type 'struct pci_epc_map'
248 | map->map_ofst = map->pci_addr - map->map_pci_addr;
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:248:21: error: incomplete definition of type 'struct pci_epc_map'
248 | map->map_ofst = map->pci_addr - map->map_pci_addr;
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:248:37: error: incomplete definition of type 'struct pci_epc_map'
248 | map->map_ofst = map->pci_addr - map->map_pci_addr;
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:250:9: error: incomplete definition of type 'struct pci_epc_map'
250 | if (map->map_ofst + map->pci_size > SZ_1M)
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:250:25: error: incomplete definition of type 'struct pci_epc_map'
250 | if (map->map_ofst + map->pci_size > SZ_1M)
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:251:6: error: incomplete definition of type 'struct pci_epc_map'
251 | map->pci_size = SZ_1M - map->map_ofst;
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:251:30: error: incomplete definition of type 'struct pci_epc_map'
251 | map->pci_size = SZ_1M - map->map_ofst;
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:253:5: error: incomplete definition of type 'struct pci_epc_map'
253 | map->map_size = ALIGN(map->map_ofst + map->pci_size,
| ~~~^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:253:27: error: incomplete definition of type 'struct pci_epc_map'
253 | map->map_size = ALIGN(map->map_ofst + map->pci_size,
| ~~~^
include/linux/align.h:8:38: note: expanded from macro 'ALIGN'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^
include/uapi/linux/const.h:48:51: note: expanded from macro '__ALIGN_KERNEL'
48 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^
include/uapi/linux/const.h:49:41: note: expanded from macro '__ALIGN_KERNEL_MASK'
49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
| ^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)
| ^
drivers/pci/controller/pcie-rockchip-ep.c:253:43: error: incomplete definition of type 'struct pci_epc_map'
253 | map->map_size = ALIGN(map->map_ofst + map->pci_size,
| ~~~^
include/linux/align.h:8:38: note: expanded from macro 'ALIGN'
8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
| ^
include/uapi/linux/const.h:48:51: note: expanded from macro '__ALIGN_KERNEL'
48 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (__typeof__(x))(a) - 1)
| ^
include/uapi/linux/const.h:49:41: note: expanded from macro '__ALIGN_KERNEL_MASK'
49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
| ^
drivers/pci/controller/pcie-rockchip-ep.c:239:18: note: forward declaration of 'struct pci_epc_map'
239 | struct pci_epc_map *map)

vim +245 drivers/pci/controller/pcie-rockchip-ep.c

237
238 static int rockchip_pcie_ep_map_align(struct pci_epc *epc, u8 fn, u8 vfn,
> 239 struct pci_epc_map *map)
240 {
241 struct rockchip_pcie_ep *ep = epc_get_drvdata(epc);
242 int num_bits;
243
244 num_bits = rockchip_pcie_ep_ob_atu_num_bits(&ep->rockchip,
> 245 map->pci_addr, map->pci_size);
246
247 map->map_pci_addr = map->pci_addr & ~((1ULL << num_bits) - 1);
248 map->map_ofst = map->pci_addr - map->map_pci_addr;
249
250 if (map->map_ofst + map->pci_size > SZ_1M)
251 map->pci_size = SZ_1M - map->map_ofst;
252
253 map->map_size = ALIGN(map->map_ofst + map->pci_size,
254 ROCKCHIP_PCIE_AT_SIZE_ALIGN);
255
256 return 0;
257 }
258

--
0-DAY CI Kernel Test Service