From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F11E51A303E; Thu, 10 Oct 2024 18:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728584548; cv=none; b=p2GqGn5gegSU+my9ddymXlekjwseQ8Y+KkHz7kArdrziS/3TaxZ5aHepi46J0WTChNeuG7hFLlSLeCfLO1ebHF9GgezdN8LeqSMdcemtJyW2A6DEAgfGEiWmcOPvl9tYxt7neNKC5FT5ZSkhMMx0wNsP56nLUhF2BLyU767AJ5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728584548; c=relaxed/simple; bh=iHHNxPo48eGIoD/CN3nF+gO4PuOB8rnALVXIRbOFEL8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I0t7RBpBZ9ZLQ8n1YPaWi++KPa6IVwdQNXbdAiUzyf3/XX8ey6wwH1qaBbl9p70RDc9WMY1UZfCbV3cBxI2DqKQNPrUqmQa9vkTirvDlyprtlfMJDoDlgNw/N2350M63EItGFxjdFmQrwKQ4DV6kKRoCHdNDoTwwyc8mfj7nXk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q4JL97Li; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q4JL97Li" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3639C4CEC5; Thu, 10 Oct 2024 18:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728584547; bh=iHHNxPo48eGIoD/CN3nF+gO4PuOB8rnALVXIRbOFEL8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q4JL97LikGDNtRlMN7v1YzgtoBXDTbuxbY7QcervbrtMajmzPaTvlw+Bvme9CpgIU ercXsLH5gRgqJT3j87lmM+9uTezE0kL+25wAD1XpCNDykOWVctqqsh3Vto6DI4yBXu D2ent+xbtIk3QQUiTXsAoOTcRWfqTj6rkuI5IQzFxHpBqs6KBG5UjfCsP1qeaXedlL raevMyrYtE20K6UwkYOpQWhIsXqiNhA42gZFm9hV4EwqUfp4anaK7ZnrTrTK2LnF9S E4cDjfXoRbRwEikDTPNQeyeHOkUAXvoIcTK3RLxWUNsWfg7f5+lvDxyLfAV+ZtlwRK oV91oMrOIf/Vw== Date: Thu, 10 Oct 2024 19:22:18 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Julien Stephan , Lars-Peter Clausen , Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , David Lechner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Jonathan Corbet , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley , Jonathan Cameron , linux-doc@vger.kernel.org Subject: Re: [PATCH 2/6] dt-bindings: iio: adc: ad7380: fix ad7380-4 reference supply Message-ID: <20241010192218.12808268@jic23-huawei> In-Reply-To: References: <20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com> <20241007-ad7380-fix-supplies-v1-2-badcf813c9b9@baylibre.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 8 Oct 2024 09:52:50 +0200 Krzysztof Kozlowski wrote: > On Mon, Oct 07, 2024 at 05:45:45PM +0200, Julien Stephan wrote: > > ad7380-4 is the only device from ad738x family that doesn't have an > > internal reference. Moreover its external reference is called REFIN in > > the datasheet while all other use REFIO as an optional external > > reference. If refio-supply is omitted the internal reference is > > used. > > > > Fix the binding by adding refin-supply and makes it required for > > ad7380-4 only. > > Maybe let's just use refio as refin? Reference-IO fits here well. > Otherwise you have two supplies for the same. Whilst it is ugly, the effort this series is going to in order to paper over a naming mismatch makes me agree with Krzysztof. I think adding a comment to the dt-binding would be sensible though as people might fall into this hole. Other than the missing ret =, rest of series looks fine to me Jonathan > > Best regards, > Krzysztof >