From: Bjorn Helgaas <helgaas@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Saravana Kannan <saravanak@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/7] PCI: Constify pci_register_io_range() fwnode_handle
Date: Thu, 10 Oct 2024 17:07:47 -0500 [thread overview]
Message-ID: <20241010220747.GA579765@bhelgaas> (raw)
In-Reply-To: <20241010-dt-const-v1-1-87a51f558425@kernel.org>
On Thu, Oct 10, 2024 at 11:27:14AM -0500, Rob Herring (Arm) wrote:
> pci_register_io_range() does not modify the passed in fwnode_handle, so
> make it const.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> Please ack and I'll take with the rest of the series.
Thank you!
> ---
> drivers/pci/pci.c | 2 +-
> include/linux/pci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 7d85c04fbba2..4b102bd1cfea 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4163,7 +4163,7 @@ EXPORT_SYMBOL(pci_request_regions_exclusive);
> * Record the PCI IO range (expressed as CPU physical address + size).
> * Return a negative value if an error has occurred, zero otherwise
> */
> -int pci_register_io_range(struct fwnode_handle *fwnode, phys_addr_t addr,
> +int pci_register_io_range(const struct fwnode_handle *fwnode, phys_addr_t addr,
> resource_size_t size)
> {
> int ret = 0;
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 573b4c4c2be6..11421ae5c558 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1556,7 +1556,7 @@ int __must_check pci_bus_alloc_resource(struct pci_bus *bus,
> void *alignf_data);
>
>
> -int pci_register_io_range(struct fwnode_handle *fwnode, phys_addr_t addr,
> +int pci_register_io_range(const struct fwnode_handle *fwnode, phys_addr_t addr,
> resource_size_t size);
> unsigned long pci_address_to_pio(phys_addr_t addr);
> phys_addr_t pci_pio_to_address(unsigned long pio);
>
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-10-10 22:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 16:27 [PATCH 0/7] of: Constify DT structs Rob Herring (Arm)
2024-10-10 16:27 ` [PATCH 1/7] PCI: Constify pci_register_io_range() fwnode_handle Rob Herring (Arm)
2024-10-10 22:07 ` Bjorn Helgaas [this message]
2024-10-11 14:58 ` Krzysztof Kozlowski
2024-10-10 16:27 ` [PATCH 2/7] logic_pio: Constify fwnode_handle Rob Herring (Arm)
2024-10-11 14:59 ` Krzysztof Kozlowski
2024-10-11 15:08 ` Rob Herring
2024-10-10 16:27 ` [PATCH 3/7] of: Constify struct device_node function arguments Rob Herring (Arm)
2024-10-11 15:13 ` Krzysztof Kozlowski
2024-10-10 16:27 ` [PATCH 4/7] of: Constify struct property pointers Rob Herring (Arm)
2024-10-11 15:17 ` Krzysztof Kozlowski
2024-10-10 16:27 ` [PATCH 5/7] of: Constify of_changeset_entry function arguments Rob Herring (Arm)
2024-10-11 15:18 ` Krzysztof Kozlowski
2024-10-10 16:27 ` [PATCH 6/7] of: Constify safe_name() kobject arg Rob Herring (Arm)
2024-10-11 15:18 ` Krzysztof Kozlowski
2024-10-10 16:27 ` [PATCH 7/7] of/address: Constify of_busses[] array and pointers Rob Herring (Arm)
2024-10-11 15:20 ` [PATCH 0/7] of: Constify DT structs Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010220747.GA579765@bhelgaas \
--to=helgaas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).