* [PATCH 0/2] media: nxp: imx8-isi: Add i.MX8ULP support
@ 2024-10-11 10:17 guoniu.zhou
2024-10-11 10:17 ` [PATCH 1/2] " guoniu.zhou
2024-10-11 10:17 ` [PATCH 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string guoniu.zhou
0 siblings, 2 replies; 5+ messages in thread
From: guoniu.zhou @ 2024-10-11 10:17 UTC (permalink / raw)
To: linux-media
Cc: laurent.pinchart, jacopo, mchehab, robh, krzk+dt, conor+dt,
shawnguo, s.hauer, kernel, festevam, devicetree, imx,
linux-kernel
From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
This small patch series is to add ISI support for i.MX8ULP.
Guoniu.zhou (2):
media: nxp: imx8-isi: Add i.MX8ULP support
dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string
.../bindings/media/nxp,imx8-isi.yaml | 2 ++
.../platform/nxp/imx8-isi/imx8-isi-core.c | 18 ++++++++++++++++++
.../platform/nxp/imx8-isi/imx8-isi-core.h | 1 +
3 files changed, 21 insertions(+)
base-commit: 67cefecf2a039b9ed0030b9213ceafcd45e6f9e3
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] media: nxp: imx8-isi: Add i.MX8ULP support
2024-10-11 10:17 [PATCH 0/2] media: nxp: imx8-isi: Add i.MX8ULP support guoniu.zhou
@ 2024-10-11 10:17 ` guoniu.zhou
2024-10-11 13:30 ` Laurent Pinchart
2024-10-11 10:17 ` [PATCH 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string guoniu.zhou
1 sibling, 1 reply; 5+ messages in thread
From: guoniu.zhou @ 2024-10-11 10:17 UTC (permalink / raw)
To: linux-media
Cc: laurent.pinchart, jacopo, mchehab, robh, krzk+dt, conor+dt,
shawnguo, s.hauer, kernel, festevam, devicetree, imx,
linux-kernel
From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
Add ISI support for i.MX8ULP.
Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
---
.../platform/nxp/imx8-isi/imx8-isi-core.c | 18 ++++++++++++++++++
.../platform/nxp/imx8-isi/imx8-isi-core.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
index c2013995049c..f5d076d7f50b 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
@@ -279,6 +279,10 @@ static const struct clk_bulk_data mxc_imx8mn_clks[] = {
{ .id = "apb" },
};
+static const struct clk_bulk_data mxc_imx8ulp_clks[] = {
+ { .id = "per" },
+};
+
static const struct mxc_isi_plat_data mxc_imx8mn_data = {
.model = MXC_ISI_IMX8MN,
.num_ports = 1,
@@ -307,6 +311,19 @@ static const struct mxc_isi_plat_data mxc_imx8mp_data = {
.has_36bit_dma = true,
};
+static const struct mxc_isi_plat_data mxc_imx8ulp_data = {
+ .model = MXC_ISI_IMX8ULP,
+ .num_ports = 1,
+ .num_channels = 1,
+ .reg_offset = 0x0,
+ .ier_reg = &mxc_imx8_isi_ier_v2,
+ .set_thd = &mxc_imx8_isi_thd_v1,
+ .clks = mxc_imx8ulp_clks,
+ .num_clks = ARRAY_SIZE(mxc_imx8ulp_clks),
+ .buf_active_reverse = true,
+ .has_36bit_dma = false,
+};
+
static const struct mxc_isi_plat_data mxc_imx93_data = {
.model = MXC_ISI_IMX93,
.num_ports = 1,
@@ -528,6 +545,7 @@ static void mxc_isi_remove(struct platform_device *pdev)
static const struct of_device_id mxc_isi_of_match[] = {
{ .compatible = "fsl,imx8mn-isi", .data = &mxc_imx8mn_data },
{ .compatible = "fsl,imx8mp-isi", .data = &mxc_imx8mp_data },
+ { .compatible = "fsl,imx8ulp-isi", .data = &mxc_imx8ulp_data },
{ .compatible = "fsl,imx93-isi", .data = &mxc_imx93_data },
{ /* sentinel */ },
};
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
index 2810ebe9b5f7..9c7fe9e5f941 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
@@ -158,6 +158,7 @@ struct mxc_gasket_ops {
enum model {
MXC_ISI_IMX8MN,
MXC_ISI_IMX8MP,
+ MXC_ISI_IMX8ULP,
MXC_ISI_IMX93,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string
2024-10-11 10:17 [PATCH 0/2] media: nxp: imx8-isi: Add i.MX8ULP support guoniu.zhou
2024-10-11 10:17 ` [PATCH 1/2] " guoniu.zhou
@ 2024-10-11 10:17 ` guoniu.zhou
1 sibling, 0 replies; 5+ messages in thread
From: guoniu.zhou @ 2024-10-11 10:17 UTC (permalink / raw)
To: linux-media
Cc: laurent.pinchart, jacopo, mchehab, robh, krzk+dt, conor+dt,
shawnguo, s.hauer, kernel, festevam, devicetree, imx,
linux-kernel
From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
Add the compatible string support for i.MX8ULP ISI.
Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
---
Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
index 4d5348d456a1..f43b91984f01 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
@@ -21,6 +21,7 @@ properties:
enum:
- fsl,imx8mn-isi
- fsl,imx8mp-isi
+ - fsl,imx8ulp-isi
- fsl,imx93-isi
reg:
@@ -75,6 +76,7 @@ allOf:
contains:
enum:
- fsl,imx8mn-isi
+ - fsl,imx8ulp-isi
- fsl,imx93-isi
then:
properties:
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] media: nxp: imx8-isi: Add i.MX8ULP support
2024-10-11 10:17 ` [PATCH 1/2] " guoniu.zhou
@ 2024-10-11 13:30 ` Laurent Pinchart
2024-10-12 2:14 ` G.N. Zhou (OSS)
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2024-10-11 13:30 UTC (permalink / raw)
To: guoniu.zhou
Cc: linux-media, jacopo, mchehab, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, devicetree, imx, linux-kernel
Hi Guoniu,
Thank you for the patch.
On Fri, Oct 11, 2024 at 06:17:12PM +0800, guoniu.zhou@oss.nxp.com wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
>
> Add ISI support for i.MX8ULP.
>
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> ---
> .../platform/nxp/imx8-isi/imx8-isi-core.c | 18 ++++++++++++++++++
> .../platform/nxp/imx8-isi/imx8-isi-core.h | 1 +
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index c2013995049c..f5d076d7f50b 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -279,6 +279,10 @@ static const struct clk_bulk_data mxc_imx8mn_clks[] = {
> { .id = "apb" },
> };
>
> +static const struct clk_bulk_data mxc_imx8ulp_clks[] = {
> + { .id = "per" },
This doesn't match the DT bindings. Which one is wrong ?
> +};
> +
> static const struct mxc_isi_plat_data mxc_imx8mn_data = {
> .model = MXC_ISI_IMX8MN,
> .num_ports = 1,
> @@ -307,6 +311,19 @@ static const struct mxc_isi_plat_data mxc_imx8mp_data = {
> .has_36bit_dma = true,
> };
>
> +static const struct mxc_isi_plat_data mxc_imx8ulp_data = {
> + .model = MXC_ISI_IMX8ULP,
> + .num_ports = 1,
> + .num_channels = 1,
> + .reg_offset = 0x0,
> + .ier_reg = &mxc_imx8_isi_ier_v2,
> + .set_thd = &mxc_imx8_isi_thd_v1,
> + .clks = mxc_imx8ulp_clks,
> + .num_clks = ARRAY_SIZE(mxc_imx8ulp_clks),
> + .buf_active_reverse = true,
> + .has_36bit_dma = false,
> +};
> +
> static const struct mxc_isi_plat_data mxc_imx93_data = {
> .model = MXC_ISI_IMX93,
> .num_ports = 1,
> @@ -528,6 +545,7 @@ static void mxc_isi_remove(struct platform_device *pdev)
> static const struct of_device_id mxc_isi_of_match[] = {
> { .compatible = "fsl,imx8mn-isi", .data = &mxc_imx8mn_data },
> { .compatible = "fsl,imx8mp-isi", .data = &mxc_imx8mp_data },
> + { .compatible = "fsl,imx8ulp-isi", .data = &mxc_imx8ulp_data },
> { .compatible = "fsl,imx93-isi", .data = &mxc_imx93_data },
> { /* sentinel */ },
> };
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> index 2810ebe9b5f7..9c7fe9e5f941 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> @@ -158,6 +158,7 @@ struct mxc_gasket_ops {
> enum model {
> MXC_ISI_IMX8MN,
> MXC_ISI_IMX8MP,
> + MXC_ISI_IMX8ULP,
> MXC_ISI_IMX93,
> };
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] media: nxp: imx8-isi: Add i.MX8ULP support
2024-10-11 13:30 ` Laurent Pinchart
@ 2024-10-12 2:14 ` G.N. Zhou (OSS)
0 siblings, 0 replies; 5+ messages in thread
From: G.N. Zhou (OSS) @ 2024-10-12 2:14 UTC (permalink / raw)
To: Laurent Pinchart, G.N. Zhou (OSS)
Cc: linux-media@vger.kernel.org, jacopo@jmondi.org,
mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.d, festevam@gmail.com,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Hi Laurent,
Thanks for your replying.
> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: Friday, October 11, 2024 9:31 PM
> To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>
> Cc: linux-media@vger.kernel.org; jacopo@jmondi.org; mchehab@kernel.org;
> robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.d;
> festevam@gmail.com; devicetree@vger.kernel.org; imx@lists.linux.dev; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] media: nxp: imx8-isi: Add i.MX8ULP support
>
> Hi Guoniu,
>
> Thank you for the patch.
>
> On Fri, Oct 11, 2024 at 06:17:12PM +0800, guoniu.zhou@oss.nxp.com wrote:
> > From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> >
> > Add ISI support for i.MX8ULP.
> >
> > Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> > ---
> > .../platform/nxp/imx8-isi/imx8-isi-core.c | 18 ++++++++++++++++++
> > .../platform/nxp/imx8-isi/imx8-isi-core.h | 1 +
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > index c2013995049c..f5d076d7f50b 100644
> > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> > @@ -279,6 +279,10 @@ static const struct clk_bulk_data
> mxc_imx8mn_clks[] = {
> > { .id = "apb" },
> > };
> >
> > +static const struct clk_bulk_data mxc_imx8ulp_clks[] = {
> > + { .id = "per" },
>
> This doesn't match the DT bindings. Which one is wrong ?
I'm wrong. It should be "axi" since the clocks used here is a
gate clock controller by PCC(Peripheral Clock Controller) and
derived from "LPAV_AXI_CLK". I will update a new version to
correct this.
>
> > +};
> > +
> > static const struct mxc_isi_plat_data mxc_imx8mn_data = {
> > .model = MXC_ISI_IMX8MN,
> > .num_ports = 1,
> > @@ -307,6 +311,19 @@ static const struct mxc_isi_plat_data
> mxc_imx8mp_data = {
> > .has_36bit_dma = true,
> > };
> >
> > +static const struct mxc_isi_plat_data mxc_imx8ulp_data = {
> > + .model = MXC_ISI_IMX8ULP,
> > + .num_ports = 1,
> > + .num_channels = 1,
> > + .reg_offset = 0x0,
> > + .ier_reg = &mxc_imx8_isi_ier_v2,
> > + .set_thd = &mxc_imx8_isi_thd_v1,
> > + .clks = mxc_imx8ulp_clks,
> > + .num_clks = ARRAY_SIZE(mxc_imx8ulp_clks),
> > + .buf_active_reverse = true,
> > + .has_36bit_dma = false,
> > +};
> > +
> > static const struct mxc_isi_plat_data mxc_imx93_data = {
> > .model = MXC_ISI_IMX93,
> > .num_ports = 1,
> > @@ -528,6 +545,7 @@ static void mxc_isi_remove(struct platform_device
> > *pdev) static const struct of_device_id mxc_isi_of_match[] = {
> > { .compatible = "fsl,imx8mn-isi", .data = &mxc_imx8mn_data },
> > { .compatible = "fsl,imx8mp-isi", .data = &mxc_imx8mp_data },
> > + { .compatible = "fsl,imx8ulp-isi", .data = &mxc_imx8ulp_data },
> > { .compatible = "fsl,imx93-isi", .data = &mxc_imx93_data },
> > { /* sentinel */ },
> > };
> > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> > index 2810ebe9b5f7..9c7fe9e5f941 100644
> > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> > @@ -158,6 +158,7 @@ struct mxc_gasket_ops { enum model {
> > MXC_ISI_IMX8MN,
> > MXC_ISI_IMX8MP,
> > + MXC_ISI_IMX8ULP,
> > MXC_ISI_IMX93,
> > };
> >
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-12 2:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-11 10:17 [PATCH 0/2] media: nxp: imx8-isi: Add i.MX8ULP support guoniu.zhou
2024-10-11 10:17 ` [PATCH 1/2] " guoniu.zhou
2024-10-11 13:30 ` Laurent Pinchart
2024-10-12 2:14 ` G.N. Zhou (OSS)
2024-10-11 10:17 ` [PATCH 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string guoniu.zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).