* [PATCH 2/5] dt-bindings: rtc: qcom-pm8xxx: document no-alarm flag
[not found] <20241011152244.31267-1-jonathan@marek.ca>
@ 2024-10-11 15:22 ` Jonathan Marek
2024-10-11 15:22 ` [PATCH 3/5] arm64: dts: qcom: x1e80100-pmics: enable RTC Jonathan Marek
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Jonathan Marek @ 2024-10-11 15:22 UTC (permalink / raw)
To: linux-arm-msm
Cc: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Satya Priya, open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Qualcomm x1e80100 firmware sets the ownership of the RTC alarm to ADSP.
Thus writing to RTC alarm registers and receiving alarm interrupts is not
possible.
Add a no-alarm flag to support RTC on this platform.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
index d274bb7a534b5..210f76a819e90 100644
--- a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
@@ -40,6 +40,11 @@ properties:
description:
Indicates that the setting of RTC time is allowed by the host CPU.
+ no-alarm:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ Indicates that RTC alarm is not owned by HLOS (Linux).
+
nvmem-cells:
items:
- description:
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/5] arm64: dts: qcom: x1e80100-pmics: enable RTC
[not found] <20241011152244.31267-1-jonathan@marek.ca>
2024-10-11 15:22 ` [PATCH 2/5] dt-bindings: rtc: qcom-pm8xxx: document no-alarm flag Jonathan Marek
@ 2024-10-11 15:22 ` Jonathan Marek
2024-10-11 15:22 ` [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: add rtc offset to set rtc time Jonathan Marek
2024-10-11 15:22 ` [PATCH 5/5] arm64: dts: qcom: x1e78100-t14s: " Jonathan Marek
3 siblings, 0 replies; 4+ messages in thread
From: Jonathan Marek @ 2024-10-11 15:22 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Only access to RTC alarm is blocked.
Enable RTC access by setting the no-alarm flag.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
index 5b54ee79f048e..304a98d60472e 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
@@ -220,11 +220,9 @@ pon_resin: resin {
pmk8550_rtc: rtc@6100 {
compatible = "qcom,pmk8350-rtc";
- reg = <0x6100>, <0x6200>;
- reg-names = "rtc", "alarm";
- interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
- /* Not yet sure what blocks access */
- status = "reserved";
+ reg = <0x6100>;
+ reg-names = "rtc";
+ no-alarm; /* alarm owned by ADSP */
};
pmk8550_sdam_2: nvram@7100 {
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: add rtc offset to set rtc time
[not found] <20241011152244.31267-1-jonathan@marek.ca>
2024-10-11 15:22 ` [PATCH 2/5] dt-bindings: rtc: qcom-pm8xxx: document no-alarm flag Jonathan Marek
2024-10-11 15:22 ` [PATCH 3/5] arm64: dts: qcom: x1e80100-pmics: enable RTC Jonathan Marek
@ 2024-10-11 15:22 ` Jonathan Marek
2024-10-11 15:22 ` [PATCH 5/5] arm64: dts: qcom: x1e78100-t14s: " Jonathan Marek
3 siblings, 0 replies; 4+ messages in thread
From: Jonathan Marek @ 2024-10-11 15:22 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
See commit e67b45582c5e for explanation.
Note: the 0xbc offset is arbitrary, it just needs to not be already in use.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index 53e76b3f0c831..c8fac0f2701b9 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -1224,6 +1224,17 @@ edp_bl_en: edp-bl-en-state {
};
};
+&pmk8550_rtc {
+ nvmem-cells = <&rtc_offset>;
+ nvmem-cell-names = "offset";
+};
+
+&pmk8550_sdam_2 {
+ rtc_offset: rtc-offset@bc {
+ reg = <0xbc 0x4>;
+ };
+};
+
&qupv3_0 {
status = "okay";
};
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 5/5] arm64: dts: qcom: x1e78100-t14s: add rtc offset to set rtc time
[not found] <20241011152244.31267-1-jonathan@marek.ca>
` (2 preceding siblings ...)
2024-10-11 15:22 ` [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: add rtc offset to set rtc time Jonathan Marek
@ 2024-10-11 15:22 ` Jonathan Marek
3 siblings, 0 replies; 4+ messages in thread
From: Jonathan Marek @ 2024-10-11 15:22 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
See commit e67b45582c5e for explanation.
Note: the 0xbc offset is arbitrary, it just needs to not be already in use.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
.../boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
index 8cd08c3a93382..f406c3a63d6a1 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
@@ -897,6 +897,17 @@ edp_bl_en: edp-bl-en-state {
};
};
+&pmk8550_rtc {
+ nvmem-cells = <&rtc_offset>;
+ nvmem-cell-names = "offset";
+};
+
+&pmk8550_sdam_2 {
+ rtc_offset: rtc-offset@bc {
+ reg = <0xbc 0x4>;
+ };
+};
+
&qupv3_0 {
status = "okay";
};
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread