* [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports
@ 2024-10-11 15:27 Jonathan Marek
2024-10-11 15:27 ` [PATCH 2/2] arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports Jonathan Marek
2024-10-11 21:37 ` [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Marek @ 2024-10-11 15:27 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The 3 USB ports on x1e80100-crd are OTG-capable, change dr_mode and add
usb-role-switch flag to enable OTG.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index 6dfc85eda3540..53e76b3f0c831 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -1558,7 +1558,8 @@ &usb_1_ss0 {
};
&usb_1_ss0_dwc3 {
- dr_mode = "host";
+ dr_mode = "otg";
+ usb-role-switch;
};
&usb_1_ss0_dwc3_hs {
@@ -1590,7 +1591,8 @@ &usb_1_ss1 {
};
&usb_1_ss1_dwc3 {
- dr_mode = "host";
+ dr_mode = "otg";
+ usb-role-switch;
};
&usb_1_ss1_dwc3_hs {
@@ -1622,7 +1624,8 @@ &usb_1_ss2 {
};
&usb_1_ss2_dwc3 {
- dr_mode = "host";
+ dr_mode = "otg";
+ usb-role-switch;
};
&usb_1_ss2_dwc3_hs {
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports
2024-10-11 15:27 [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports Jonathan Marek
@ 2024-10-11 15:27 ` Jonathan Marek
2024-10-11 21:37 ` [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Marek @ 2024-10-11 15:27 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The 2 USB-C ports on x1e78100-t14s are OTG-capable, change dr_mode and add
usb-role-switch flag to enable OTG.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
index 08ec2419f95fc..8579c45dcb0a4 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
@@ -1033,7 +1033,8 @@ &usb_1_ss0 {
};
&usb_1_ss0_dwc3 {
- dr_mode = "host";
+ dr_mode = "otg";
+ usb-role-switch;
};
&usb_1_ss0_dwc3_hs {
@@ -1065,7 +1066,8 @@ &usb_1_ss1 {
};
&usb_1_ss1_dwc3 {
- dr_mode = "host";
+ dr_mode = "otg";
+ usb-role-switch;
};
&usb_1_ss1_dwc3_hs {
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports
2024-10-11 15:27 [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports Jonathan Marek
2024-10-11 15:27 ` [PATCH 2/2] arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports Jonathan Marek
@ 2024-10-11 21:37 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-10-11 21:37 UTC (permalink / raw)
To: Jonathan Marek
Cc: linux-arm-msm, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Fri, Oct 11, 2024 at 11:27:11AM -0400, Jonathan Marek wrote:
> The 3 USB ports on x1e80100-crd are OTG-capable, change dr_mode and add
> usb-role-switch flag to enable OTG.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 6dfc85eda3540..53e76b3f0c831 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -1558,7 +1558,8 @@ &usb_1_ss0 {
> };
>
> &usb_1_ss0_dwc3 {
> - dr_mode = "host";
> + dr_mode = "otg";
There should be no need to specify "otg", it is a default if I remember
correctly.
> + usb-role-switch;
Please move usb-role-switch to the x1e80100.dtsi instead.
> };
>
> &usb_1_ss0_dwc3_hs {
> @@ -1590,7 +1591,8 @@ &usb_1_ss1 {
> };
>
> &usb_1_ss1_dwc3 {
> - dr_mode = "host";
> + dr_mode = "otg";
> + usb-role-switch;
> };
>
> &usb_1_ss1_dwc3_hs {
> @@ -1622,7 +1624,8 @@ &usb_1_ss2 {
> };
>
> &usb_1_ss2_dwc3 {
> - dr_mode = "host";
> + dr_mode = "otg";
> + usb-role-switch;
> };
>
> &usb_1_ss2_dwc3_hs {
> --
> 2.45.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-11 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-11 15:27 [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports Jonathan Marek
2024-10-11 15:27 ` [PATCH 2/2] arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports Jonathan Marek
2024-10-11 21:37 ` [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).