[PATCH 0/2] net: phy: mdio-bcm-unimac: Add BCM6846 variant

[PATCH 0/2] net: phy: mdio-bcm-unimac: Add BCM6846 variant

[Linus Walleij]

As pointed out by Florian:
https://lore.kernel.org/linux-devicetree/b542b2e8-115c-4234-a464-e73aa6bece5c@broadcom.com/

The BCM6846 has a few extra registers and cannot reuse the
compatible string from other variants of the Unimac
MDIO block: we need to be able to tell them apart.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Linus Walleij (2):
      dt-bindings: net: brcm,unimac-mdio: Add bcm6846-mdio
      net: phy: mdio-bcm-unimac: Add BCM6846 support

 Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 1 +
 drivers/net/mdio/mdio-bcm-unimac.c                          | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20241012-bcm6846-mdio-116b12d4ed11

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>

[PATCH 1/2] dt-bindings: net: brcm,unimac-mdio: Add bcm6846-mdio

[Linus Walleij]

The MDIO block in the BCM6846 is not identical to any of the
previous versions, but has extended registers not present in
the other variants. For this reason we need to use a new
compatible especially for this SoC.

Suggested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/linux-devicetree/b542b2e8-115c-4234-a464-e73aa6bece5c@broadcom.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
index 23dfe0838dca..63bee5b542f5 100644
--- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
@@ -26,6 +26,7 @@ properties:
       - brcm,asp-v2.1-mdio
       - brcm,asp-v2.2-mdio
       - brcm,unimac-mdio
+      - brcm,bcm6846-mdio
 
   reg:
     minItems: 1

-- 
2.46.2

[PATCH 2/2] net: phy: mdio-bcm-unimac: Add BCM6846 support

[Linus Walleij]

Add Unimac mdio compatible string for the special BCM6846
variant.

This variant has a few extra registers compared to other
versions.

Suggested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/linux-devicetree/b542b2e8-115c-4234-a464-e73aa6bece5c@broadcom.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/net/mdio/mdio-bcm-unimac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
index f40eb50bb978..b7bc70586ee0 100644
--- a/drivers/net/mdio/mdio-bcm-unimac.c
+++ b/drivers/net/mdio/mdio-bcm-unimac.c
@@ -337,6 +337,7 @@ static const struct of_device_id unimac_mdio_ids[] = {
 	{ .compatible = "brcm,asp-v2.2-mdio", },
 	{ .compatible = "brcm,asp-v2.1-mdio", },
 	{ .compatible = "brcm,asp-v2.0-mdio", },
+	{ .compatible = "brcm,bcm6846-mdio", },
 	{ .compatible = "brcm,genet-mdio-v5", },
 	{ .compatible = "brcm,genet-mdio-v4", },
 	{ .compatible = "brcm,genet-mdio-v3", },

-- 
2.46.2

Re: [PATCH 1/2] dt-bindings: net: brcm,unimac-mdio: Add bcm6846-mdio

[Rob Herring (Arm)]

On Sat, 12 Oct 2024 22:35:22 +0200, Linus Walleij wrote:
> The MDIO block in the BCM6846 is not identical to any of the
> previous versions, but has extended registers not present in
> the other variants. For this reason we need to use a new
> compatible especially for this SoC.
> 
> Suggested-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Link: https://lore.kernel.org/linux-devicetree/b542b2e8-115c-4234-a464-e73aa6bece5c@broadcom.com/
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 0/2] net: phy: mdio-bcm-unimac: Add BCM6846 variant

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 12 Oct 2024 22:35:21 +0200 you wrote:
> As pointed out by Florian:
> https://lore.kernel.org/linux-devicetree/b542b2e8-115c-4234-a464-e73aa6bece5c@broadcom.com/
> 
> The BCM6846 has a few extra registers and cannot reuse the
> compatible string from other variants of the Unimac
> MDIO block: we need to be able to tell them apart.
> 
> [...]

Here is the summary with links:
  - [1/2] dt-bindings: net: brcm,unimac-mdio: Add bcm6846-mdio
    https://git.kernel.org/netdev/net/c/6ed97afd75cc
  - [2/2] net: phy: mdio-bcm-unimac: Add BCM6846 support
    https://git.kernel.org/netdev/net/c/906b77ca91c7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html