public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Nuno Sa <nuno.sa@analog.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, dletchner@baylibre.com,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v5 04/10] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant
Date: Sat, 12 Oct 2024 14:49:50 +0100	[thread overview]
Message-ID: <20241012144950.435815b4@jic23-huawei> (raw)
In-Reply-To: <20241008-wip-bl-ad3552r-axi-v0-iio-testing-v5-4-3d410944a63d@baylibre.com>

On Tue, 08 Oct 2024 17:43:36 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:

> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Add a new compatible and related bindigns for the fpga-based
> "ad3552r" AXI IP core, a variant of the generic AXI DAC IP.
> 
> The AXI "ad3552r" IP is a very similar HDL (fpga) variant of the
> generic AXI "DAC" IP, intended to control ad3552r and similar chips,
> mainly to reach high speed transfer rates using a QSPI DDR
> (dobule-data-rate) interface.
> 
> The ad3552r device is defined as a child of the AXI DAC, that in
> this case is acting as an SPI controller.
> 
Hi Angelo,

If this goes to a v6, I'd suggest adding a very brief statement that
#io-backend is present because it is possible (in theory anyway) to
use a separate controller for the control path than that used for the
datapath. 

So a one line summary of that long discussion from an earlier version!
 
Otherwise this LGTM.

Thanks,

Jonathan



  parent reply	other threads:[~2024-10-12 13:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 15:43 [PATCH v5 00/10] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 01/10] iio: dac: adi-axi-dac: fix wrong register bitfield Angelo Dureghello
2024-10-12 13:45   ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names Angelo Dureghello
2024-10-10 12:59   ` Nuno Sá
2024-10-10 17:52     ` Angelo Dureghello
2024-10-11  6:47       ` Nuno Sá
2024-10-12 13:50         ` Jonathan Cameron
2024-10-12 13:46   ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 03/10] dt-bindings: iio: dac: ad3552r: add iio backend support Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 04/10] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant Angelo Dureghello
2024-10-08 17:22   ` Rob Herring (Arm)
2024-10-12 13:43     ` Jonathan Cameron
2024-10-12 13:49   ` Jonathan Cameron [this message]
2024-10-08 15:43 ` [PATCH v5 05/10] iio: backend: extend features Angelo Dureghello
2024-10-10 13:06   ` Nuno Sá
2024-10-08 15:43 ` [PATCH v5 06/10] iio: dac: adi-axi-dac: " Angelo Dureghello
2024-10-10 13:20   ` Nuno Sá
2024-10-11  8:06     ` Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 07/10] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 08/10] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 09/10] iio: dac: ad3552r: add high-speed platform driver Angelo Dureghello
2024-10-12 14:07   ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 10/10] iio: dac: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-10-10 13:51   ` Nuno Sá
2024-10-11 12:31   ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241012144950.435815b4@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=adureghello@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dletchner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox