From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B97A81991BF; Sat, 12 Oct 2024 15:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728745849; cv=none; b=nFXkFYPLhO6quBiCQ7hTRBG9e2y/qXIgcC43EbADaqK0tUdHFdn0knQJLoicHWnU7WczZ8uZnFPHKxI+2NWG3fpG7eCdIAPe1f/oClA/Oh3plBpl4oTbI65CZUXgXLYJBfpc0P6NYKTestecj13JeJzNAhi+mF2S1AgWh4ZdjXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728745849; c=relaxed/simple; bh=gcNbMJ4Gd2izwSIIWqm/hjsuE/w9FW79EmcBGXtchag=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Mx/dlTE9a0RMjuwxk4HvzLY2difjyMB+HBKc5I/tG9uym5BdPkUcW+n4kYh+BVDUwkzId5u4MmTTHmsZCrgEYPkl3jalWcl0p/jx4LMz/XRmOuffdyXuFypaniwIBMTxw5wL21ly/754Cowtcm1/UUvqTewabiJxGwgZwUge9BM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZN6wHfa1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZN6wHfa1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 404D5C4CEC6; Sat, 12 Oct 2024 15:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728745849; bh=gcNbMJ4Gd2izwSIIWqm/hjsuE/w9FW79EmcBGXtchag=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZN6wHfa1x4FE1+M18/tYMEzEdHz+XJMkbPjTXduySTpAaayHu1xN0+TJ+C0NXGo5q DP2WCINjN2zH7H1Qbxpv76tvI6j5Z8F/xrqz195Go4RJXWj/59fvkXM2u78gXUnWoU jqCiFpQZyyqF+QmnJMjn4qdYem73sF/b0ZK/JbemLVJuk47jeeN7L/sF+5N5QQrL+d 3OAj0LuZzYDGziYpF22Gi1Wj68LmM8LR3yOnRuOzDPMh2F9FCV6CFUOwUbAuwGQYPA Jgy9pSO+MEybHuSiP6vX4coVcICm6C3ZHdC1vWmabPuzw9nbgFB7JpY4S22E4EhWAl Hekgag8vSiDIw== Date: Sat, 12 Oct 2024 16:10:40 +0100 From: Jonathan Cameron To: Emil Gedenryd Cc: "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "robh@kernel.org" , "linux-kernel@vger.kernel.org" , "dannenberg@ti.com" , "krzk+dt@kernel.org" , "lars@metafoo.de" , "conor+dt@kernel.org" , Kernel Subject: Re: [PATCH v4 2/2] iio: light: opt3001: add support for TI's opt3002 light sensor Message-ID: <20241012161040.1506a7a4@jic23-huawei> In-Reply-To: References: <20241003-add_opt3002-v4-0-c550dc4591b4@axis.com> <20241003-add_opt3002-v4-2-c550dc4591b4@axis.com> <20241006141624.3fa5bf34@jic23-huawei> <20241010184742.1747bfe2@jic23-huawei> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 11 Oct 2024 07:12:05 +0000 Emil Gedenryd wrote: > On Thu, 2024-10-10 at 18:47 +0100, Jonathan Cameron wrote: > > On Mon, 7 Oct 2024 07:19:06 +0000 > > Emil Gedenryd wrote: > > =20 > > > On Sun, 2024-10-06 at 14:16 +0100, Jonathan Cameron wrote: =20 > > > > On Thu, 3 Oct 2024 14:22:17 +0200 > > > > Emil Gedenryd wrote: =20 > > > > >=20 > > > > > +struct opt3001_chip_info { > > > > > + const struct iio_chan_spec (*channels)[2]; > > > > > + enum iio_chan_type chan_type; > > > > > + int num_channels; > > > > > + > > > > > + const struct opt3001_scale (*scales)[12]; =20 > > > > This doesn't compile for me as one of the two options only > > > > has 11 entries. You could either force them to be 12 > > > > entries each or use a pointer without the size and > > > > add a num_scales entry in here. > > > >=20 > > > > Jonathan =20 > > >=20 > > > Hi Jonathan, > > >=20 > > > Are you building on top of the patch that was accepted in earlier ver= sions of this > > > patch set? That patch adds the twelfth missing scale value for the op= t3001. > > > See:=C2=A0https://lore.kernel.org/all/20240916-add_opt3002-v3-1-984b1= 90cd68c@axis.com/ > > >=20 > > > Should I have added some tag to highlight the dependency for this ver= sion of the > > > patch set? =20 > > Ah. Yes, I was half asleep. > > They are going via different branches (slow and fast) so I'll have to > > sit on this series until after that fix is in the upstream for the togr= eg > > branch of iio.git. > >=20 > > If I seem to have lost it after that is the case feel free to give me a= poke. > >=20 > > Jonathan > > =20 > Hi, >=20 > No worries. Just to clarify, do you mean sit on it as that you will conti= nue reviewing > the code after the fix is in upstream, or should I consider this patch to= be approved? Assuming not other review comes in, I consider this ready to go. >=20 > Also, do you have an approximation of what time frame we're talking about? 2 weeks most likely. I've just sent Greg KH a pull request with the fix in it. He will hopefully pick that up and then send a pull request on to Linus. Then we wait for the next rc after that at which point Greg will probably pull it into char-misc= -next or I can always merge it into my togreg branch once it is in a release candida= te of Linus' tree. In parallel with that I'll probably do a pull request for what is already i= n the togreg tree to get a lot of stuff in char-misc-next for the next cycle. Tha= t makes the history a little cleaner as I can fast forward my tree and end up with whatever is in char-misc-next (hopefully including this). Anyhow, a bit of tree juggling for me, but we have plenty of time as rc3 wi= ll probably be out tomorrow and it normally goes to rc7 at one rc a week Thanks, Jonathan > Best Regards, > Emil=20 >=20