回复: [v3] riscv: dts: starfive: jh7110: Add camera subsystem nodes

回复: [v3] riscv: dts: starfive: jh7110: Add camera subsystem nodes

[Changhuang Liang]

Hi, Aurelien

> 
> Hi,
> 
> On 2024-02-18 19:27, Changhuang Liang wrote:
> > Add camera subsystem nodes for the StarFive JH7110 SoC. They contain
> > the dphy-rx, csi2rx, camss nodes.
> >
> > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> > ---
> >  .../jh7110-starfive-visionfive-2.dtsi         | 49 ++++++++++++++
> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      | 67
> +++++++++++++++++++
> >  2 files changed, 116 insertions(+)
> 
> We have been asked to enable CONFIG_VIDEO_STARFIVE_CAMSS in the
> Debian kernel, which from my understanding and given the device tree shown
> below also requires enabling CONFIG_VIDEO_CADENCE_CSI2RX. That said
> doing so triggers the following error in dmesg:
> 
> [   25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rx
> failed with error -22
> 
> From a quick look it seems there is something in the port@0 csi2rx entry. Do
> you happen to know what is wrong?
> 

You need to add your sensor node. You can refer to this patch:
https://patchwork.kernel.org/project/linux-riscv/patch/20240119100639.84029-3-changhuang.liang@starfivetech.com/

We suggest that using the imx219

> Thanks
> Aurelien
> 
> > diff --git
> > a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > index b89e9791efa7..737ee97a3577 100644
> > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > @@ -125,6 +125,55 @@ &tdm_ext {
> >  	clock-frequency = <49152000>;
> >  };
> >
> > +&camss {
> > +	assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
> > +			  <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>;
> > +	assigned-clock-rates = <49500000>, <198000000>;
> > +	status = "okay";
> > +
> > +	ports {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> > +		};
> > +
> > +		port@1 {
> > +			reg = <1>;
> > +
> > +			camss_from_csi2rx: endpoint {
> > +				remote-endpoint = <&csi2rx_to_camss>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&csi2rx {
> > +	assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>;
> > +	assigned-clock-rates = <297000000>;
> > +	status = "okay";
> > +
> > +	ports {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> > +
> > +			/* remote MIPI sensor endpoint */
> > +		};
> > +
> > +		port@1 {
> > +			reg = <1>;
> > +
> > +			csi2rx_to_camss: endpoint {
> > +				remote-endpoint = <&camss_from_csi2rx>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> >  &gmac0 {
> >  	phy-handle = <&phy0>;
> >  	phy-mode = "rgmii-id";
> 
> 
> --
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                     http://aurel32.net

Thanks, 
changhuang

Re: 回复: [v3] riscv: dts: starfive: jh7110: Add camera subsystem nodes

[Aurelien Jarno]

Hi,

On 2024-10-14 01:08, Changhuang Liang wrote:
> Hi, Aurelien
> 
> > 
> > Hi,
> > 
> > On 2024-02-18 19:27, Changhuang Liang wrote:
> > > Add camera subsystem nodes for the StarFive JH7110 SoC. They contain
> > > the dphy-rx, csi2rx, camss nodes.
> > >
> > > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> > > ---
> > >  .../jh7110-starfive-visionfive-2.dtsi         | 49 ++++++++++++++
> > >  arch/riscv/boot/dts/starfive/jh7110.dtsi      | 67
> > +++++++++++++++++++
> > >  2 files changed, 116 insertions(+)
> > 
> > We have been asked to enable CONFIG_VIDEO_STARFIVE_CAMSS in the
> > Debian kernel, which from my understanding and given the device tree shown
> > below also requires enabling CONFIG_VIDEO_CADENCE_CSI2RX. That said
> > doing so triggers the following error in dmesg:
> > 
> > [   25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rx
> > failed with error -22
> > 
> > From a quick look it seems there is something in the port@0 csi2rx entry. Do
> > you happen to know what is wrong?
> > 
> 
> You need to add your sensor node. You can refer to this patch:
> https://patchwork.kernel.org/project/linux-riscv/patch/20240119100639.84029-3-changhuang.liang@starfivetech.com/
> 
> We suggest that using the imx219

Thanks for your answer. I do not have any sensor attached, the goal is
to build a generic kernel, and people can use overlays or patch their
device tree to add support for additional devices.

In that regard, I have the impression that csi2rx device (and maybe the
camss device?) should not be marked as enabled in the default device
tree. I think they could be enabled by users as part of the change need
to add the sensor node.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

Re: 回复: [v3] riscv: dts: starfive: jh7110: Add camera subsystem nodes

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

On Mon, Oct 14, 2024 at 10:27:41PM +0200, Aurelien Jarno wrote:
> Hi,
> 
> On 2024-10-14 01:08, Changhuang Liang wrote:
> > Hi, Aurelien
> > 
> > > 
> > > Hi,
> > > 
> > > On 2024-02-18 19:27, Changhuang Liang wrote:
> > > > Add camera subsystem nodes for the StarFive JH7110 SoC. They contain
> > > > the dphy-rx, csi2rx, camss nodes.
> > > >
> > > > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> > > > ---
> > > >  .../jh7110-starfive-visionfive-2.dtsi         | 49 ++++++++++++++
> > > >  arch/riscv/boot/dts/starfive/jh7110.dtsi      | 67
> > > +++++++++++++++++++
> > > >  2 files changed, 116 insertions(+)
> > > 
> > > We have been asked to enable CONFIG_VIDEO_STARFIVE_CAMSS in the
> > > Debian kernel, which from my understanding and given the device tree shown
> > > below also requires enabling CONFIG_VIDEO_CADENCE_CSI2RX. That said
> > > doing so triggers the following error in dmesg:
> > > 
> > > [   25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rx
> > > failed with error -22
> > > 
> > > From a quick look it seems there is something in the port@0 csi2rx entry. Do
> > > you happen to know what is wrong?
> > > 
> > 
> > You need to add your sensor node. You can refer to this patch:
> > https://patchwork.kernel.org/project/linux-riscv/patch/20240119100639.84029-3-changhuang.liang@starfivetech.com/
> > 
> > We suggest that using the imx219
> 
> Thanks for your answer. I do not have any sensor attached, the goal is
> to build a generic kernel, and people can use overlays or patch their
> device tree to add support for additional devices.
> 
> In that regard, I have the impression that csi2rx device (and maybe the
> camss device?) should not be marked as enabled in the default device
> tree. I think they could be enabled by users as part of the change need
> to add the sensor node.

Yeah, that's probably what should've been done when the imx219 node was
removed. Feel free to send a patch with a Fixes: tag for that removal
and a cc: stable on it - otherwise I'll send one out tomorrow or w/e.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]