From: Rob Herring <robh@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: linux-iio@vger.kernel.org,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dlechner@baylibre.com, "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v6 2/8] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant
Date: Mon, 14 Oct 2024 08:38:23 -0500 [thread overview]
Message-ID: <20241014133823.GA1018400-robh@kernel.org> (raw)
In-Reply-To: <172890486251.793259.16216468875581353928.robh@kernel.org>
On Mon, Oct 14, 2024 at 06:21:02AM -0500, Rob Herring (Arm) wrote:
>
> On Mon, 14 Oct 2024 12:08:08 +0200, Angelo Dureghello wrote:
> > From: Angelo Dureghello <adureghello@baylibre.com>
> >
> > Add a new compatible and related bindigns for the fpga-based
> > "ad3552r" AXI IP core, a variant of the generic AXI DAC IP.
> >
> > The AXI "ad3552r" IP is a very similar HDL (fpga) variant of the
> > generic AXI "DAC" IP, intended to control ad3552r and similar chips,
> > mainly to reach high speed transfer rates using a QSPI DDR
> > (dobule-data-rate) interface.
> >
> > The ad3552r device is defined as a child of the AXI DAC, that in
> > this case is acting as an SPI controller.
> >
> > Note, #io-backend is present because it is possible (in theory anyway)
> > to use a separate controller for the control path than that used
> > for the datapath.
> >
> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > ---
> > .../devicetree/bindings/iio/dac/adi,axi-dac.yaml | 56 ++++++++++++++++++++--
> > 1 file changed, 53 insertions(+), 3 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.example.dtb: dac@0: spi-max-frequency: 66000000 is greater than the maximum of 30000000
> from schema $id: http://devicetree.org/schemas/iio/dac/adi,ad3552r.yaml#
This is at least the third time this issue has been reported. Don't send
more versions until you fix it.
Rob
next prev parent reply other threads:[~2024-10-14 13:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 10:08 [PATCH v6 0/8] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-10-14 10:08 ` [PATCH v6 1/8] dt-bindings: iio: dac: ad3552r: add iio backend support Angelo Dureghello
2024-10-14 10:08 ` [PATCH v6 2/8] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant Angelo Dureghello
2024-10-14 11:21 ` Rob Herring (Arm)
2024-10-14 13:38 ` Rob Herring [this message]
2024-10-14 14:04 ` Angelo Dureghello
2024-10-14 19:20 ` Jonathan Cameron
2024-10-14 19:24 ` Angelo Dureghello
2024-10-14 21:13 ` David Lechner
2024-10-15 7:44 ` Angelo Dureghello
2024-10-15 14:40 ` David Lechner
2024-10-15 14:51 ` Nuno Sá
2024-10-15 18:19 ` Angelo Dureghello
2024-10-14 10:08 ` [PATCH v6 3/8] iio: backend: extend features Angelo Dureghello
2024-10-14 10:08 ` [PATCH v6 4/8] iio: dac: adi-axi-dac: " Angelo Dureghello
2024-10-14 21:14 ` David Lechner
2024-10-15 6:30 ` Nuno Sá
2024-10-15 8:57 ` Angelo Dureghello
2024-10-15 11:10 ` Nuno Sá
2024-10-19 15:08 ` Jonathan Cameron
2024-10-14 10:08 ` [PATCH v6 5/8] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-10-14 21:14 ` David Lechner
2024-10-15 6:17 ` Nuno Sá
2024-10-15 10:19 ` Angelo Dureghello
2024-10-14 10:08 ` [PATCH v6 6/8] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-10-19 15:15 ` Jonathan Cameron
2024-10-14 10:08 ` [PATCH v6 7/8] iio: dac: ad3552r: add high-speed platform driver Angelo Dureghello
2024-10-14 21:15 ` David Lechner
2024-10-15 6:37 ` Nuno Sá
2024-10-15 14:38 ` David Lechner
2024-10-15 15:00 ` Nuno Sá
2024-10-15 15:23 ` David Lechner
2024-10-16 7:50 ` Nuno Sá
2024-10-19 15:18 ` Jonathan Cameron
2024-10-16 8:35 ` Angelo Dureghello
2024-10-15 7:15 ` Nuno Sá
2024-10-15 14:48 ` David Lechner
2024-10-16 11:54 ` Nuno Sá
2024-10-17 7:27 ` Angelo Dureghello
2024-10-19 15:24 ` Jonathan Cameron
2024-10-14 10:08 ` [PATCH v6 8/8] iio: dac: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-10-14 21:16 ` David Lechner
2024-10-15 6:11 ` Nuno Sá
2024-10-17 8:32 ` Angelo Dureghello
2024-10-17 15:13 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014133823.GA1018400-robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).