* [PATCH] arm64: dts: qcom: Drop undocumented domain "idle-state-name"
@ 2024-10-14 16:16 Rob Herring (Arm)
2024-10-16 15:32 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-10-14 16:16 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
"idle-state-name" is not a valid property for "domain-idle-state"
binding, so drop it.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Alternatively, the property could be added to the binding. In that case,
the 2 idle state bindings should be refactored with the common
properties factored out. Since no one seems to have cared despite
reported warnings on every new board of these platforms, I don't either
and went with the simple change.
arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 --
2 files changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index b5ebf8980325..dec25a0d9057 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -357,7 +357,6 @@ BIG_CPU_SLEEP_1: cpu-sleep-1-1 {
domain_idle_states: domain-idle-states {
CLUSTER_SLEEP_PC: cluster-sleep-0 {
compatible = "domain-idle-state";
- idle-state-name = "cluster-l3-power-collapse";
arm,psci-suspend-param = <0x41000044>;
entry-latency-us = <2752>;
exit-latency-us = <3048>;
@@ -366,7 +365,6 @@ CLUSTER_SLEEP_PC: cluster-sleep-0 {
CLUSTER_SLEEP_CX_RET: cluster-sleep-1 {
compatible = "domain-idle-state";
- idle-state-name = "cluster-cx-retention";
arm,psci-suspend-param = <0x41001244>;
entry-latency-us = <3638>;
exit-latency-us = <4562>;
@@ -375,7 +373,6 @@ CLUSTER_SLEEP_CX_RET: cluster-sleep-1 {
CLUSTER_AOSS_SLEEP: cluster-sleep-2 {
compatible = "domain-idle-state";
- idle-state-name = "cluster-power-down";
arm,psci-suspend-param = <0x4100b244>;
entry-latency-us = <3263>;
exit-latency-us = <6562>;
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index a36076e3c56b..847d6bc39edd 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -287,7 +287,6 @@ CLUSTER_C4: cpu-sleep-0 {
domain-idle-states {
CLUSTER_CL4: cluster-sleep-0 {
compatible = "domain-idle-state";
- idle-state-name = "l2-ret";
arm,psci-suspend-param = <0x01000044>;
entry-latency-us = <350>;
exit-latency-us = <500>;
@@ -296,7 +295,6 @@ CLUSTER_CL4: cluster-sleep-0 {
CLUSTER_CL5: cluster-sleep-1 {
compatible = "domain-idle-state";
- idle-state-name = "ret-pll-off";
arm,psci-suspend-param = <0x01000054>;
entry-latency-us = <2200>;
exit-latency-us = <2500>;
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: Drop undocumented domain "idle-state-name"
2024-10-14 16:16 [PATCH] arm64: dts: qcom: Drop undocumented domain "idle-state-name" Rob Herring (Arm)
@ 2024-10-16 15:32 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2024-10-16 15:32 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Konrad Dybcio, Krzysztof Kozlowski,
Conor Dooley, Rob Herring (Arm)
Cc: linux-arm-msm, devicetree, linux-kernel
On Mon, 14 Oct 2024 11:16:32 -0500, Rob Herring (Arm) wrote:
> "idle-state-name" is not a valid property for "domain-idle-state"
> binding, so drop it.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: Drop undocumented domain "idle-state-name"
commit: 422f2d418186e3779957a8e4aee7f243ae4cd45e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-16 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 16:16 [PATCH] arm64: dts: qcom: Drop undocumented domain "idle-state-name" Rob Herring (Arm)
2024-10-16 15:32 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).