[PATCH 1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties

[PATCH 1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties

[Macpaul Lin]

Add 'ports' and sub node 'port' properties to specify connectors on the
High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines
endpoints of the USB controller.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 .../bindings/usb/mediatek,mt6360-tcpc.yaml    | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
index 053264e60583..5b6ea0d734ea 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
@@ -32,6 +32,27 @@ properties:
     description:
       Properties for usb c connector.
 
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    description:
+      Any connector to the data bus of this controller should be specified.
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "port@[0-2]$":
+        $ref: /schemas/graph.yaml#/properties/port
+        description:
+          It could be one of the following interface types. High-Speed
+          (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS)
+          data bus endpoint to the Type-C connector, or Sideband Use (SBU)
+          AUX lines endpoint to the Type-C connector for the purpose of
+          handling altmode muxing and orientation switching.
+
 additionalProperties: false
 
 required:
-- 
2.45.2

[PATCH 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

[Macpaul Lin]

From: Fabien Parent <fparent@baylibre.com>

Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
configuration for TCPC Port, USB-C connector, and related settings.

Configure dual role switch capability, set up PD (Power Delivery) profiles,
and establish endpoints for SSUSB (SuperSpeed USB).

Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
to "otg" for OTG (On-The-Go) mode operation.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
Signed-off-by: Simon Sun <simon.sun@yunjingtech.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 .../dts/mediatek/mt8395-genio-1200-evk.dts    | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
index 5f16fb820580..b91a46f4a702 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
@@ -249,6 +249,39 @@ mt6360: pmic@34 {
 		#interrupt-cells = <1>;
 		pinctrl-0 = <&mt6360_pins>;
 
+		tcpc {
+			compatible = "mediatek,mt6360-tcpc";
+			interrupts-extended = <&pio 17 IRQ_TYPE_LEVEL_LOW>;
+			interrupt-names = "PD_IRQB";
+
+			connector {
+				compatible = "usb-c-connector";
+				label = "USB-C";
+				data-role = "dual";
+				power-role = "dual";
+				try-power-role = "sink";
+				source-pdos = <PDO_FIXED(5000, 1000, \
+					       PDO_FIXED_DUAL_ROLE | \
+					       PDO_FIXED_DATA_SWAP)>;
+				sink-pdos = <PDO_FIXED(5000, 2000, \
+					     PDO_FIXED_DUAL_ROLE | \
+					     PDO_FIXED_DATA_SWAP)>;
+				op-sink-microwatt = <10000000>;
+			};
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					mt6360_ssusb_ep: endpoint {
+						remote-endpoint = <&ssusb_ep>;
+					};
+				};
+			};
+		};
+
 		charger {
 			compatible = "mediatek,mt6360-chg";
 			richtek,vinovp-microvolt = <14500000>;
@@ -446,6 +479,13 @@ &pciephy {
 };
 
 &pio {
+	u3_p0_vbus: u3-p0-vbus-default-pins {
+		pins-cmd-dat {
+			pinmux = <PINMUX_GPIO63__FUNC_VBUSVALID>;
+			input-enable;
+		};
+	};
+
 	audio_default_pins: audio-default-pins {
 		pins-cmd-dat {
 			pinmux = <PINMUX_GPIO61__FUNC_DMIC1_CLK>,
@@ -900,8 +940,19 @@ &ufsphy {
 };
 
 &ssusb0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&u3_p0_vbus>;
 	vusb33-supply = <&mt6359_vusb_ldo_reg>;
+	dr_mode = "otg";
+	mediatek,usb3-drd;
+	usb-role-switch;
 	status = "okay";
+
+	port {
+		ssusb_ep: endpoint {
+			remote-endpoint = <&mt6360_ssusb_ep>;
+		};
+	};
 };
 
 &ssusb2 {
-- 
2.45.2

Re: [PATCH 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

[Rob Herring]

On Tue, Oct 15, 2024 at 06:33:37PM +0800, Macpaul Lin wrote:
> From: Fabien Parent <fparent@baylibre.com>
> 
> Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
> configuration for TCPC Port, USB-C connector, and related settings.
> 
> Configure dual role switch capability, set up PD (Power Delivery) profiles,
> and establish endpoints for SSUSB (SuperSpeed USB).
> 
> Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
> to "otg" for OTG (On-The-Go) mode operation.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Simon Sun <simon.sun@yunjingtech.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../dts/mediatek/mt8395-genio-1200-evk.dts    | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> index 5f16fb820580..b91a46f4a702 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> @@ -249,6 +249,39 @@ mt6360: pmic@34 {
>  		#interrupt-cells = <1>;
>  		pinctrl-0 = <&mt6360_pins>;
>  
> +		tcpc {
> +			compatible = "mediatek,mt6360-tcpc";
> +			interrupts-extended = <&pio 17 IRQ_TYPE_LEVEL_LOW>;
> +			interrupt-names = "PD_IRQB";
> +
> +			connector {
> +				compatible = "usb-c-connector";
> +				label = "USB-C";
> +				data-role = "dual";
> +				power-role = "dual";
> +				try-power-role = "sink";
> +				source-pdos = <PDO_FIXED(5000, 1000, \
> +					       PDO_FIXED_DUAL_ROLE | \
> +					       PDO_FIXED_DATA_SWAP)>;
> +				sink-pdos = <PDO_FIXED(5000, 2000, \
> +					     PDO_FIXED_DUAL_ROLE | \
> +					     PDO_FIXED_DATA_SWAP)>;
> +				op-sink-microwatt = <10000000>;
> +			};
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					mt6360_ssusb_ep: endpoint {
> +						remote-endpoint = <&ssusb_ep>;

No, this is wrong. This should go to 'port@1' in the connector node. 
That is the SS connection.

Rob

Re: [PATCH 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

[Macpaul Lin]

On 10/16/24 04:56, Rob Herring wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Tue, Oct 15, 2024 at 06:33:37PM +0800, Macpaul Lin wrote:
>> From: Fabien Parent <fparent@baylibre.com>
>> 
>> Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
>> configuration for TCPC Port, USB-C connector, and related settings.
>> 
>> Configure dual role switch capability, set up PD (Power Delivery) profiles,
>> and establish endpoints for SSUSB (SuperSpeed USB).
>> 
>> Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
>> to "otg" for OTG (On-The-Go) mode operation.
>> 
>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>> Signed-off-by: Simon Sun <simon.sun@yunjingtech.com>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  .../dts/mediatek/mt8395-genio-1200-evk.dts    | 51 +++++++++++++++++++
>>  1 file changed, 51 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
>> index 5f16fb820580..b91a46f4a702 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
>> @@ -249,6 +249,39 @@ mt6360: pmic@34 {
>>  #interrupt-cells = <1>;
>>  pinctrl-0 = <&mt6360_pins>;
>>  
>> +tcpc {
>> +compatible = "mediatek,mt6360-tcpc";
>> +interrupts-extended = <&pio 17 IRQ_TYPE_LEVEL_LOW>;
>> +interrupt-names = "PD_IRQB";
>> +
>> +connector {
>> +compatible = "usb-c-connector";
>> +label = "USB-C";
>> +data-role = "dual";
>> +power-role = "dual";
>> +try-power-role = "sink";
>> +source-pdos = <PDO_FIXED(5000, 1000, \
>> +       PDO_FIXED_DUAL_ROLE | \
>> +       PDO_FIXED_DATA_SWAP)>;
>> +sink-pdos = <PDO_FIXED(5000, 2000, \
>> +     PDO_FIXED_DUAL_ROLE | \
>> +     PDO_FIXED_DATA_SWAP)>;
>> +op-sink-microwatt = <10000000>;
>> +};
>> +
>> +ports {
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +
>> +port@0 {
>> +reg = <0>;
>> +mt6360_ssusb_ep: endpoint {
>> +remote-endpoint = <&ssusb_ep>;
> 
> No, this is wrong. This should go to 'port@1' in the connector node.
> That is the SS connection.
> 
> Rob

This wrong index and wrong intent for the whole 'ports' node will be
fixed in patch v2.

Thanks for the review.
Macpaul Lin

Re: [PATCH 1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties

[Rob Herring (Arm)]

On Tue, 15 Oct 2024 18:33:36 +0800, Macpaul Lin wrote:
> Add 'ports' and sub node 'port' properties to specify connectors on the
> High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines
> endpoints of the USB controller.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../bindings/usb/mediatek,mt6360-tcpc.yaml    | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y mediatek/mt8395-genio-1200-evk.dtb' for 20241015103337.20479-1-macpaul.lin@mediatek.com:

arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: usb@11201000: 'mediatek,usb3-drd' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/usb/mediatek,mtu3.yaml#

Re: [PATCH 1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties

[Rob Herring]

On Tue, Oct 15, 2024 at 06:33:36PM +0800, Macpaul Lin wrote:
> Add 'ports' and sub node 'port' properties to specify connectors on the
> High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines
> endpoints of the USB controller.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../bindings/usb/mediatek,mt6360-tcpc.yaml    | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> index 053264e60583..5b6ea0d734ea 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> @@ -32,6 +32,27 @@ properties:
>      description:
>        Properties for usb c connector.
>  
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +    description:
> +      Any connector to the data bus of this controller should be specified.
> +    properties:

> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0

No need for these, already defined in the $ref'ed schema.

> +
> +    patternProperties:
> +      "port@[0-2]$":
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description:
> +          It could be one of the following interface types. High-Speed
> +          (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS)
> +          data bus endpoint to the Type-C connector, or Sideband Use (SBU)
> +          AUX lines endpoint to the Type-C connector for the purpose of
> +          handling altmode muxing and orientation switching.

You have to define what each port number is.

However, I'm completely confused as to why you need any of this. The 
description sounds like the usb-c-connector which is already defined as 
a child node.

Rob

Re: [PATCH 1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties

[Macpaul Lin]

On 10/16/24 04:54, Rob Herring wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Tue, Oct 15, 2024 at 06:33:36PM +0800, Macpaul Lin wrote:
>> Add 'ports' and sub node 'port' properties to specify connectors on the
>> High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines
>> endpoints of the USB controller.
>> 
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  .../bindings/usb/mediatek,mt6360-tcpc.yaml    | 21 +++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> index 053264e60583..5b6ea0d734ea 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> @@ -32,6 +32,27 @@ properties:
>>      description:
>>        Properties for usb c connector.
>>  
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    description:
>> +      Any connector to the data bus of this controller should be specified.
>> +    properties:
> 
>> +      "#address-cells":
>> +        const: 1
>> +
>> +      "#size-cells":
>> +        const: 0
> 
> No need for these, already defined in the $ref'ed schema.
> 
>> +
>> +    patternProperties:
>> +      "port@[0-2]$":
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description:
>> +          It could be one of the following interface types. High-Speed
>> +          (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS)
>> +          data bus endpoint to the Type-C connector, or Sideband Use (SBU)
>> +          AUX lines endpoint to the Type-C connector for the purpose of
>> +          handling altmode muxing and orientation switching.
> 
> You have to define what each port number is.
> 
> However, I'm completely confused as to why you need any of this. The
> description sounds like the usb-c-connector which is already defined as
> a child node.
> 
> Rob
> 

After checking the internal reference DTS, I've found the
intent was wrong for these ports. I'll send [2/2] of v2 for the
DTS update. Hence this change to DT Schema is no longer required.
Please drop this patch.

Thanks!
Macpaul Lin