[PATCH 1/2] dt-bindings: trivial-devices: Remove vicor,pli1209bc

[PATCH 1/2] dt-bindings: trivial-devices: Remove vicor,pli1209bc

[Naresh Solanki]

vicor,pli1209bc doesn't fit into trivial devices as it needs additional
properties.

Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 15f89d7ecf73..00361b5cfc3c 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -404,8 +404,6 @@ properties:
           - ti,tps546d24
             # I2C Touch-Screen Controller
           - ti,tsc2003
-            # Vicor Corporation Digital Supervisor
-          - vicor,pli1209bc
             # Winbond/Nuvoton H/W Monitor
           - winbond,w83793
 

base-commit: 7ae5eff46d61cc9b4674920821cb31e8c8fadf36
-- 
2.42.0

[PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

[Naresh Solanki]

Add bindings for Vicor pli1209bc.
It a Digital Supervisor with Isolation for use with BCM Bus Converter
Modules.

Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
 .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
new file mode 100644
index 000000000000..3647d14e9111
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,pli1209bc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Vicor PLI1209BC Power Regulator
+
+maintainers:
+  - Marcello Sylvester Bauer <sylv@sylv.io>
+  - Naresh Solanki <naresh.solanki@9elements.com>
+
+description: |
+  The Vicor PLI1209BC is a Digital Supervisor with Isolation for use
+  with BCM Bus Converter Modules.
+
+properties:
+  compatible:
+    enum:
+      - vicor,pli1209bc
+
+  reg:
+    maxItems: 1
+
+  regulators:
+    type: object
+    description:
+      List of regulators provided by this controller.
+
+    properties:
+      vout2:
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+
+        unevaluatedProperties: false
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pli1209bc_p12v_d: regulator@5f {
+            compatible = "vicor,pli1209bc";
+            reg = <0x5f>;
+
+            regulators {
+                p12v_d: vout2 {
+                    regulator-name = "bcm3";
+                    regulator-boot-on;
+                };
+            };
+        };
+    };
+
-- 
2.42.0

Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

[Krzysztof Kozlowski]

On 15/10/2024 13:33, Naresh Solanki wrote:
> Add bindings for Vicor pli1209bc.
> It a Digital Supervisor with Isolation for use with BCM Bus Converter
> Modules.
> 
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++

This has to be squashed with previous patch.

>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> new file mode 100644
> index 000000000000..3647d14e9111
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +

Drop blank line

> +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,pli1209bc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Vicor PLI1209BC Power Regulator
> +
> +maintainers:
> +  - Marcello Sylvester Bauer <sylv@sylv.io>
> +  - Naresh Solanki <naresh.solanki@9elements.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The Vicor PLI1209BC is a Digital Supervisor with Isolation for use
> +  with BCM Bus Converter Modules.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - vicor,pli1209bc
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:

Drop the node and define vout2 here directly.... unless anything needs
such layout? Then explain this in commit msg.

> +    type: object
> +    description:
> +      List of regulators provided by this controller.
> +
> +    properties:
> +      vout2:
> +        $ref: /schemas/regulator/regulator.yaml#
> +        type: object
> +

Drop blank line.

> +        unevaluatedProperties: false
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>

Drop, not used.

> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pli1209bc_p12v_d: regulator@5f {

Drop unused prefix

> +            compatible = "vicor,pli1209bc";
> +            reg = <0x5f>;
> +
> +            regulators {
> +                p12v_d: vout2 {
> +                    regulator-name = "bcm3";
> +                    regulator-boot-on;
> +                };
> +            };
> +        };
> +    };
> +

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

[Guenter Roeck]

On 10/15/24 04:48, Krzysztof Kozlowski wrote:
> On 15/10/2024 13:33, Naresh Solanki wrote:
>> Add bindings for Vicor pli1209bc.
>> It a Digital Supervisor with Isolation for use with BCM Bus Converter
>> Modules.
>>
>> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
>> ---
>>   .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++
> 
> This has to be squashed with previous patch.
> 

Neither me nor the hwmon mailing list was copied on that previous patch
(or on an intro patch if there was one), so I have no idea what this
is about.

Guenter

Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

[Krzysztof Kozlowski]

On 15/10/2024 16:10, Guenter Roeck wrote:
> On 10/15/24 04:48, Krzysztof Kozlowski wrote:
>> On 15/10/2024 13:33, Naresh Solanki wrote:
>>> Add bindings for Vicor pli1209bc.
>>> It a Digital Supervisor with Isolation for use with BCM Bus Converter
>>> Modules.
>>>
>>> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
>>> ---
>>>   .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++
>>
>> This has to be squashed with previous patch.
>>
> 
> Neither me nor the hwmon mailing list was copied on that previous patch
> (or on an intro patch if there was one), so I have no idea what this
> is about.

Heh... that's even worse because without that visibility you would pick
up this patch only leading to duplicated compatibles warnings.

Naresh, sending such patchsets is really not correct. Be sure you
organize them logically and in fully bisectable way, and then you CC
relevant people.

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

[Naresh Solanki]

Hi Krzysztof, Guenter,

On Tue, 15 Oct 2024 at 20:19, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 15/10/2024 16:10, Guenter Roeck wrote:
> > On 10/15/24 04:48, Krzysztof Kozlowski wrote:
> >> On 15/10/2024 13:33, Naresh Solanki wrote:
> >>> Add bindings for Vicor pli1209bc.
> >>> It a Digital Supervisor with Isolation for use with BCM Bus Converter
> >>> Modules.
> >>>
> >>> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> >>> ---
> >>>   .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++
> >>
> >> This has to be squashed with previous patch.
Ack
> >>
> >
> > Neither me nor the hwmon mailing list was copied on that previous patch
> > (or on an intro patch if there was one), so I have no idea what this
> > is about.
>
> Heh... that's even worse because without that visibility you would pick
> up this patch only leading to duplicated compatibles warnings.
>
> Naresh, sending such patchsets is really not correct. Be sure you
> organize them logically and in fully bisectable way, and then you CC
> relevant people.
Yes this definitely causes confusion. I should have organised it better.
Will make sure I handle it properly. Pardon me for the confusion

Thanks
Naresh
>
> Best regards,
> Krzysztof
>

Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

[Naresh Solanki]

Hi Krzysztof,

On Tue, 15 Oct 2024 at 17:18, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 15/10/2024 13:33, Naresh Solanki wrote:
> > Add bindings for Vicor pli1209bc.
> > It a Digital Supervisor with Isolation for use with BCM Bus Converter
> > Modules.
> >
> > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > ---
> >  .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++
>
> This has to be squashed with previous patch.
>
> >  1 file changed, 65 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> > new file mode 100644
> > index 000000000000..3647d14e9111
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
>
> Drop blank line
Ack
>
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,pli1209bc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Vicor PLI1209BC Power Regulator
> > +
> > +maintainers:
> > +  - Marcello Sylvester Bauer <sylv@sylv.io>
> > +  - Naresh Solanki <naresh.solanki@9elements.com>
> > +
> > +description: |
>
> Do not need '|' unless you need to preserve formatting.
Ack
>
> > +  The Vicor PLI1209BC is a Digital Supervisor with Isolation for use
> > +  with BCM Bus Converter Modules.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - vicor,pli1209bc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  regulators:
>
> Drop the node and define vout2 here directly.... unless anything needs
> such layout? Then explain this in commit msg.
This is expected by pmbus regulator driver:
https://github.com/torvalds/linux/blob/master/drivers/hwmon/pmbus/pmbus.h#L512
>
> > +    type: object
> > +    description:
> > +      List of regulators provided by this controller.
> > +
> > +    properties:
> > +      vout2:
> > +        $ref: /schemas/regulator/regulator.yaml#
> > +        type: object
> > +
>
> Drop blank line.
Ack
>
> > +        unevaluatedProperties: false
> > +
> > +    additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
>
> Drop, not used.
Ack
>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pli1209bc_p12v_d: regulator@5f {
>
> Drop unused prefix
Ack

Regards,
Naresh
>
> > +            compatible = "vicor,pli1209bc";
> > +            reg = <0x5f>;
> > +
> > +            regulators {
> > +                p12v_d: vout2 {
> > +                    regulator-name = "bcm3";
> > +                    regulator-boot-on;
> > +                };
> > +            };
> > +        };
> > +    };
> > +
>
> Best regards,
> Krzysztof
>