From: Rob Herring <robh@kernel.org>
To: Amelie Delaunay <amelie.delaunay@foss.st.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
dmaengine@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/9] dt-bindings: dma: stm32-dma3: prevent additional transfers
Date: Tue, 15 Oct 2024 16:30:53 -0500 [thread overview]
Message-ID: <20241015213053.GA1992090-robh@kernel.org> (raw)
In-Reply-To: <20241015-dma3-mp25-updates-v2-4-b63e21556ec8@foss.st.com>
On Tue, Oct 15, 2024 at 02:14:40PM +0200, Amelie Delaunay wrote:
> stm32-dma3 driver refactors the linked-list in order to address the memory
> with the highest possible data width.
You are still talking about driver...
> It means that it can introduce up to 2 linked-list items. One with a
> transfer length multiple of channel maximum burst length and so with the
> highest possible data width. And an extra one with the latest bytes, with
> lower data width.
> Some devices (e.g. FMC ECC) don't support having several transfers instead
> of only one.
> So add the possibility to prevent these additional transfers, by setting
> bit 17 of the 'DMA transfer requirements' bit mask.
Some devices require single transfers. That's about all you need to say.
>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> Changes in v2:
> - Reword commit title/message/content as per Rob's suggestion.
> ---
> Documentation/devicetree/bindings/dma/stm32/st,stm32-dma3.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/stm32/st,stm32-dma3.yaml b/Documentation/devicetree/bindings/dma/stm32/st,stm32-dma3.yaml
> index 5484848735f8ac3d2050104bbab1d986e82ba6a7..36f9fe860eb990e6caccedd31460ee6993772a35 100644
> --- a/Documentation/devicetree/bindings/dma/stm32/st,stm32-dma3.yaml
> +++ b/Documentation/devicetree/bindings/dma/stm32/st,stm32-dma3.yaml
> @@ -99,6 +99,9 @@ properties:
> -bit 16: Prevent packing/unpacking mode
> 0x0: pack/unpack enabled when source data width/burst != destination data width/burst
> 0x1: memory data width/burst forced to peripheral data width/burst to prevent pack/unpack
> + -bit 17: Prevent additional transfers due to linked-list refactoring
> + 0x0: don't prevent additional transfers for optimal performance
> + 0x1: prevent additional transfer to accommodate user constraints such as single transfer
>
> required:
> - compatible
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-10-15 21:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 12:14 [PATCH v2 0/9] STM32 DMA3 updates for STM32MP25 Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 1/9] dt-bindings: dma: stm32-dma3: prevent packing/unpacking mode Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 2/9] dmaengine: stm32-dma3: prevent pack/unpack thanks to DT configuration Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 3/9] dmaengine: stm32-dma3: refactor HW linked-list to optimize memory accesses Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 4/9] dt-bindings: dma: stm32-dma3: prevent additional transfers Amelie Delaunay
2024-10-15 21:30 ` Rob Herring [this message]
2024-10-15 12:14 ` [PATCH v2 5/9] dmaengine: stm32-dma3: prevent LL refactoring thanks to DT configuration Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 6/9] dmaengine: stm32-dma3: clamp AXI burst using match data Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 7/9] arm64: dts: st: add DMA support on U(S)ART instances of stm32mp25 Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 8/9] arm64: dts: st: add DMA support on I2C " Amelie Delaunay
2024-10-15 12:14 ` [PATCH v2 9/9] arm64: dts: st: add DMA support on SPI " Amelie Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015213053.GA1992090-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).