* [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property
@ 2024-10-15 17:21 Macpaul Lin
2024-10-15 22:20 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Macpaul Lin @ 2024-10-15 17:21 UTC (permalink / raw)
To: Chunfeng Yun, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, ChiYuan Huang, linux-usb,
linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
This flag specify whether it is a USB3 Dual-role device hardware.
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
index d4e187c78a0b..1e70af0dac82 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
@@ -155,6 +155,12 @@ properties:
property is used. See graph.txt
$ref: /schemas/graph.yaml#/properties/port
+ mediatek,usb3-drd:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ Specify whether it is a USB3 Dual-role device hardware.
+ type: boolean
+
enable-manual-drd:
$ref: /schemas/types.yaml#/definitions/flag
description:
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property
2024-10-15 17:21 [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property Macpaul Lin
@ 2024-10-15 22:20 ` Rob Herring
2024-10-16 4:17 ` Macpaul Lin
2024-10-16 10:52 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2024-10-15 22:20 UTC (permalink / raw)
To: Macpaul Lin
Cc: Chunfeng Yun, Greg Kroah-Hartman, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
ChiYuan Huang, linux-usb, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
On Wed, Oct 16, 2024 at 01:21:00AM +0800, Macpaul Lin wrote:
> Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
> This flag specify whether it is a USB3 Dual-role device hardware.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index d4e187c78a0b..1e70af0dac82 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -155,6 +155,12 @@ properties:
> property is used. See graph.txt
> $ref: /schemas/graph.yaml#/properties/port
>
> + mediatek,usb3-drd:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Specify whether it is a USB3 Dual-role device hardware.
> + type: boolean
> +
Don't the standard properties such as usb-role-switch or dr_mode work
for you?
> enable-manual-drd:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property
2024-10-15 22:20 ` Rob Herring
@ 2024-10-16 4:17 ` Macpaul Lin
2024-10-16 10:52 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2024-10-16 4:17 UTC (permalink / raw)
To: Rob Herring
Cc: Chunfeng Yun, Greg Kroah-Hartman, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
ChiYuan Huang, linux-usb, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel, Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
On 10/16/24 06:20, Rob Herring wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On Wed, Oct 16, 2024 at 01:21:00AM +0800, Macpaul Lin wrote:
>> Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
>> This flag specify whether it is a USB3 Dual-role device hardware.
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> index d4e187c78a0b..1e70af0dac82 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> @@ -155,6 +155,12 @@ properties:
>> property is used. See graph.txt
>> $ref: /schemas/graph.yaml#/properties/port
>>
>> + mediatek,usb3-drd:
>> + $ref: /schemas/types.yaml#/definitions/flag
>> + description:
>> + Specify whether it is a USB3 Dual-role device hardware.
>> + type: boolean
>> +
>
> Don't the standard properties such as usb-role-switch or dr_mode work
> for you?
I've found there are some hardware capability registers could be read
when probing the device. I'll try if the platform I'm using could access
these capability registers.
This patch can be discard. If the hardware really need specify the
capability in dts and there is no capability registers, I'll resend
this patch that time.
>> enable-manual-drd:
>> $ref: /schemas/types.yaml#/definitions/flag
>> description:
>> --
>> 2.45.2
>>
>
Thanks!
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property
2024-10-15 22:20 ` Rob Herring
2024-10-16 4:17 ` Macpaul Lin
@ 2024-10-16 10:52 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-10-16 10:52 UTC (permalink / raw)
To: Rob Herring, Macpaul Lin
Cc: Chunfeng Yun, Greg Kroah-Hartman, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, ChiYuan Huang, linux-usb,
linux-arm-kernel, linux-mediatek, devicetree, linux-kernel,
Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
Il 16/10/24 00:20, Rob Herring ha scritto:
> On Wed, Oct 16, 2024 at 01:21:00AM +0800, Macpaul Lin wrote:
>> Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
>> This flag specify whether it is a USB3 Dual-role device hardware.
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> index d4e187c78a0b..1e70af0dac82 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> @@ -155,6 +155,12 @@ properties:
>> property is used. See graph.txt
>> $ref: /schemas/graph.yaml#/properties/port
>>
>> + mediatek,usb3-drd:
>> + $ref: /schemas/types.yaml#/definitions/flag
>> + description:
>> + Specify whether it is a USB3 Dual-role device hardware.
>> + type: boolean
>> +
>
> Don't the standard properties such as usb-role-switch or dr_mode work
> for you?
>
They do - and in fact, the upstream MTU3 driver doesn't even support parsing
the proposed property because it does parse the standard usb-role-switch property.
This means that this commit is not needed at all.
Cheers,
Angelo
>> enable-manual-drd:
>> $ref: /schemas/types.yaml#/definitions/flag
>> description:
>> --
>> 2.45.2
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-16 10:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 17:21 [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property Macpaul Lin
2024-10-15 22:20 ` Rob Herring
2024-10-16 4:17 ` Macpaul Lin
2024-10-16 10:52 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).