From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, lee@kernel.org, sre@kernel.org,
tsbogend@alpha.franken.de, markus.stockhausen@gmx.de
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-mips@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v6 1/6] dt-bindings: reset: syscon-reboot: Add reg property
Date: Wed, 16 Oct 2024 11:59:43 +1300 [thread overview]
Message-ID: <20241015225948.3971924-2-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20241015225948.3971924-1-chris.packham@alliedtelesis.co.nz>
The syscon-reboot binding used 'offset' for historical reasons. Having a
reg property is appropriate when these nodes are children of a MMIO bus.
Add a reg property and modify the constraints so that one of 'reg' or
'offset' is expected.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Notes:
Changes in v6:
- Add r-by from Krzysztof
Changes in v5:
- New, suggested by Krzysztof
.../bindings/power/reset/syscon-reboot.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
index 75061124d9a8..19d3093e6cd2 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
@@ -31,6 +31,10 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
description: Offset in the register map for the reboot register (in bytes).
+ reg:
+ maxItems: 1
+ description: Base address and size for the reboot register.
+
regmap:
$ref: /schemas/types.yaml#/definitions/phandle
deprecated: true
@@ -45,9 +49,14 @@ properties:
priority:
default: 192
+oneOf:
+ - required:
+ - offset
+ - required:
+ - reg
+
required:
- compatible
- - offset
additionalProperties: false
--
2.47.0
next prev parent reply other threads:[~2024-10-15 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 22:59 [PATCH v6 0/6] RTL9300 support for reboot and i2c Chris Packham
2024-10-15 22:59 ` Chris Packham [this message]
2024-10-15 22:59 ` [PATCH v6 2/6] power: reset: syscon-reboot: Accept reg property Chris Packham
2024-10-15 22:59 ` [PATCH v6 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals Chris Packham
2024-10-16 6:41 ` Krzysztof Kozlowski
2024-10-16 19:50 ` Chris Packham
2024-10-16 20:00 ` Chris Packham
2024-10-15 22:59 ` [PATCH v6 4/6] mips: dts: realtek: Add syscon-reboot node Chris Packham
2024-10-15 22:59 ` [PATCH v6 5/6] mips: dts: realtek: Add I2C controllers Chris Packham
2024-10-15 22:59 ` [PATCH v6 6/6] i2c: Add driver for the RTL9300 I2C controller Chris Packham
2024-10-16 21:41 ` (subset) [PATCH v6 0/6] RTL9300 support for reboot and i2c Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015225948.3971924-2-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markus.stockhausen@gmx.de \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).