Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: "linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 回复: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes
Date: Thu, 17 Oct 2024 18:52:04 +0100	[thread overview]
Message-ID: <20241017-condone-angelic-9d4936f1fd37@spud> (raw)
In-Reply-To: <ZQ0PR01MB130298186E09DA19CC1F7736F2472@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn>

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Thu, Oct 17, 2024 at 05:49:56AM +0000, Changhuang Liang wrote:
> Hi, Conor,
> 
> > Hi, Conor
> > 
> > Thanks for your patch.
> > 
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > >
> > > Aurelien reported probe failures due to the csi node being enabled
> > > without having a camera attached to it. A camera was in the initial
> > > submissions, but was removed from the dts, as it had not actually been
> > > present on the board, but was from an addon board used by the developer
> > of the relevant drivers.
> > > The non-camera pipeline nodes were not disabled when this happened and
> > > the probe failures are problematic for Debian. Disable them.
> > >
> > > CC: stable@vger.kernel.org
> > > Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera
> > > subsystem
> > > nodes")
> > 
> > Here you write it in 13 characters, should be "Fixes: 28ecaaa5af19 ..."
> > 
> 
> After fixing this:
> Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Ye, I know it was 13 not 12. I don't think that's a problem though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-10-17 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  5:49 回复: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes Changhuang Liang
2024-10-17 17:52 ` Conor Dooley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-10-17  1:17 Changhuang Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017-condone-angelic-9d4936f1fd37@spud \
    --to=conor@kernel.org \
    --cc=aurelien@aurel32.net \
    --cc=changhuang.liang@starfivetech.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox