From: Andreas Kemnade <andreas@kemnade.info>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: aaro.koskinen@iki.fi, khilman@baylibre.com, rogerq@kernel.org,
linux-omap@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCH v2 0/4] ARM: dts: omap: omap4-epson-embt2ws: misc gpio definitions
Date: Thu, 17 Oct 2024 11:49:34 +0200 [thread overview]
Message-ID: <20241017114934.240d35b4@akair> (raw)
In-Reply-To: <172857036157.1533290.9663617637580743712.robh@kernel.org>
Am Thu, 10 Oct 2024 09:30:09 -0500
schrieb "Rob Herring (Arm)" <robh@kernel.org>:
> On Thu, 10 Oct 2024 14:29:53 +0200, Andreas Kemnade wrote:
> > Bring the system into a more defined state and do not rely
> > on things being initialized by bootloader.
> >
> > Changes in V2:
> > - better comment strange GPIOs
> > - proper names for regulator nodes
> >
> > Andreas Kemnade (4):
> > ARM: dts: omap: omap4-epson-embt2ws: define GPIO regulators
> > ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
> > ARM: dts: omap: omap4-epson-embt2ws: add unknown gpio outputs
> > ARM: dts: omap: omap4-epson-embt2ws: add GPIO expander
> >
> > .../boot/dts/ti/omap/omap4-epson-embt2ws.dts | 183
> > +++++++++++++++++- 1 file changed, 179 insertions(+), 4 deletions(-)
> >
> > --
> > 2.39.5
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in
> this series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the
> warnings are fixed by another series. Ultimately, it is up to the
> platform maintainer whether these warnings are acceptable or not. No
> need to reply unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y
> ti/omap/omap4-epson-embt2ws.dtb' for
> 20241010122957.85164-1-andreas@kemnade.info:
>
> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dtb: serial@0:
> {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts':
> [[0, 74, 4]], 'clock-frequency': 48000000, 'pinctrl-names':
> ['default'], 'pinctrl-0': [[115]], 'interrupts-extended': [[1, 0, 74,
> 4], [116, 260]], '$nodename': ['serial@0']} is valid under each of
> {'required': ['interrupts-extended']}, {'required': ['interrupts']}
> from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dtb: serial@0:
> {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts':
> [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names':
> ['default'], 'pinctrl-0': [[118, 119]], 'interrupts-extended': [[1,
> 0, 73, 4], [116, 220]], 'bluetooth-gnss': {'compatible':
> ['ti,wl1283-st'], 'enable-gpios': [[120, 25, 0]], 'clocks': [[121,
> 1]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is
> valid under each of {'required': ['interrupts-extended']},
> {'required': ['interrupts']} from schema $id:
> http://devicetree.org/schemas/serial/8250_omap.yaml#
>
To make sure I am getting this right: According to wdiff, the
difference is:
'pinctrl-0': [-[[116, 117]],-] {+[[118, 119]],+}
'interrupts-extended': [[1, 0, 73, 4], [-[114,-] {+[116,+} 220]]
So my understanding is that phandle numbers are reordered and one
of the reordered numbers pops up in a warning message and cannot
easily be filtered away. Are there any tools or procedures in general to
filter out phandle reenumeration noise? Also when reordering things
expecting no functional change and diffing dtbs that would be helpful.
Regards,
Andreas
next prev parent reply other threads:[~2024-10-17 9:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:29 [PATCH v2 0/4] ARM: dts: omap: omap4-epson-embt2ws: misc gpio definitions Andreas Kemnade
2024-10-10 12:29 ` [PATCH v2 1/4] ARM: dts: omap: omap4-epson-embt2ws: define GPIO regulators Andreas Kemnade
2024-10-10 20:07 ` Roger Quadros
2024-10-10 12:29 ` [PATCH v2 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators Andreas Kemnade
2024-10-10 20:08 ` Roger Quadros
2024-10-10 12:29 ` [PATCH v2 3/4] ARM: dts: omap: omap4-epson-embt2ws: add unknown gpio outputs Andreas Kemnade
2024-10-10 20:15 ` Roger Quadros
2024-10-11 9:12 ` Andreas Kemnade
2024-10-11 10:37 ` Roger Quadros
2024-10-11 10:37 ` Roger Quadros
2024-10-10 12:29 ` [PATCH v2 4/4] ARM: dts: omap: omap4-epson-embt2ws: add GPIO expander Andreas Kemnade
2024-10-10 20:17 ` Roger Quadros
2024-10-10 14:30 ` [PATCH v2 0/4] ARM: dts: omap: omap4-epson-embt2ws: misc gpio definitions Rob Herring (Arm)
2024-10-17 9:49 ` Andreas Kemnade [this message]
2024-10-29 23:23 ` Kevin Hilman
2024-10-29 23:35 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017114934.240d35b4@akair \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).