From: Andreas Kemnade <andreas@kemnade.info>
To: Rob Herring <robh@kernel.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Roger Quadros <rogerq@kernel.org>,
linux-omap@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
Tero Kristo <kristo@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 2/2] dt-bindings: clock: ti: Convert divider.txt to json-schema
Date: Thu, 17 Oct 2024 12:38:02 +0200 [thread overview]
Message-ID: <20241017123802.2a1fff05@akair> (raw)
In-Reply-To: <20241010034434.GB1297859-robh@kernel.org>
Am Wed, 9 Oct 2024 22:44:34 -0500
schrieb Rob Herring <robh@kernel.org>:
> > +
> > + ti,min-div:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + min divisor for dividing the input clock rate, only
> > + needed if the first divisor is offset from the default value
> > (1)
>
> minimum: 1
> maximum: ?
> default: 1
maximum is complex: there is one place in the code where this runs
through a u8 (_get_val). although it it read from the devicetree as a
uint32.
So, if we do not care about a specific implementation, then
in the power-of-two case, the theoretical maximum would be 1 << (1 <<
(32-bitshift) - 1) clipped to UINT32_MAX due to type constraints. And
also the maximum lifetime of electronics and elementary elements and
pieces, probably even with the proposed decay time of protons.
In the index-starts-at-case, we would have (1 << (32-bitshift)) - 1.
otherwise 1 << (32-bitshift).
I would propose not to define a maximum here.
Regards,
Andreas
prev parent reply other threads:[~2024-10-17 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 20:56 [PATCH RFC v2 0/2] dt-bindings: clock: ti: convert to yaml Andreas Kemnade
2024-10-09 20:56 ` [PATCH RFC v2 1/2] dt-bindings: clock: ti: Convert interface.txt to json-schema Andreas Kemnade
2024-10-10 3:34 ` Rob Herring
2024-10-09 20:56 ` [PATCH RFC v2 2/2] dt-bindings: clock: ti: Convert divider.txt " Andreas Kemnade
2024-10-10 3:36 ` Rob Herring (Arm)
2024-10-10 3:44 ` Rob Herring
2024-10-17 10:38 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017123802.2a1fff05@akair \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).