From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <aardelean@baylibre.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
lars@metafoo.de, michael.hennerich@analog.com,
gstols@baylibre.com, dlechner@baylibre.com
Subject: Re: [PATCH v7 5/8] iio: adc: ad7606: rework available attributes for SW channels
Date: Thu, 17 Oct 2024 18:50:50 +0100 [thread overview]
Message-ID: <20241017185050.0ed82a03@jic23-huawei> (raw)
In-Reply-To: <20240919130444.2100447-6-aardelean@baylibre.com>
On Thu, 19 Sep 2024 16:04:40 +0300
Alexandru Ardelean <aardelean@baylibre.com> wrote:
> For SW mode, the oversampling and scales attributes are always present.
> So, they can be implemented via a 'read_avail' hook in iio_info.
>
> For HW mode, it's a bit tricky, as these attributes get assigned based on
> GPIO definitions.
>
> So, for SW mode, we define a separate AD7606_SW_CHANNEL() macro, and use
> that for the SW channels.
> And 'ad7606_info_os_range_and_debug' can be renamed to
> 'ad7606_info_sw_mode' as it is only used for SW mode.
>
> For the 'read_avail' hook, we'll need to allocate the SW scales, so that
> they are just returned userspace without any extra processing.
> The allocation will happen when then ad7606_state struct is allocated.
> The oversampling available parameters don't need any extra processing; they
> can just be passed back to userspace (as they are).
>
> Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
> ---
> drivers/iio/adc/ad7606.c | 52 ++++++++++++++++++++++++++++++++++---
> drivers/iio/adc/ad7606.h | 32 ++++++++++++++++++++---
> drivers/iio/adc/ad7606_spi. | 0
Magic empty file :(
Sending a patch shortly and already queued up.
next prev parent reply other threads:[~2024-10-17 17:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 13:04 [PATCH v7 0/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 1/8] iio: adc: ad7606: add 'bits' parameter to channels macros Alexandru Ardelean
2024-09-23 14:50 ` David Lechner
2024-09-24 8:11 ` Alexandru Ardelean
2024-09-28 14:43 ` Jonathan Cameron
2024-09-19 13:04 ` [PATCH v7 2/8] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct() Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 3/8] iio: adc: ad7606: move scale_setup as function pointer on chip-info Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 4/8] iio: adc: ad7606: wrap channel ranges & scales into struct Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 5/8] iio: adc: ad7606: rework available attributes for SW channels Alexandru Ardelean
2024-10-17 17:50 ` Jonathan Cameron [this message]
2024-10-19 16:15 ` Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 6/8] dt-bindings: iio: adc: document diff-channels corner case for some ADCs Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 7/8] dt-bindings: iio: adc: add docs for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-19 13:04 ` [PATCH v7 8/8] iio: adc: ad7606: add support " Alexandru Ardelean
2024-10-01 8:26 ` Alexandru Ardelean
2024-10-01 9:26 ` Guillaume Stols
2024-10-01 13:42 ` David Lechner
2024-10-01 18:41 ` Jonathan Cameron
2024-10-02 6:12 ` Alexandru Ardelean
2024-10-04 13:54 ` Jonathan Cameron
2024-10-06 10:56 ` Jonathan Cameron
2024-10-07 7:00 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017185050.0ed82a03@jic23-huawei \
--to=jic23@kernel.org \
--cc=aardelean@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gstols@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).