devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: wangweidong.a@awinic.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com,
	rf@opensource.cirrus.com, neil.armstrong@linaro.org,
	pierre-louis.bossart@linux.dev, luca.ceresoli@bootlin.com,
	arnd@arndb.de, quic_pkumpatl@quicinc.com,
	herve.codina@bootlin.com, masahiroy@kernel.org,
	shenghao-ding@ti.com, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	yijiangtao@awinic.com
Subject: Re: [PATCH V1 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88081"
Date: Fri, 18 Oct 2024 08:47:21 -0500	[thread overview]
Message-ID: <20241018134721.GA90231-robh@kernel.org> (raw)
In-Reply-To: <20241018094320.113477-2-wangweidong.a@awinic.com>

On Fri, Oct 18, 2024 at 05:43:18PM +0800, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
> 
> Add the awinic,aw88081 property to the awinic,aw88395.yaml file.

That is obvious from reading the diff. Please say something about how 
this new part compares to the existing parts.

> 
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
>  Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> index ac5f2e0f42cb..b39c76b685f4 100644
> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> @@ -20,6 +20,7 @@ properties:
>        - awinic,aw88395
>        - awinic,aw88261
>        - awinic,aw88399
> +      - awinic,aw88081
>  
>    reg:
>      maxItems: 1
> @@ -57,6 +58,7 @@ allOf:
>            contains:
>              enum:
>                - awinic,aw88261
> +              - awinic,aw88081
>      then:
>        properties:
>          reset-gpios: false
> -- 
> 2.47.0
> 

  parent reply	other threads:[~2024-10-18 13:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18  9:43 [PATCH V1 0/2] ASoC: codecs: Add aw88081 amplifier driver wangweidong.a
2024-10-18  9:43 ` [PATCH V1 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88081" wangweidong.a
2024-10-18 10:08   ` Krzysztof Kozlowski
2024-10-21  2:43     ` wangweidong.a
2024-10-18 13:47   ` Rob Herring [this message]
2024-10-21  2:46     ` wangweidong.a
2024-10-18  9:43 ` [PATCH V1 2/2] ASoC: codecs: Add aw88081 amplifier driver wangweidong.a
2024-10-19 16:18   ` anish kumar
2024-10-21  2:48     ` wangweidong.a
2024-10-21 15:05     ` Mark Brown
2024-10-21 17:08   ` Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018134721.GA90231-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=herve.codina@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=masahiroy@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=quic_pkumpatl@quicinc.com \
    --cc=rf@opensource.cirrus.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    --cc=wangweidong.a@awinic.com \
    --cc=yijiangtao@awinic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).