From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B84CD1F8EE2 for ; Mon, 21 Oct 2024 13:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729515767; cv=none; b=bzdIr1s6PCRF+hD33ckHdbgTBu046wYj4iG48bArpJlvxc7w+oydLPMPqaqv2kk7KldYoamfxGtRjDgTOsTUPWh13AhQizLJfWnqZ1z3rYhbJ600pG1fmaYdQobWv223HZTozwoTL6xQ0if7RxaF+gfU1ruFSZbxkw3Yj9UaBag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729515767; c=relaxed/simple; bh=WKgeKu9BKiyFb382szdmwaGYbhsRt+mpw7oK76e+Juw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JVYz4+0dx03S8Lwm0aSCPzP2oeJrIfJeOS/Ferp315mbyf/sehSBw0XYdVGYvo7aDS7572EFhFWjJ3B6g+eLoIpBycBHLjIFm8dEjDpekbnQBYfomMOEJK2zcAqYld+1yrArodRI+RLPaHyHl4tMKYmXcsEgXA4lCP+9mQ3tu3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kIccRN1d; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kIccRN1d" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a9a628b68a7so565658066b.2 for ; Mon, 21 Oct 2024 06:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729515762; x=1730120562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=exnou0jkm74QB50DFbZVtG627VNG9ugvQrtDOKEght8=; b=kIccRN1dXFGNOrUonzPxNsWrlUQsxVZXbDOPOQzCjVWZqzqU5oZg8TCNAH/ojV8aKr +8LlP5h7K8G6Ycjj6bTTiCD3P2agVnZHAWCzFpFGJNCB80E7irBACDLobRfBIxjVQtPD sQNzoDTzXjmWtNUm2X/QMPiTxo85hdCdUfnXg2ffta6yc3g3FCMjT3cNCta9CKALXi93 4gfvS8JwZbl8eKVa6FWVZZolB2LEHW8ZrssylPxnsOXS/xw41EP6+/bCbpcpPtzRUQCm P8XjHBNF1WMlZG0t/qzCbbG62ivxWqEJPXajoN0YH+uaI4avWqqY3d8C/nl+eeEyyVbl d6og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729515762; x=1730120562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=exnou0jkm74QB50DFbZVtG627VNG9ugvQrtDOKEght8=; b=Ibcf2tVqhDu49Kyx0X0wNcy8eM/ITopSC9XPpJn/eVDVLvHy44UQAkT8e/N0wjUUTX 64s2vlEp+ZL1WpaBAJuvTx7kn4SOQeqT99jctywJTTDWZBqUIZnol0wq2JmaPAd+Fcpg AChQXK8h7sRMvpyImB95oZqWMBXrcHEs7/jxeXuf+1ckoweJEWQTuy95g/0fC5R2abNs La8X/3AL/6eM2KT1TqqanYJcRgdqQrmECpsDFxxVotjmy9aMlcWzmIW+1ddG6QdcuoLU fP8/avdcUHvos+Qn2AOBKjem6EKAM0O6OpjPQsx+hpQ0dOU46xgD2zh6do1m28gdYRrg dCeg== X-Forwarded-Encrypted: i=1; AJvYcCVDmvv6zibRpwzn42R81Rw2equfsel8AVlpiby/vfhpGbhj12QnCWgAyiGx8/OOObhKcsoFpnWUqLPc@vger.kernel.org X-Gm-Message-State: AOJu0Yw4u3QA7Ik0XqV/EpaUiuN40veEhWgk8+MXWP5Cv4Qk/2FbuEBb cO+hfN43EGkwCK9S8p4UKyfgBbAw7LwG+6SasCdlBNYecWgPOAPoXton+4M1Hlo= X-Google-Smtp-Source: AGHT+IHpgT9Fnvdd8Os6CvbTIWJb/pht/ROcNHvodcKIAP9VYk00V2IhRdT7gRJOIpwjFKL4MBk0Hg== X-Received: by 2002:a17:907:6e89:b0:a7a:9144:e23a with SMTP id a640c23a62f3a-a9a69c687d8mr1274360966b.43.1729515761922; Mon, 21 Oct 2024 06:02:41 -0700 (PDT) Received: from neptune.lan ([188.27.132.100]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91370e33sm202310366b.120.2024.10.21.06.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 06:02:41 -0700 (PDT) From: Alexandru Ardelean To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: jic23@kernel.org, krzk+dt@kernel.org, robh@kernel.org, lars@metafoo.de, michael.hennerich@analog.com, gstols@baylibre.com, dlechner@baylibre.com, Alexandru Ardelean Subject: [PATCH 3/6] iio: adc: ad7606: use realbits for sign-extending in scan_direct Date: Mon, 21 Oct 2024 16:02:18 +0300 Message-ID: <20241021130221.1469099-4-aardelean@baylibre.com> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241021130221.1469099-1-aardelean@baylibre.com> References: <20241021130221.1469099-1-aardelean@baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the 'ad7606' driver supports parts with 18 and 16 bits resolutions. But when adding support for AD7607 (which has a 14-bit resolution) we should check for the 'realbits' field, to be able to sign-extend correctly. Signed-off-by: Alexandru Ardelean --- drivers/iio/adc/ad7606.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d0fe9fd65f3f..a1f0c2feb04a 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -568,7 +568,7 @@ static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch, int *val) { struct ad7606_state *st = iio_priv(indio_dev); - unsigned int storagebits = st->chip_info->channels[1].scan_type.storagebits; + unsigned int realbits = st->chip_info->channels[1].scan_type.realbits; const struct iio_chan_spec *chan; int ret; @@ -603,15 +603,29 @@ static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch, chan = &indio_dev->channels[ch + 1]; if (chan->scan_type.sign == 'u') { - if (storagebits > 16) + switch (realbits) { + case 18: *val = st->data.buf32[ch]; - else + break; + case 16: *val = st->data.buf16[ch]; + break; + default: + ret = -EINVAL; + break; + } } else { - if (storagebits > 16) + switch (realbits) { + case 18: *val = sign_extend32(st->data.buf32[ch], 17); - else + break; + case 16: *val = sign_extend32(st->data.buf16[ch], 15); + break; + default: + ret = -EINVAL; + break; + } } error_ret: -- 2.46.1