From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6DCC1A257D for ; Tue, 22 Oct 2024 15:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729609823; cv=none; b=cfKMoymk6YonTVETVFBvK8zVAkGJ6YLH+/kncHp7RGONrI0Sl5HuKCFCALTU7zO7FZKG/lKneyLW1RsyequyiUiITKUef1zv5dBqbxzpBifwj/i+wuicGicy26+C0lMOBZvXc7QJ9+mWNm8vBkVuWDaUOSGxmuiPIzgd+RLO3xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729609823; c=relaxed/simple; bh=qTfIuTVAUUhrlUanxecmlRHah06WtvV7DSWHRs4WfLs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lAtIm74XNwrN9veaGNOuMtjpYCV1VD5XBU+NaCmNYVJJlsSGQm0Rg7icwhXEeSGav+XUB24IdOjiIT/lcl2C6NmpvzDWNnAPLnXkHtNt1IDogiWsTyp/WayyVblrxPHJVPgSfLfRkAnuf3AK4GFSBSzPlDHPgyUX24plMnULEjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AbuoS3Xi; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AbuoS3Xi" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e34a089cd3so4692905a91.3 for ; Tue, 22 Oct 2024 08:10:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729609821; x=1730214621; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=MzxEKUQWg3uIWQMJ7O52/X0erwQFBgLhhHBq8a3fZ8A=; b=AbuoS3XiJ4NxLu40b5armtGFlr3JWXPTwAqxli6KbsyfJqLcMem/kUeMTjGT0zi5Y2 2/8BFwlASndr7ISHWZbgbSu/ewt8i8VVs7UU28LP4skjVoI9W7i/B9HVMSmJCwZGlDMS Qfxq+ucLxOIrnBns4M3cED1nQeEKGSahYWoiACN61jw/xizADSxVASpQhMJOs97Wyn/W PAN9by0DUwYuJaN7RZWlbrOJ7wa2D7whjF+/8kuGf5DovOuZ1UpSfxEE3wvC/yO5W11W 0vKOYzf3jLydF6+2/IyJvZph8UrUU2QS4IzLx3V9HcqbfsZiNqnpdpowsql46izKObA6 myTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729609821; x=1730214621; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MzxEKUQWg3uIWQMJ7O52/X0erwQFBgLhhHBq8a3fZ8A=; b=ecw0sJkK3+YILzeCRClWoQdW2bQqLI97AwRS/QdGCh/Sr7KrSONGsdw+tuP6D6khte 6R9w5rudbwzOZ3ZDJfqyhqroct+91ugdR6zYNPI/rXFLcojL3WBJpVArzk/EVlKgsr0j C7tPLy36FVtb7AUHquWNHrq6QNvMC5yQ2lK4myeMbYirQA+a28o1juwBh9+qkNB2JMM2 ZIptfhpNo6HDKPetp8PyWg6c80wnohB+ndeBhB+xwfk/THu9DPJjaafceBoFBF1+PwfD JLZ7+qgX6l5eTiqtV5jPY6mohbuyJ2IgyrP9W1MPiINLNOLXCMXb3nhXJjbOJhHgcPJN k/9A== X-Forwarded-Encrypted: i=1; AJvYcCWgazQ4XR2oN9tnOm1rQzauwFz0H2Mv1nbVSI4EkPkyFRHwRMovgOmJpeauglRs02Zgp+O9jwUOcxj3@vger.kernel.org X-Gm-Message-State: AOJu0YxcAcWBGEcBPxZCH17zprld+pGScaK9GkGnpiK/iDZUsC4ba3gY ulvFYHAE7ncPgZa3wPLe24TApJFPkYp+Iy4qRqU6XJ2ggDXrSQwpsJA805oorQ== X-Google-Smtp-Source: AGHT+IEAUr9zghTEqbLPVOaKd1kA+KWHp2S31/G9XQzAAHxpn+gWkKxU4GM59uffiKAEQIim/PwS5A== X-Received: by 2002:a17:90a:ce8d:b0:2e2:cd65:de55 with SMTP id 98e67ed59e1d1-2e56175742emr18618394a91.20.1729609821009; Tue, 22 Oct 2024 08:10:21 -0700 (PDT) Received: from thinkpad ([36.255.17.224]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e5ad4ed277sm6378409a91.39.2024.10.22.08.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 08:10:20 -0700 (PDT) Date: Tue, 22 Oct 2024 20:40:05 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Krishna Chaitanya Chundru , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_parass@quicinc.com Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Add PCIe nodes Message-ID: <20241022151005.g36xnr7lf46p32ha@thinkpad> References: <20241001101622.ys36slymgjbaz26q@thinkpad> <8459161B-87B8-481F-AE71-3D5156B1CA56@linaro.org> <20241001141948.g74rn6777ywvtcmx@thinkpad> <9c24ba5d-431a-c45e-ce1c-3541eac7d017@quicinc.com> <20241012124334.4gsspgtuud4uudop@thinkpad> <7yzjgqitjvfwricftcpelktwjbgwkjuibwkpodjd6x4gwkjkw3@wkeqp6lqwfqv> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Oct 17, 2024 at 02:12:00PM +0300, Dmitry Baryshkov wrote: > On Wed, Oct 16, 2024 at 10:43:19AM +0530, Krishna Chaitanya Chundru wrote: > > > > > > On 10/14/2024 4:55 AM, Dmitry Baryshkov wrote: > > > On Sat, Oct 12, 2024 at 06:13:34PM +0530, Manivannan Sadhasivam wrote: > > > > On Fri, Oct 11, 2024 at 05:24:29PM +0530, Krishna Chaitanya Chundru wrote: > > > > > > > > [...] > > > > > > > > > > > The logic here is that the fixed endpoints in the switch will get an unique SID > > > > > > > and the devices getting attached to slots will share the same SID of the bus > > > > > > > (this is the usual case with all Qcom SoCs). > > > > > > > > > > > > > > But I guess we would need 'iommu-map-mask' as well. Hope this addresses your > > > > > > > concern. > > > > > > > > > > > > Yes, thank you! > > > > > > > > > > > Hi dimitry & mani, > > > > > > > > > > This particular board variant doesn't expose any open slots to connect > > > > > a different endpoints like another switch(which might have BDF unknown > > > > > to us) so static table should be fine for this board variant. > > > > > > > > > > I tries to add iommu-map-mask property, the issue with that property is > > > > > that the driver is applying the mask to the bdf before searching for the > > > > > entry in the table. If I use a mask value which satisfies all the > > > > > entries in the table ( mask as 0x718) and if a new bdf is enumerated > > > > > lets say 0x600 due to mask 0x718 its value is again 0x600 only. > > > > > > > > > > Can we skip iommu-map-mask property and use only static table for this > > > > > board as we know this board doesn't expose any open slots. > > > > > > > > > > > > > Hmm, I was not aware that it doesn't have open slots. Fine with me then. > > > > > > It doesn't feature open slots, but it has two PCIe connections on HS2 / > > > HS3. Users might attach external PCIe devices. > > > > > > Krishna, could you please clarify, how those two connections are routed? > > > > > For this qps615 board to one of the downstream port (pcie to usb) usb > > hub is connected and to the other downstream port NVMe will be > > connected. > > The board has two PCIe links routed to the HS2 and HS3 connectors. Are > they routed to the PCIe switch? > > Yes, they are not standard slots, but still the board is expandable and > it is possible to connect external PCIe devices. As such it is not > possible to have static SID mapping. > Sorry, I think the conversation got deviated. We have concluded that the endpoints fixed (soldered) in the board will get a fixed SID (because we know what they are) and all other devices going to get connected to HS/LS connectors will get shared SID (because we don't know what they are). Any concern with that? - Mani -- மணிவண்ணன் சதாசிவம்