From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 937CC149013; Wed, 23 Oct 2024 20:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729716581; cv=none; b=eD1U0nnnRMYbVtPckwqsNU9pXIz11q8dEtReJGYfuLn1WpLnvhGEVF3q3o086uZP4OIbPwFNFavFoDF4MgrGOiN669sKQggmDaAG/ZnmLwiWjdPNxSywQxkd63KBTTrPA9qVHL8OcIT9dkarKMBEl1t9i3RbqP+0+RevazHb1xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729716581; c=relaxed/simple; bh=D6rOAupw7nWaOfhbwJhOxY7u+4yNaJ1nMm3CkyxSZ4I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fvBqNmduASY6S8mSJoNeJAcpyIvjEAp38CV8X0G70jy69PDp0K9H9WmU/TFd2Wgd5hVF7oWH/XBTpxDhqLsisKvinXfj8X1dbrP8r0YnC7pSc6cLSLd55YSGqJchq+5UUuvJqo8Ik0P90atfphQc3wzIe9Kuy8im3gAPb2GN16w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SbsmEFuB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SbsmEFuB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 612EEC4CEC6; Wed, 23 Oct 2024 20:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729716581; bh=D6rOAupw7nWaOfhbwJhOxY7u+4yNaJ1nMm3CkyxSZ4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SbsmEFuBcYBJxfd9aKYJEJhvm5sOCBpuq3Gkw8XBVAgaBVAtodo4MzzFydgz9lmre lYFf+4Bc3gblOkDrHaTeXYplOKsx+ARhDq7I84evZ9AqNJW6sdl8mkvHTdvLRiNWq7 HIxQV0FTIhIlXU1I0UWU0dYoCb4/La4ArGqqwj83V1yPu64TjVihcSJtg+Lv4hnx7j nsU4mql2Gn/IGBFQELdRYpyG77D96qEA7RspsiJJx3jVWn3y5NFarKPXPlN+Fhh4du ljtB6NwbDGGW5+zuy3s8XNOWGeFaUUoztmYHWjCyMnJg20bW3Ehuw32LgawaSV0yAA ne0ctkmBg3+FQ== Date: Wed, 23 Oct 2024 21:49:34 +0100 From: Conor Dooley To: Inochi Amaoto Cc: Chen Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Inochi Amaoto , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Giuseppe Cavallaro , Yixun Lan , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac Message-ID: <20241023-paper-crease-befa8239f7f0@spud> References: <20241021103617.653386-1-inochiama@gmail.com> <20241021103617.653386-3-inochiama@gmail.com> <20241022-crisply-brute-45f98632ef78@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HZ3OWjJABGOCrTlm" Content-Disposition: inline In-Reply-To: --HZ3OWjJABGOCrTlm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 23, 2024 at 08:31:24AM +0800, Inochi Amaoto wrote: > On Tue, Oct 22, 2024 at 06:28:06PM +0100, Conor Dooley wrote: > > On Mon, Oct 21, 2024 at 06:36:15PM +0800, Inochi Amaoto wrote: > > > The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC > > > with some extra clock. > > >=20 > > > Add necessary compatible string for this device. > > >=20 > > > Signed-off-by: Inochi Amaoto > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > > .../bindings/net/sophgo,sg2044-dwmac.yaml | 145 ++++++++++++++++= ++ > > > 2 files changed, 146 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/sophgo,sg20= 44-dwmac.yaml > > >=20 > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/= Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index 3c4007cb65f8..69f6bb36970b 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -99,6 +99,7 @@ properties: > > > - snps,dwmac-5.30a > > > - snps,dwxgmac > > > - snps,dwxgmac-2.10 > > > + - sophgo,sg2044-dwmac > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > =20 > > > diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwma= c.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > > new file mode 100644 > > > index 000000000000..93c41550b0b6 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > > @@ -0,0 +1,145 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/net/sophgo,sg2044-dwmac.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: StarFive JH7110 DWMAC glue layer > > > + > > > +maintainers: > > > + - Inochi Amaoto > > > + > > > +select: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - sophgo,sg2044-dwmac > > > + required: > > > + - compatible > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: sophgo,sg2044-dwmac > > > + - const: snps,dwmac-5.30a > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: GMAC main clock > > > + - description: PTP clock > > > + - description: TX clock > > > + > > > + clock-names: > > > + items: > > > + - const: stmmaceth > > > + - const: ptp_ref > > > + - const: tx > > > + > > > + sophgo,syscon: > >=20 > > How many dwmac instances does the sg2044 have? > >=20 >=20 > Only one, there is another 100G dwxgmac instance, but it does not > use this syscon. That dwxgmac is a different device, with a different compatible etc? --HZ3OWjJABGOCrTlm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZxlhXgAKCRB4tDGHoIJi 0pO0AQD5Swmhv1mfvz5DiD/5f5DGV3m+rvoUAhPp697EkSD9KgD/fnWAmf29z3yR O/N/hNkW71ULWbchz7jsFDwGdd6q4Ao= =k7np -----END PGP SIGNATURE----- --HZ3OWjJABGOCrTlm--