[PATCH 1/3] dt-bindings: vendor-prefixes: Add lxd

[PATCH 1/3] dt-bindings: vendor-prefixes: Add lxd

[Rouven Czerwinski]

Add vendor prefix for LXD Research & Display, LLC.
Link: https://www.lxdinc.com/

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index b320a39de7fe4..83d9e49eeb869 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -872,6 +872,8 @@ patternProperties:
     description: Liebherr-Werk Nenzing GmbH
   "^lxa,.*":
     description: Linux Automation GmbH
+  "^lxd,.*":
+    description: LXD Research & Display, LLC
   "^m5stack,.*":
     description: M5Stack
   "^macnica,.*":

base-commit: c2ee9f594da826bea183ed14f2cc029c719bf4da
-- 
2.39.5

[PATCH 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

[Rouven Czerwinski]

The LXD M9189A is a 1024x600 MIPI-DSI panel.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
 .../bindings/display/panel/lxd,m9189a.yaml    | 64 +++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
new file mode 100644
index 0000000000000..49cee8865cae1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LXD M9189 DSI Display Panel
+
+maintainers:
+  - Rouven Czerwinski <r.czerwinski@pengutronix.de>
+
+properties:
+  compatible:
+    const: ronbo,rb070d30
+
+  reg:
+    maxItems: 1
+
+  standby-gpios:
+    description: GPIO used for the standby pin
+    maxItems: 1
+
+  reset-gpios:
+    description: GPIO used for the reset pin
+    maxItems: 1
+
+  vdd-supply:
+    description: Power regulator
+
+  backlight:
+    description: Backlight used by the panel
+    $ref: /schemas/types.yaml#/definitions/phandle
+
+required:
+  - compatible
+  - reg
+  - standby-gpios
+  - reset-gpios
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      panel@0 {
+        compatible = "lxd,m9189a";
+        reg = <0>;
+        backlight = <&backlight>;
+        reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>;
+        standby-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
+
+        port {
+          mipi_panel_in: endpoint {
+            remote-endpoint = <&mipi_dsi_out>;
+          };
+        };
+      };
+    };
-- 
2.39.5

Re: [PATCH 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

[Rouven Czerwinski]

Hi,
On Wed, 2024-10-23 at 14:44 +0200, Rouven Czerwinski wrote:
> The LXD M9189A is a 1024x600 MIPI-DSI panel.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  .../bindings/display/panel/lxd,m9189a.yaml    | 64
> +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> 
> diff --git
> a/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> new file mode 100644
> index 0000000000000..49cee8865cae1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LXD M9189 DSI Display Panel
                   ^ is missing an A
> +
> +maintainers:
> +  - Rouven Czerwinski <r.czerwinski@pengutronix.de>
> +
> +properties:
> +  compatible:
> +    const: ronbo,rb070d30

This is the wrong compatible.

> +
> +  reg:
> +    maxItems: 1
> +
> +  standby-gpios:
> +    description: GPIO used for the standby pin
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: GPIO used for the reset pin
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Power regulator
> +
> +  backlight:
> +    description: Backlight used by the panel
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - reg
> +  - standby-gpios
> +  - reset-gpios
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      panel@0 {
> +        compatible = "lxd,m9189a";
> +        reg = <0>;
> +        backlight = <&backlight>;
> +        reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>;
> +        standby-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
> +
> +        port {
> +          mipi_panel_in: endpoint {
> +            remote-endpoint = <&mipi_dsi_out>;
> +          };
> +        };
> +      };
> +    };

Fixed both for a v2 of this series, will wait for more feedback before
resending.

Best Regards,
Rouven Czerwinski

Re: [PATCH 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

[Rob Herring (Arm)]

On Wed, 23 Oct 2024 14:44:09 +0200, Rouven Czerwinski wrote:
> The LXD M9189A is a 1024x600 MIPI-DSI panel.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  .../bindings/display/panel/lxd,m9189a.yaml    | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Warning: Duplicate compatible "ronbo,rb070d30" found in schemas matching "$id":
	http://devicetree.org/schemas/display/panel/ronbo,rb070d30.yaml#
	http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml#
Documentation/devicetree/bindings/display/panel/lxd,m9189a.example.dtb: /example-0/dsi/panel@0: failed to match any schema with compatible: ['lxd,m9189a']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241023124411.1153552-2-r.czerwinski@pengutronix.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.