[PATCH 1/3] media: dt-bindings: adv7180: Document 'adi,force-bt656-4'

[PATCH 1/3] media: dt-bindings: adv7180: Document 'adi,force-bt656-4'

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

The "adv,force-bt656-4" compatible string causes several dt-schema
warnings because 'adv' is not a valid vendor prefix defined in
vendor-prefixes.yaml:

adv7280@21: 'adv,force-bt656-4' does not match any of the regexes: '^#.*'...

The correct vendor prefix for Analog Devices is 'adi', so change
the property name to 'adi,force-bt656-4'.

Keep the old property for old DTB compatibility and mark it as deprecated.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
index c8d887eee3bb..4371a0ef2761 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
@@ -39,6 +39,12 @@ properties:
     maxItems: 1
 
   adv,force-bt656-4:
+    deprecated: true
+    description:
+      Indicates that the output is a BT.656-4 compatible stream.
+    type: boolean
+
+  adi,force-bt656-4:
     description:
       Indicates that the output is a BT.656-4 compatible stream.
     type: boolean
-- 
2.34.1

[PATCH 2/3] media: adv7180: Also check for "adi,force-bt656-4"

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

According to adv7180.yaml, the correct property name is
"adi,force-bt656-4".

Expand the check to also test against the "adi,force-bt656-4" compatible
string.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 drivers/media/i2c/adv7180.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index 819ff9f7c90f..ff7dfa0278a7 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -1440,7 +1440,8 @@ static int adv7180_probe(struct i2c_client *client)
 		return ret;
 	}
 
-	if (of_property_read_bool(np, "adv,force-bt656-4"))
+	if (of_property_read_bool(np, "adv,force-bt656-4") ||
+	    of_property_read_bool(np, "adi,force-bt656-4"))
 		state->force_bt656_4 = true;
 
 	if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2) {
-- 
2.34.1

Re: [PATCH 2/3] media: adv7180: Also check for "adi,force-bt656-4"

[Krzysztof Kozlowski]

On Wed, Oct 23, 2024 at 11:42:05AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to adv7180.yaml, the correct property name is
> "adi,force-bt656-4".
> 
> Expand the check to also test against the "adi,force-bt656-4" compatible
> string.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 3/3] ARM: dts: imx6qdl-apalis: Change to "adi,force-bt656-4"

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

According to adv7180.yaml, the correct property name is
"adi,force-bt656-4".

Update it accordingly to fix several dt-schema warnings:

adv7280@21: 'adv,force-bt656-4' does not match any of the regexes: ...

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
index 1c72da417011..dffab5aa8b9c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
@@ -691,7 +691,7 @@ &i2c3 {
 
 	adv_7280: adv7280@21 {
 		compatible = "adi,adv7280";
-		adv,force-bt656-4;
+		adi,force-bt656-4;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_ipu1_csi0>;
 		reg = <0x21>;
-- 
2.34.1

Re: [PATCH 3/3] ARM: dts: imx6qdl-apalis: Change to "adi,force-bt656-4"

[Krzysztof Kozlowski]

On Wed, Oct 23, 2024 at 11:42:06AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to adv7180.yaml, the correct property name is
> "adi,force-bt656-4".
> 
> Update it accordingly to fix several dt-schema warnings:
> 
> adv7280@21: 'adv,force-bt656-4' does not match any of the regexes: ...
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

This will affect other users of this DTS, which we try to avoid. Some
sort of analysis if this is used in BSD would be useful.

Best regards,
Krzysztof

Re: [PATCH 3/3] ARM: dts: imx6qdl-apalis: Change to "adi,force-bt656-4"

[Fabio Estevam]

Hi Krzysztof,

On Thu, Oct 24, 2024 at 4:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:

> This will affect other users of this DTS, which we try to avoid. Some
> sort of analysis if this is used in BSD would be useful.

Thanks for the suggestion.

I checked the BSD source code and there is no adv7180 driver available.

Re: [PATCH 3/3] ARM: dts: imx6qdl-apalis: Change to "adi,force-bt656-4"

[Krzysztof Kozlowski]

On 24/10/2024 13:00, Fabio Estevam wrote:
> Hi Krzysztof,
> 
> On Thu, Oct 24, 2024 at 4:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> This will affect other users of this DTS, which we try to avoid. Some
>> sort of analysis if this is used in BSD would be useful.
> 
> Thanks for the suggestion.
> 
> I checked the BSD source code and there is no adv7180 driver available.

OK, thanks. I think it would be useful to add above to commit msg.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/3] media: dt-bindings: adv7180: Document 'adi,force-bt656-4'

[Krzysztof Kozlowski]

On Wed, Oct 23, 2024 at 11:42:04AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The "adv,force-bt656-4" compatible string causes several dt-schema

compatible? Or property?

With above sorted:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof