From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, claudiu.manoil@nxp.com,
xiaoning.wang@nxp.com, Frank.Li@nxp.com,
christophe.leroy@csgroup.eu, linux@armlinux.org.uk,
bhelgaas@google.com, horms@kernel.org, imx@lists.linux.dev,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
alexander.stein@ew.tq-group.com
Subject: Re: [PATCH v5 net-next 07/13] net: enetc: remove ERR050089 workaround for i.MX95
Date: Thu, 24 Oct 2024 20:51:28 +0300 [thread overview]
Message-ID: <20241024175128.7pdwpqr4mlok43cb@skbuf> (raw)
In-Reply-To: <20241024065328.521518-8-wei.fang@nxp.com> <20241024065328.521518-8-wei.fang@nxp.com>
On Thu, Oct 24, 2024 at 02:53:22PM +0800, Wei Fang wrote:
> @@ -62,6 +65,12 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
> goto err_pci_mem_reg;
> }
>
> + if (pdev->vendor == PCI_VENDOR_ID_FREESCALE &&
> + pdev->device == ENETC_MDIO_DEV_ID) {
> + static_branch_inc(&enetc_has_err050089);
> + dev_info(&pdev->dev, "Enabled ERR050089 workaround\n");
> + }
> +
> err = of_mdiobus_register(bus, dev->of_node);
> if (err)
> goto err_mdiobus_reg;
If of_mdiobus_register() fails, we should disable the static key.
Perhaps the snippets to enable and disable the static key should be in
helper functions to more easily insert the error teardown logic.
next prev parent reply other threads:[~2024-10-24 17:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 6:53 [PATCH v5 net-next 00/13] add basic support for i.MX95 NETC Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 01/13] dt-bindings: net: add compatible string for i.MX95 EMDIO Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 02/13] dt-bindings: net: add i.MX95 ENETC support Wei Fang
2024-10-25 14:07 ` Rob Herring
2024-10-26 3:24 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 03/13] dt-bindings: net: add bindings for NETC blocks control Wei Fang
2024-10-25 14:08 ` Rob Herring (Arm)
2024-10-24 6:53 ` [PATCH v5 net-next 04/13] net: enetc: add initial netc-blk-ctrl driver support Wei Fang
2024-10-24 16:27 ` Vladimir Oltean
2024-10-25 1:44 ` Wei Fang
2024-10-25 12:43 ` Vladimir Oltean
2024-10-26 2:47 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 05/13] net: enetc: extract common ENETC PF parts for LS1028A and i.MX95 platforms Wei Fang
2024-10-24 16:38 ` Vladimir Oltean
2024-10-25 2:24 ` Wei Fang
2024-10-26 1:34 ` kernel test robot
2024-10-24 6:53 ` [PATCH v5 net-next 06/13] net: enetc: build enetc_pf_common.c as a separate module Wei Fang
2024-10-24 17:34 ` Vladimir Oltean
2024-10-25 3:00 ` Wei Fang
2024-10-25 13:23 ` Vladimir Oltean
2024-10-26 3:23 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 07/13] net: enetc: remove ERR050089 workaround for i.MX95 Wei Fang
2024-10-24 17:51 ` Vladimir Oltean [this message]
2024-10-25 3:04 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 08/13] PCI: Add NXP NETC vendor ID and device IDs Wei Fang
2024-10-24 18:16 ` Bjorn Helgaas
2024-10-25 3:13 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 09/13] net: enetc: add i.MX95 EMDIO support Wei Fang
2024-10-24 18:00 ` Vladimir Oltean
2024-10-25 3:12 ` Wei Fang
2024-10-24 18:01 ` Vladimir Oltean
2024-10-24 6:53 ` [PATCH v5 net-next 10/13] net: enetc: extract enetc_int_vector_init/destroy() from enetc_alloc_msix() Wei Fang
2024-10-24 20:50 ` Vladimir Oltean
2024-10-25 3:27 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 11/13] net: enetc: optimize the allocation of tx_bdr Wei Fang
2024-10-25 9:51 ` Vladimir Oltean
2024-10-26 2:37 ` Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 12/13] net: enetc: add preliminary support for i.MX95 ENETC PF Wei Fang
2024-10-24 6:53 ` [PATCH v5 net-next 13/13] MAINTAINERS: update ENETC driver files and maintainers Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024175128.7pdwpqr4mlok43cb@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.manoil@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).