From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DCDF1D2226; Fri, 25 Oct 2024 08:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729846529; cv=none; b=me7fXVebQxno2TzSXhtbAo7mwNzkREocROKz3KoWmg790unTTHA9p5Y3zWphHXLi7nDPy5MFxu3IFFAkySaDKDGCd0E+K2bzF4+yxm6bo6Ki1lNEC7uLCvSBP/6lS2eNdZJ5fP9FOvp7w8i/ELE/xGPosE9hCRBY+TdpHSlfKhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729846529; c=relaxed/simple; bh=4Lxw01RezOYphFXGoawie2dULwLcNzZ84sWvEpBQ/GQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s6Kl7lYuGPhCEqZHCEsiGSW7unBm1PXqJ0EiaVLz+Ax7aNgu4lvPgxWF2oJ1sgjqw0db/EUZ6pQxTjaws8+fIUGs0MPLyONsGtm0XS1iAIHjVTkxMWmB9QdVGhFCyyyIerh5erXbff9vIkdaY9FX89Z5q36wsi8QFqhYdFBD0yU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jnCMYxyj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jnCMYxyj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33CD0C4CEC3; Fri, 25 Oct 2024 08:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729846528; bh=4Lxw01RezOYphFXGoawie2dULwLcNzZ84sWvEpBQ/GQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jnCMYxyjCWs4g24xlPpyGqA+nny7QVptdHr0wP6pXVXfiWcyBa2BGjrB+CUiVql2C DA9IEdBvgflao/nUJbNIPWXjEU8WxecOJ1hHmNiKbxfcMhV19jYWBoudpra9YG/RNg SfeYlh1H9sjvet48blrj/VLAXGAa1bkYFgAetIIS75cbx6c0G2hVV7xBomfNKjnXAH 9I/k2KHreokbDnXl23tabpB8eVH+UaXuPwHpJHH9nyxSfvFbJdtyym4IaZjzeBcGwE 5FzuLXjBnfzY/GIs3BAU3Yba+vi2fT/yvS4zV7RyLd1p8s9abXZeBlKnJ8m2G4xrje 2ZnyDDMh93qMg== Date: Fri, 25 Oct 2024 09:55:23 +0100 From: Lee Jones To: Dzmitry Sankouski Cc: Sebastian Reichel , Chanwoo Choi , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Dmitry Torokhov , Pavel Machek , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v6 7/7] leds: max77705: Add LEDs support Message-ID: <20241025085523.GC10824@google.com> References: <20241007-starqltechn_integration_upstream-v6-0-0d38b5090c57@gmail.com> <20241007-starqltechn_integration_upstream-v6-7-0d38b5090c57@gmail.com> <20241015143329.GJ8348@google.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 22 Oct 2024, Dzmitry Sankouski wrote: > (...) > > > drivers/leds/leds-max77705.c | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > > Lol! How big is your terminal? :) > > > > Dunno actually, this was generated by b4 > > (...) > > > > No C++ comments please. > > > > This conflicts with https://patchwork.kernel.org/comment/25898728/ a) That's just for the header. b) That's a different subsystem and Mark's choice. > > > + ret = regmap_update_bits(led->regmap, > > > + MAX77705_RGBLED_REG_LEDEN, > > > + MAX77705_LED_EN_MASK << led->en_shift, 0); > > > + max77705_rgb_blink(cdev, &blink_default, &blink_default); > > > + } else { > > > + // Set current > > > + ret = regmap_write(led->regmap, > > > + led->reg_brightness, brightness); > > > > Line wrap at 100-chars. > > > > From coding-style.rst: > `The preferred limit on the length of a single line is 80 columns.` > I only exceed 80 chars, when there's no good wrapping. a) This is old guidance b) A lot of your lines already break the 80-char rule. -- Lee Jones [李琼斯]