* [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: add SAR2130P aDSP compatible
2024-10-26 22:09 [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P Dmitry Baryshkov
@ 2024-10-26 22:09 ` Dmitry Baryshkov
2024-10-27 21:08 ` Krzysztof Kozlowski
2024-10-26 22:09 ` [PATCH 2/3] remoteproc: qcom: pas: add minidump_id to SM8350 resources Dmitry Baryshkov
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Dmitry Baryshkov @ 2024-10-26 22:09 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
Document compatible for audio DSP on Qualcomm SAR2130P platform.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
index 4b9fb74fb9e966b61d51fe578b636f967e4c6af8..fd3423e6051bc8bb0e783479360a7b38e5fa1358 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
@@ -16,6 +16,7 @@ description:
properties:
compatible:
enum:
+ - qcom,sar2130p-adsp-pas
- qcom,sm8350-adsp-pas
- qcom,sm8350-cdsp-pas
- qcom,sm8350-slpi-pas
@@ -61,6 +62,7 @@ allOf:
properties:
compatible:
enum:
+ - qcom,sar2130p-adsp-pas
- qcom,sm8350-adsp-pas
- qcom,sm8350-cdsp-pas
- qcom,sm8350-slpi-pas
@@ -101,6 +103,7 @@ allOf:
properties:
compatible:
enum:
+ - qcom,sar2130p-adsp-pas
- qcom,sm8350-adsp-pas
- qcom,sm8350-slpi-pas
- qcom,sm8450-adsp-pas
--
2.39.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: add SAR2130P aDSP compatible
2024-10-26 22:09 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: add SAR2130P aDSP compatible Dmitry Baryshkov
@ 2024-10-27 21:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-27 21:08 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul, linux-arm-msm, linux-remoteproc, devicetree,
linux-kernel
On Sun, Oct 27, 2024 at 01:09:43AM +0300, Dmitry Baryshkov wrote:
> Document compatible for audio DSP on Qualcomm SAR2130P platform.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] remoteproc: qcom: pas: add minidump_id to SM8350 resources
2024-10-26 22:09 [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P Dmitry Baryshkov
2024-10-26 22:09 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: add SAR2130P aDSP compatible Dmitry Baryshkov
@ 2024-10-26 22:09 ` Dmitry Baryshkov
2024-10-28 8:30 ` neil.armstrong
2024-10-26 22:09 ` [PATCH 3/3] remoteproc: qcom: pas: enable SAR2130P audio DSP support Dmitry Baryshkov
2024-11-15 8:03 ` [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P Dmitry Baryshkov
3 siblings, 1 reply; 8+ messages in thread
From: Dmitry Baryshkov @ 2024-10-26 22:09 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
Specify minidump_id for the SM8350 DSPs. It was omitted for in the
original commit e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS
remoteprocs").
Fixes: e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/remoteproc/qcom_q6v5_pas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index ef82835e98a4efd4bc603cff604d531a51fe9f9c..b10b4fc84f14eb40d64b278a339f2ceb45250a62 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -923,6 +923,7 @@ static const struct adsp_data sm8350_adsp_resource = {
.crash_reason_smem = 423,
.firmware_name = "adsp.mdt",
.pas_id = 1,
+ .minidump_id = 5,
.auto_boot = true,
.proxy_pd_names = (char*[]){
"lcx",
@@ -1124,6 +1125,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
.crash_reason_smem = 601,
.firmware_name = "cdsp.mdt",
.pas_id = 18,
+ .minidump_id = 7,
.auto_boot = true,
.proxy_pd_names = (char*[]){
"cx",
--
2.39.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] remoteproc: qcom: pas: add minidump_id to SM8350 resources
2024-10-26 22:09 ` [PATCH 2/3] remoteproc: qcom: pas: add minidump_id to SM8350 resources Dmitry Baryshkov
@ 2024-10-28 8:30 ` neil.armstrong
0 siblings, 0 replies; 8+ messages in thread
From: neil.armstrong @ 2024-10-28 8:30 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
On 27/10/2024 00:09, Dmitry Baryshkov wrote:
> Specify minidump_id for the SM8350 DSPs. It was omitted for in the
> original commit e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS
> remoteprocs").
>
> Fixes: e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index ef82835e98a4efd4bc603cff604d531a51fe9f9c..b10b4fc84f14eb40d64b278a339f2ceb45250a62 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -923,6 +923,7 @@ static const struct adsp_data sm8350_adsp_resource = {
> .crash_reason_smem = 423,
> .firmware_name = "adsp.mdt",
> .pas_id = 1,
> + .minidump_id = 5,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> "lcx",
> @@ -1124,6 +1125,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
> .crash_reason_smem = 601,
> .firmware_name = "cdsp.mdt",
> .pas_id = 18,
> + .minidump_id = 7,
> .auto_boot = true,
> .proxy_pd_names = (char*[]){
> "cx",
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] remoteproc: qcom: pas: enable SAR2130P audio DSP support
2024-10-26 22:09 [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P Dmitry Baryshkov
2024-10-26 22:09 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: add SAR2130P aDSP compatible Dmitry Baryshkov
2024-10-26 22:09 ` [PATCH 2/3] remoteproc: qcom: pas: add minidump_id to SM8350 resources Dmitry Baryshkov
@ 2024-10-26 22:09 ` Dmitry Baryshkov
2024-10-28 8:30 ` neil.armstrong
2024-11-15 8:03 ` [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P Dmitry Baryshkov
3 siblings, 1 reply; 8+ messages in thread
From: Dmitry Baryshkov @ 2024-10-26 22:09 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
Enable support for the Audio DSP on the Qualcomm SAR2130P platform,
reusing the SM8350 resources.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index b10b4fc84f14eb40d64b278a339f2ceb45250a62..5944272bc2e414ea2258eb382452a74c1a742d13 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1423,6 +1423,7 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sa8775p-cdsp1-pas", .data = &sa8775p_cdsp1_resource},
{ .compatible = "qcom,sa8775p-gpdsp0-pas", .data = &sa8775p_gpdsp0_resource},
{ .compatible = "qcom,sa8775p-gpdsp1-pas", .data = &sa8775p_gpdsp1_resource},
+ { .compatible = "qcom,sar2130p-adsp-pas", .data = &sm8350_adsp_resource},
{ .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource},
{ .compatible = "qcom,sc7180-mpss-pas", .data = &mpss_resource_init},
{ .compatible = "qcom,sc7280-adsp-pas", .data = &sm8350_adsp_resource},
--
2.39.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] remoteproc: qcom: pas: enable SAR2130P audio DSP support
2024-10-26 22:09 ` [PATCH 3/3] remoteproc: qcom: pas: enable SAR2130P audio DSP support Dmitry Baryshkov
@ 2024-10-28 8:30 ` neil.armstrong
0 siblings, 0 replies; 8+ messages in thread
From: neil.armstrong @ 2024-10-28 8:30 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
On 27/10/2024 00:09, Dmitry Baryshkov wrote:
> Enable support for the Audio DSP on the Qualcomm SAR2130P platform,
> reusing the SM8350 resources.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index b10b4fc84f14eb40d64b278a339f2ceb45250a62..5944272bc2e414ea2258eb382452a74c1a742d13 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1423,6 +1423,7 @@ static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,sa8775p-cdsp1-pas", .data = &sa8775p_cdsp1_resource},
> { .compatible = "qcom,sa8775p-gpdsp0-pas", .data = &sa8775p_gpdsp0_resource},
> { .compatible = "qcom,sa8775p-gpdsp1-pas", .data = &sa8775p_gpdsp1_resource},
> + { .compatible = "qcom,sar2130p-adsp-pas", .data = &sm8350_adsp_resource},
> { .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource},
> { .compatible = "qcom,sc7180-mpss-pas", .data = &mpss_resource_init},
> { .compatible = "qcom,sc7280-adsp-pas", .data = &sm8350_adsp_resource},
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P
2024-10-26 22:09 [PATCH 0/3] remoteproc: qcom: pas: enable ADSP support on Qualcomm SAR2130P Dmitry Baryshkov
` (2 preceding siblings ...)
2024-10-26 22:09 ` [PATCH 3/3] remoteproc: qcom: pas: enable SAR2130P audio DSP support Dmitry Baryshkov
@ 2024-11-15 8:03 ` Dmitry Baryshkov
3 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2024-11-15 8:03 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Vinod Koul
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
On Sun, Oct 27, 2024 at 01:09:42AM +0300, Dmitry Baryshkov wrote:
> Enable Audio DSP support on the Qualcomm SAR2130P platform. The CDSP,
> also present on this SoC, crashes the device during the start and is
> thus omitted from the series.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Dmitry Baryshkov (3):
> dt-bindings: remoteproc: qcom,sm8350-pas: add SAR2130P aDSP compatible
> remoteproc: qcom: pas: add minidump_id to SM8350 resources
> remoteproc: qcom: pas: enable SAR2130P audio DSP support
Please excuse me, is there a reason why the series wasn't picked up for
6.13?
>
> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 3 +++
> drivers/remoteproc/qcom_q6v5_pas.c | 3 +++
> 2 files changed, 6 insertions(+)
> ---
> base-commit: a39230ecf6b3057f5897bc4744a790070cfbe7a8
> change-id: 20241027-sar2130p-adsp-fc3fad54ded3
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread