From: Jonathan Cameron <jic23@kernel.org>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andriy.shevchenko@linux.intel.com,
anshulusr@gmail.com, gustavograzs@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/13] iio: chemical: bme680: move to fsleep()
Date: Sun, 27 Oct 2024 10:01:08 +0000 [thread overview]
Message-ID: <20241027100108.061c9074@jic23-huawei> (raw)
In-Reply-To: <20241021195316.58911-6-vassilisamir@gmail.com>
On Mon, 21 Oct 2024 21:53:08 +0200
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> Use the new fsleep() function in the remaining driver instances.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Applied. Note I'm applying these having skipped patch 4, so at somepoint I may
hit a conflict with that and stop even if this code in the later patches is fine.
Jonathan
> ---
> drivers/iio/chemical/bme680_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> index 9002519d2c33..2ff85e29bfc1 100644
> --- a/drivers/iio/chemical/bme680_core.c
> +++ b/drivers/iio/chemical/bme680_core.c
> @@ -544,7 +544,7 @@ static int bme680_wait_for_eoc(struct bme680_data *data)
> data->oversampling_humid) * 1936) + (477 * 4) +
> (477 * 5) + 1000 + (data->heater_dur * 1000);
>
> - usleep_range(wait_eoc_us, wait_eoc_us + 100);
> + fsleep(wait_eoc_us);
>
> ret = regmap_read(data->regmap, BME680_REG_MEAS_STAT_0, &data->check);
> if (ret) {
> @@ -890,7 +890,7 @@ int bme680_core_probe(struct device *dev, struct regmap *regmap,
> if (ret < 0)
> return dev_err_probe(dev, ret, "Failed to reset chip\n");
>
> - usleep_range(BME680_STARTUP_TIME_US, BME680_STARTUP_TIME_US + 1000);
> + fsleep(BME680_STARTUP_TIME_US);
>
> ret = regmap_read(regmap, BME680_REG_CHIP_ID, &data->check);
> if (ret < 0)
next prev parent reply other threads:[~2024-10-27 10:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 19:53 [PATCH v2 00/13]: chemical: bme680: 2nd set of cleanup Vasileios Amoiridis
2024-10-21 19:53 ` [PATCH v2 01/13] iio: chemical: bme680: Fix missing header Vasileios Amoiridis
2024-10-21 20:13 ` Greg KH
2024-10-27 9:48 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 02/13] iio: chemical: bme680: optimize startup time Vasileios Amoiridis
2024-10-27 9:53 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 03/13] iio: chemical: bme680: avoid using camel case Vasileios Amoiridis
2024-10-27 9:54 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 04/13] iio: chemical: bme680: refactorize set_mode() mode Vasileios Amoiridis
2024-10-27 9:56 ` Jonathan Cameron
2024-10-27 9:59 ` Jonathan Cameron
2024-10-29 23:28 ` Vasileios Amoiridis
2024-10-21 19:53 ` [PATCH v2 05/13] iio: chemical: bme680: move to fsleep() Vasileios Amoiridis
2024-10-27 10:01 ` Jonathan Cameron [this message]
2024-10-21 19:53 ` [PATCH v2 06/13] iio: chemical: bme680: Fix indentation and unnecessary spaces Vasileios Amoiridis
2024-10-27 10:08 ` Jonathan Cameron
2024-10-27 10:10 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 07/13] iio: chemical: bme680: generalize read_*() functions Vasileios Amoiridis
2024-10-27 10:11 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 08/13] iio: chemical: bme680: Add SCALE and RAW channels Vasileios Amoiridis
2024-10-27 10:12 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 09/13] iio: chemical: bme680: Add triggered buffer support Vasileios Amoiridis
2024-10-27 10:18 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 10/13] iio: chemical: bme680: Add support for preheat current Vasileios Amoiridis
2024-10-21 19:53 ` [PATCH v2 11/13] dt-bindings: iio: add binding for BME680 driver Vasileios Amoiridis
2024-10-21 21:22 ` Rob Herring (Arm)
2024-10-22 13:41 ` Rob Herring
2024-10-22 17:24 ` Jonathan Cameron
2024-10-21 19:53 ` [PATCH v2 12/13] iio: chemical: bme680: add regulators Vasileios Amoiridis
2024-10-21 19:53 ` [PATCH v2 13/13] iio: chemical: bme680: add power management Vasileios Amoiridis
2024-10-27 10:30 ` Jonathan Cameron
2024-10-30 0:24 ` Vasileios Amoiridis
2024-10-30 20:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241027100108.061c9074@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavograzs@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).