From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0445745948; Sun, 27 Oct 2024 10:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730023831; cv=none; b=dlRVE1Z7nC/CGMl5Ff2nBn/0NqetuOU+QxWoZgmnZia717dc2hx3usmNco4e1IGXkLjGfjHK2TqSVV4kpDIbW8rnj/aCDmGpCpWIhwOZGh8krGWHcXu8OPyICMZVJiZ+YhMVgX9GTJ9OMppP9iFKoVX6c8SPnyL1Jki5xUxkrN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730023831; c=relaxed/simple; bh=lw8U2aLzl/XR1NEw0rIOvyVYsEdGY9SLHu+vbkRnhBw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lXgPXjCuLxRv5pXA+e16+I8an4EL4YdXCkPZ7OW6+j164HT3nxn3Tj0SS9i555OGcwGemr36XjyVUsP5/IjwsairpCrS0xe0m/iMrq5GDxQrX8EuUDS9wZPl5vzunCo0P+h1MWXIUKCNgnUAR22p4olWkBd4qWJ9TxCv5Wc8m+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qw33c0Jj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qw33c0Jj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BF60C4CEC3; Sun, 27 Oct 2024 10:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730023830; bh=lw8U2aLzl/XR1NEw0rIOvyVYsEdGY9SLHu+vbkRnhBw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qw33c0JjZHbEcUlZFOWDBtKnpzOOKiYR0elkp+CaOXDmP/xkTVPStk2ivlSGtoefA nHwMzVVGxP1VlYJV5FkGv05/lSsl6aKb6Ei5jtk73TNvugH55uB7iaFQc2PinpmWVT RLm6psjj7/G8vV3JhXa6Yx4ABkP4UnRe3yEAbQc7t4f7FzO2VRsywr+yUedKVkNBpR /FJl/jXds9y/KJ1XTOmIKYUCI8XgpCq0DfZ7eJcgOXK/eDDzrpuWlhsUomRVPyhmhK ywf/79iES7DqbPHsmZY4KVK5HS0ePZ2zf1IwJIDQpL8V2xnwH3cO0zb7kHrFYFHCHA 7Z4+E8TEpU9RA== Date: Sun, 27 Oct 2024 10:10:22 +0000 From: Jonathan Cameron To: Vasileios Amoiridis Cc: lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andriy.shevchenko@linux.intel.com, anshulusr@gmail.com, gustavograzs@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/13] iio: chemical: bme680: Fix indentation and unnecessary spaces Message-ID: <20241027101022.353ffddf@jic23-huawei> In-Reply-To: <20241027100841.46cafdb2@jic23-huawei> References: <20241021195316.58911-1-vassilisamir@gmail.com> <20241021195316.58911-7-vassilisamir@gmail.com> <20241027100841.46cafdb2@jic23-huawei> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 27 Oct 2024 10:08:41 +0000 Jonathan Cameron wrote: > On Mon, 21 Oct 2024 21:53:09 +0200 > Vasileios Amoiridis wrote: > > > Fix indentation issues, line breaking and unnecessary spaces > > reported by checkpatch.pl. I also rewrote this description as it doesn't mention the type casting change. > > > > Signed-off-by: Vasileios Amoiridis > > --- > > drivers/iio/chemical/bme680_core.c | 21 +++++++++------------ > > 1 file changed, 9 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c > > index 2ff85e29bfc1..2ad427f5deb4 100644 > > --- a/drivers/iio/chemical/bme680_core.c > > +++ b/drivers/iio/chemical/bme680_core.c > > @@ -229,7 +229,7 @@ static int bme680_read_calib(struct bme680_data *data, > > calib->res_heat_val = data->bme680_cal_buf_3[RES_HEAT_VAL]; > > > > calib->res_heat_range = FIELD_GET(BME680_RHRANGE_MASK, > > - data->bme680_cal_buf_3[RES_HEAT_RANGE]); > > + data->bme680_cal_buf_3[RES_HEAT_RANGE]); > > > > calib->range_sw_err = FIELD_GET(BME680_RSERROR_MASK, > > data->bme680_cal_buf_3[RANGE_SW_ERR]); > > @@ -450,12 +450,12 @@ static u32 bme680_compensate_gas(struct bme680_data *data, u16 gas_res_adc, > > 2147483647u, 2126008810u, 2147483647u, 2147483647u > > }; > > > > - var1 = ((1340 + (5 * (s64) calib->range_sw_err)) * > > - ((s64)lookup_table[gas_range])) >> 16; > > + var1 = ((1340LL + (5 * calib->range_sw_err)) * > > + (lookup_table[gas_range])) >> 16; > > Everything other than this one is straight forward and requires > checking types of range_sw_err is less than 32 bit for example. > > For cleanup I'd normally avoid these subtle cases. > An extra type case or two does little harm to readability. > > Anyhow, with that in mind I've applied anyway. > > > > var2 = ((gas_res_adc << 15) - 16777216) + var1; > > var3 = ((125000 << (15 - gas_range)) * var1) >> 9; > > var3 += (var2 >> 1); > > - calc_gas_res = div64_s64(var3, (s64) var2); > > + calc_gas_res = div64_s64(var3, (s64)var2); > > > > return calc_gas_res; > > } > > @@ -473,7 +473,7 @@ static u8 bme680_calc_heater_res(struct bme680_data *data, u16 temp) > > if (temp > 400) /* Cap temperature */ > > temp = 400; > > > > - var1 = (((s32) BME680_AMB_TEMP * calib->par_gh3) / 1000) * 256; > > + var1 = (((s32)BME680_AMB_TEMP * calib->par_gh3) / 1000) * 256; > > var2 = (calib->par_gh1 + 784) * (((((calib->par_gh2 + 154009) * > > temp * 5) / 100) > > + 3276800) / 10); > > @@ -569,9 +569,8 @@ static int bme680_chip_config(struct bme680_data *data) > > int ret; > > u8 osrs; > > > > - osrs = FIELD_PREP( > > - BME680_OSRS_HUMIDITY_MASK, > > - bme680_oversampling_to_reg(data->oversampling_humid)); > > + osrs = FIELD_PREP(BME680_OSRS_HUMIDITY_MASK, > > + bme680_oversampling_to_reg(data->oversampling_humid)); > > /* > > * Highly recommended to set oversampling of humidity before > > * temperature/pressure oversampling. > > @@ -585,8 +584,7 @@ static int bme680_chip_config(struct bme680_data *data) > > > > /* IIR filter settings */ > > ret = regmap_update_bits(data->regmap, BME680_REG_CONFIG, > > - BME680_FILTER_MASK, > > - BME680_FILTER_COEFF_VAL); > > + BME680_FILTER_MASK, BME680_FILTER_COEFF_VAL); > > if (ret < 0) { > > dev_err(dev, "failed to write config register\n"); > > return ret; > > @@ -885,8 +883,7 @@ int bme680_core_probe(struct device *dev, struct regmap *regmap, > > data->heater_temp = 320; /* degree Celsius */ > > data->heater_dur = 150; /* milliseconds */ > > > > - ret = regmap_write(regmap, BME680_REG_SOFT_RESET, > > - BME680_CMD_SOFTRESET); > > + ret = regmap_write(regmap, BME680_REG_SOFT_RESET, BME680_CMD_SOFTRESET); > > if (ret < 0) > > return dev_err_probe(dev, ret, "Failed to reset chip\n"); > > >