devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries
@ 2024-10-18 13:13 Abel Vesa
  2024-10-21  7:57 ` Krzysztof Kozlowski
  2024-10-28 17:59 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Abel Vesa @ 2024-10-18 13:13 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Sibi Sankar, Rajendra Nayak
  Cc: Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
	kernel test robot, Abel Vesa

Document the missing Broadcast_AND region for x1e80100.

Fixes: e9ceb595c2d3 ("dt-bindings: cache: qcom,llcc: Add X1E80100 compatible")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410181235.L7MF7z48-lkp@intel.com/
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 .../devicetree/bindings/cache/qcom,llcc.yaml       | 36 ++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
index 68ea5f70b75f031cd8b23cf48d566c3a760dab77..ee7edc6f60e2b4bf39ddc7c7ba8a8447c990c7bb 100644
--- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
@@ -39,11 +39,11 @@ properties:
 
   reg:
     minItems: 2
-    maxItems: 9
+    maxItems: 10
 
   reg-names:
     minItems: 2
-    maxItems: 9
+    maxItems: 10
 
   interrupts:
     maxItems: 1
@@ -134,6 +134,36 @@ allOf:
               - qcom,qdu1000-llcc
               - qcom,sc8180x-llcc
               - qcom,sc8280xp-llcc
+    then:
+      properties:
+        reg:
+          items:
+            - description: LLCC0 base register region
+            - description: LLCC1 base register region
+            - description: LLCC2 base register region
+            - description: LLCC3 base register region
+            - description: LLCC4 base register region
+            - description: LLCC5 base register region
+            - description: LLCC6 base register region
+            - description: LLCC7 base register region
+            - description: LLCC broadcast base register region
+        reg-names:
+          items:
+            - const: llcc0_base
+            - const: llcc1_base
+            - const: llcc2_base
+            - const: llcc3_base
+            - const: llcc4_base
+            - const: llcc5_base
+            - const: llcc6_base
+            - const: llcc7_base
+            - const: llcc_broadcast_base
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
               - qcom,x1e80100-llcc
     then:
       properties:
@@ -148,6 +178,7 @@ allOf:
             - description: LLCC6 base register region
             - description: LLCC7 base register region
             - description: LLCC broadcast base register region
+            - description: LLCC broadcast AND register region
         reg-names:
           items:
             - const: llcc0_base
@@ -159,6 +190,7 @@ allOf:
             - const: llcc6_base
             - const: llcc7_base
             - const: llcc_broadcast_base
+            - const: llcc_broadcast_and_base
 
   - if:
       properties:

---
base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
change-id: 20241018-qcom-llcc-bindings-reg-ranges-fix-76437ff4c99f

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries
  2024-10-18 13:13 [PATCH] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries Abel Vesa
@ 2024-10-21  7:57 ` Krzysztof Kozlowski
  2024-10-28 17:59 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-21  7:57 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Sibi Sankar, Rajendra Nayak, linux-arm-msm,
	devicetree, linux-kernel, kernel test robot

On Fri, Oct 18, 2024 at 04:13:47PM +0300, Abel Vesa wrote:
> Document the missing Broadcast_AND region for x1e80100.
> 
> Fixes: e9ceb595c2d3 ("dt-bindings: cache: qcom,llcc: Add X1E80100 compatible")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410181235.L7MF7z48-lkp@intel.com/
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  .../devicetree/bindings/cache/qcom,llcc.yaml       | 36 ++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries
  2024-10-18 13:13 [PATCH] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries Abel Vesa
  2024-10-21  7:57 ` Krzysztof Kozlowski
@ 2024-10-28 17:59 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-10-28 17:59 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
	Sibi Sankar, Rajendra Nayak, Krzysztof Kozlowski, linux-arm-msm,
	devicetree, linux-kernel, kernel test robot

On Fri, Oct 18, 2024 at 04:13:47PM +0300, Abel Vesa wrote:
> Document the missing Broadcast_AND region for x1e80100.
> 
> Fixes: e9ceb595c2d3 ("dt-bindings: cache: qcom,llcc: Add X1E80100 compatible")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410181235.L7MF7z48-lkp@intel.com/
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  .../devicetree/bindings/cache/qcom,llcc.yaml       | 36 ++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)

Applied, thanks.

Rob


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-28 17:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 13:13 [PATCH] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries Abel Vesa
2024-10-21  7:57 ` Krzysztof Kozlowski
2024-10-28 17:59 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).