From: Herve Codina <herve.codina@bootlin.com>
To: Marek Vasut <marex@denx.de>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Walle <mwalle@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism
Date: Mon, 28 Oct 2024 19:19:48 +0100 [thread overview]
Message-ID: <20241028191948.5fd1bd6d@bootlin.com> (raw)
In-Reply-To: <c9c5064e-e780-4bfe-b85d-7930df7a5443@denx.de>
On Mon, 28 Oct 2024 15:47:25 +0100
Marek Vasut <marex@denx.de> wrote:
> On 10/28/24 2:52 PM, Herve Codina wrote:
> > Hi Marek,
>
> Hi,
>
> >>> On Sat, 26 Oct 2024 00:53:51 +0200
> >>> Marek Vasut <marex@denx.de> wrote:
> >>>
> >>>> On 10/24/24 11:55 AM, Herve Codina wrote:
> >>>>> In some cases observed during ESD tests, the TI SN65DSI83 cannot recover
> >>>>> from errors by itself. A full restart of the bridge is needed in those
> >>>>> cases to have the bridge output LVDS signals again.
> >>>>
> >>>> I have seen the bridge being flaky sometimes, do you have any more
> >>>> details of what is going on when this irrecoverable error occurs ?
> >>>
> >>> The panel attached to the bridge goes and stays black. That's the behavior.
> >>> A full reset brings the panel back displaying frames.
> >> Is there some noticeable change in 0xe0/0xe1/0xe5 registers, esp. 0xe5,
> >> do they indicate the error occurred somehow ?
> >
> > 0xe5 register can signal any DSI errors (depending on when the ESD affects
> > the DSI bus) even PLL unlock bit was observed set but we didn't see any
> > relationship between the bits set in 0xe5 register and the recoverable or
> > unrecoverable behavior.
> >
> > Also, in some cases, reading the register was not even possible (i2c
> > transaction nacked).
> Oh, wow, I haven't seen that one before. But this is really useful
> information, can you please add it into the commit message for V2 ?
Yes, I will add this information in v2.
Best regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-10-28 18:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:55 [PATCH 0/2] Add support for errors recovery in the TI SN65DSI83 bridge driver Herve Codina
2024-10-24 9:55 ` [PATCH 1/2] dt-bindings: display: bridge: sn65dsi83: Add interrupt Herve Codina
2024-10-24 16:30 ` Conor Dooley
2024-10-27 15:01 ` Laurent Pinchart
2024-10-24 9:55 ` [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism Herve Codina
2024-10-25 22:53 ` Marek Vasut
2024-10-28 8:02 ` Herve Codina
2024-10-28 11:47 ` Marek Vasut
2024-10-28 13:52 ` Herve Codina
2024-10-28 14:47 ` Marek Vasut
2024-10-28 18:19 ` Herve Codina [this message]
2024-10-27 16:23 ` Laurent Pinchart
2024-10-28 8:13 ` Herve Codina
2024-10-28 11:28 ` Laurent Pinchart
2024-10-28 12:21 ` Maxime Ripard
2024-10-28 13:28 ` Laurent Pinchart
2024-10-28 13:55 ` Maxime Ripard
2024-10-28 14:09 ` Laurent Pinchart
2024-11-05 8:15 ` Herve Codina
2024-11-05 9:47 ` Laurent Pinchart
2024-11-05 9:58 ` Maxime Ripard
2024-10-28 9:16 ` Maxime Ripard
2024-10-29 8:02 ` Andy Yan
2024-10-29 8:28 ` Maxime Ripard
2024-10-28 8:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028191948.5fd1bd6d@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).